All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: Amir Goldstein <amir73il@gmail.com>,
	Christoph Hellwig <hch@lst.de>,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	Eryu Guan <eguan@redhat.com>,
	linux-xfs <linux-xfs@vger.kernel.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	stable <stable@vger.kernel.org>
Subject: Re: [PATCH v2] xfs: preserve i_rdev when recycling a reclaimable inode
Date: Wed, 14 Mar 2018 13:49:13 +0100	[thread overview]
Message-ID: <20180314124913.GA936@lst.de> (raw)
In-Reply-To: <20180314123314.GG18129@dastard>

On Wed, Mar 14, 2018 at 11:33:14PM +1100, Dave Chinner wrote:
> IOWs, if all you're doing is relying on "fixes" tags to determine
> what /might/ be needed in a stable kernel.org update, then your
> stable backport process is fundamentally broken. You're going to
> break things and make stable kernels worse for your users, not
> better.

Agreed.  As someone who has done a fair share of -stable backports
for a customer:  The backport to the last stable release is fairly
easy, as it means picking everything that is not clearly a feature
or cleanup, and you're generally still familiar with the code.  It
still needs quite a lot of QA time.  Backports to older long-term
stable bases can become much more hairy very quickly.

In either case Fixes: tags don't help at all.  What helps is having
one person doing the backports continiously so that they are in the
loop.  So when I had a paying customer for the backports it was
fairly easy for me as I knew where I left off, need to pick up again
and remember the pitfalls of the old stable code.  Randomly Ccing
stable or someone working from Fixes tags has none of those benefits.
And espesically the CC stable is dangerous as there is no QA or
detailed review performed.

  reply	other threads:[~2018-03-14 12:49 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-26  7:44 [PATCH v2] xfs: preserve i_rdev when recycling a reclaimable inode Amir Goldstein
2018-01-26  7:44 ` Christoph Hellwig
2018-01-26 21:44 ` Darrick J. Wong
2018-01-29 11:07   ` Amir Goldstein
2018-01-29 15:50     ` Darrick J. Wong
2018-02-01  0:27       ` Amir Goldstein
2018-02-01  0:29         ` Amir Goldstein
2018-02-01  0:35         ` Darrick J. Wong
2018-03-11 16:08           ` Amir Goldstein
2018-03-11 16:24             ` Greg KH
2018-03-12 16:27               ` Darrick J. Wong
2018-03-12 20:16                 ` Amir Goldstein
2018-03-13  6:48                   ` Amir Goldstein
2018-03-13 12:46                     ` Amir Goldstein
2018-03-13 13:11                       ` Christoph Hellwig
2018-03-13 14:33                         ` Amir Goldstein
2018-03-13 21:50                           ` Dave Chinner
2018-03-14  6:24                             ` Amir Goldstein
2018-03-14 12:33                               ` Dave Chinner
2018-03-14 12:49                                 ` Christoph Hellwig [this message]
2018-03-14 15:45                                   ` Amir Goldstein
2018-03-14 15:46                                     ` Christoph Hellwig
2018-03-14 16:01                                     ` Darrick J. Wong
2018-03-19 13:40                               ` Greg KH
2018-03-19 14:59                                 ` Amir Goldstein
2018-03-19 15:19                                   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180314124913.GA936@lst.de \
    --to=hch@lst.de \
    --cc=amir73il@gmail.com \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=eguan@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.