From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751660AbeCNNzs (ORCPT ); Wed, 14 Mar 2018 09:55:48 -0400 Received: from mail-yw0-f196.google.com ([209.85.161.196]:40349 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbeCNNzr (ORCPT ); Wed, 14 Mar 2018 09:55:47 -0400 X-Google-Smtp-Source: AG47ELtbHffw/R1SqCwtLIfpA2Qf5UkZWO1uf8gzLpQ5iOmPxg6cQWB0f094Biah0qCqSoTDQBTpzg== Date: Wed, 14 Mar 2018 06:55:44 -0700 From: Tejun Heo To: Kirill Tkhai Cc: akpm@linux-foundation.org, cl@linux.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] percpu: Allow to kill tasks doing pcpu_alloc() and waiting for pcpu_balance_workfn() Message-ID: <20180314135544.GT2943022@devbig577.frc2.facebook.com> References: <152102825828.13166.9574628787314078889.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152102825828.13166.9574628787314078889.stgit@localhost.localdomain> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 14, 2018 at 02:51:48PM +0300, Kirill Tkhai wrote: > In case of memory deficit and low percpu memory pages, > pcpu_balance_workfn() takes pcpu_alloc_mutex for a long > time (as it makes memory allocations itself and waits > for memory reclaim). If tasks doing pcpu_alloc() are > choosen by OOM killer, they can't exit, because they > are waiting for the mutex. > > The patch makes pcpu_alloc() to care about killing signal > and use mutex_lock_killable(), when it's allowed by GFP > flags. This guarantees, a task does not miss SIGKILL > from OOM killer. > > Signed-off-by: Kirill Tkhai Applied to percpu/for-4.16-fixes. Thanks, Kirill. -- tejun