From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 0/2] lib: move Netlink wrapper to lib
Date: Thu, 15 Mar 2018 09:26:56 -0700
Message-ID: <20180315092656.11ebb017@xeon-e3>
References: <cover.1520943890.git.nelio.laranjeiro@6wind.com>
 <20180314120855.avapkwbwx6hecwmw@laranjeiro-vm.dev.6wind.com>
 <20180314081736.6b06dd2f@xeon-e3> <2460477.86ImKqUlBA@xps>
 <20180315161905.ypzfsmymdlvsiumc@laranjeiro-vm.dev.6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org, Pascal Mazon
 <pascal.mazon@6wind.com>
To: =?UTF-8?B?TsOpbGlv?= Laranjeiro <nelio.laranjeiro@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com
 [209.85.192.196]) by dpdk.org (Postfix) with ESMTP id 4C5995F29
 for <dev@dpdk.org>; Thu, 15 Mar 2018 17:27:04 +0100 (CET)
Received: by mail-pf0-f196.google.com with SMTP id a16so3010439pfn.9
 for <dev@dpdk.org>; Thu, 15 Mar 2018 09:27:04 -0700 (PDT)
In-Reply-To: <20180315161905.ypzfsmymdlvsiumc@laranjeiro-vm.dev.6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 15 Mar 2018 17:19:05 +0100
N=C3=A9lio Laranjeiro <nelio.laranjeiro@6wind.com> wrote:

> On Thu, Mar 15, 2018 at 04:39:46PM +0100, Thomas Monjalon wrote:
> > 14/03/2018 16:17, Stephen Hemminger: =20
> > > On Wed, 14 Mar 2018 13:08:55 +0100
> > > N=C3=A9lio Laranjeiro <nelio.laranjeiro@6wind.com> wrote: =20
> > > > On Tue, Mar 13, 2018 at 02:20:31PM -0700, Stephen Hemminger wrote: =
=20
> > > > > On Tue, 13 Mar 2018 13:28:25 +0100
> > > > > Nelio Laranjeiro <nelio.laranjeiro@6wind.com> wrote: =20
> > > > > >  drivers/net/tap/Makefile                           |   3 +-
> > > > > >  drivers/net/tap/rte_eth_tap.c                      |  16 +--
> > > > > >  drivers/net/tap/tap_flow.c                         | 118 +++++=
+++++-----------
> > > > > >  drivers/net/tap/tap_netlink.h                      |  42 -----=
---
> > > > > >  drivers/net/tap/tap_tcmsgs.c                       |  28 ++---
> > > > > >  drivers/net/tap/tap_tcmsgs.h                       |   2 +-
> > > > > >  lib/Makefile                                       |   2 +
> > > > > >  lib/librte_netlink/Makefile                        |  26 +++++
> > > > > >  lib/librte_netlink/meson.build                     |  13 +++
> > > > > >  .../librte_netlink/rte_netlink.c                   |  87 +++++=
++++++----
> > > > > >  lib/librte_netlink/rte_netlink.h                   |  43 +++++=
+++
> > > > > >  lib/librte_netlink/rte_netlink_version.map         |  18 ++++ =
=20
> > > > >=20
> > > > > I might have raised this before; but having yet another netlink l=
ibrary is
> > > > > not a great advantage. It would be much better to use a common ex=
ternal library
> > > > > libmnl which is already available on every distribution.   =20
> > > >=20
> > > > The question is more do we really want to have a dependency on a so
> > > > small wrapper for a socket interface? =20
> > >=20
> > > Lots of drivers already have dependencies.
> > > And I trust libmnl rather than a reinvented library. =20
> >=20
> > Are we sure it is commonly installed in distributions?
> >=20

iproute2 now mostly requires libmnl. It is used for several networking types
and extended error reporting.