From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752046AbeCOMxp (ORCPT ); Thu, 15 Mar 2018 08:53:45 -0400 Received: from 8bytes.org ([81.169.241.247]:42076 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbeCOMxo (ORCPT ); Thu, 15 Mar 2018 08:53:44 -0400 Date: Thu, 15 Mar 2018 13:53:42 +0100 From: Joerg Roedel To: Sebastian Andrzej Siewior Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, tglx@linutronix.de Subject: Re: [PATCH 05/10] iommu/amd: remove the special case from get_irq_table() Message-ID: <20180315125342.q74wurk6bdbhl6hy@8bytes.org> References: <20180223222736.18542-1-bigeasy@linutronix.de> <20180223222736.18542-6-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180223222736.18542-6-bigeasy@linutronix.de> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 23, 2018 at 11:27:31PM +0100, Sebastian Andrzej Siewior wrote: > @@ -4103,10 +4093,26 @@ static int irq_remapping_alloc(struct irq_domain *domain, unsigned int virq, > return ret; > > if (info->type == X86_IRQ_ALLOC_TYPE_IOAPIC) { > - if (get_irq_table(devid, true)) > + struct irq_remap_table *table; > + struct amd_iommu *iommu; > + > + table = get_irq_table(devid); > + if (table) { > + if (!table->min_index) { > + /* > + * Keep the first 32 indexes free for IOAPIC > + * interrupts. > + */ > + table->min_index = 32; > + iommu = amd_iommu_rlookup_table[devid]; > + for (i = 0; i < 32; ++i) > + iommu->irte_ops->set_allocated(table, i); > + } I think this needs to be protected by the table->lock.