From: Masami Hiramatsu <mhiramat@kernel.org>
To: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: rostedt@goodmis.org, linux-kernel@vger.kernel.org,
keescook@chromium.org, wangnan0@huawei.com, mingo@redhat.com,
srikar@linux.vnet.ibm.com, oleg@redhat.com, mhiramat@kernel.org,
namhyung@kernel.org
Subject: Re: [PATCH v2 2/2] trace_uprobe: Simplify probes_seq_show()
Date: Thu, 15 Mar 2018 18:31:23 +0900 [thread overview]
Message-ID: <20180315183123.e47cbb238ef59ff964564cbf@kernel.org> (raw)
In-Reply-To: <20180315082756.9050-2-ravi.bangoria@linux.vnet.ibm.com>
On Thu, 15 Mar 2018 13:57:56 +0530
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:
> Simplify probes_seq_show() function. No change in output
> before and after patch.
Yeah, we don't need this trick anymore.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you!
>
> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
> ---
> kernel/trace/trace_uprobe.c | 21 +++------------------
> 1 file changed, 3 insertions(+), 18 deletions(-)
>
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index 0298bd15be83..544fa10a471b 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -602,24 +602,9 @@ static int probes_seq_show(struct seq_file *m, void *v)
> char c = is_ret_probe(tu) ? 'r' : 'p';
> int i;
>
> - seq_printf(m, "%c:%s/%s", c, tu->tp.call.class->system,
> - trace_event_name(&tu->tp.call));
> - seq_printf(m, " %s:", tu->filename);
> -
> - /* Don't print "0x (null)" when offset is 0 */
> - if (tu->offset) {
> - seq_printf(m, "0x%0*lx", (int)(sizeof(void *) * 2), tu->offset);
> - } else {
> - switch (sizeof(void *)) {
> - case 4:
> - seq_printf(m, "0x00000000");
> - break;
> - case 8:
> - default:
> - seq_printf(m, "0x0000000000000000");
> - break;
> - }
> - }
> + seq_printf(m, "%c:%s/%s %s:0x%0*lx", c, tu->tp.call.class->system,
> + trace_event_name(&tu->tp.call), tu->filename,
> + (int)(sizeof(void *) * 2), tu->offset);
>
> for (i = 0; i < tu->tp.nr_args; i++)
> seq_printf(m, " %s=%s", tu->tp.args[i].name, tu->tp.args[i].comm);
> --
> 2.13.6
>
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2018-03-15 9:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 8:27 [PATCH v2 1/2] trace_uprobe: Use %lx to display offset Ravi Bangoria
2018-03-15 8:27 ` [PATCH v2 2/2] trace_uprobe: Simplify probes_seq_show() Ravi Bangoria
2018-03-15 9:31 ` Masami Hiramatsu [this message]
2018-03-15 9:29 ` [PATCH v2 1/2] trace_uprobe: Use %lx to display offset Masami Hiramatsu
2018-04-11 6:12 ` Ravi Bangoria
2018-04-11 12:43 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315183123.e47cbb238ef59ff964564cbf@kernel.org \
--to=mhiramat@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=oleg@redhat.com \
--cc=ravi.bangoria@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.