From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:55022 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753083AbeCPOuP (ORCPT ); Fri, 16 Mar 2018 10:50:15 -0400 Date: Fri, 16 Mar 2018 10:50:14 -0400 (EDT) Message-Id: <20180316.105014.2271384430706235870.davem@redhat.com> To: gvaradar@cisco.com Cc: netdev@vger.kernel.org, benve@cisco.com Subject: Re: [PATCH net-next] enic: drop IP proto check for vxlan tunnel delete From: David Miller In-Reply-To: <20180313122433.1185-1-gvaradar@cisco.com> References: <20180313122433.1185-1-gvaradar@cisco.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Govindarajulu Varadarajan Date: Tue, 13 Mar 2018 05:24:33 -0700 > Commit d11790941dd3 ("enic: Add vxlan offload support for IPv6 pkts") > added vxlan offload support for IPv6 pkts. Required change in > enic_udp_tunnel_del was not made. This creates a bug where once user > adds IPv6 tunnel, hw offload for that cannot be deleted. > > This patch removes check for IP proto in tunnel delete path. Driver need > not check for IP proto since same UDP port cannot be used to create two > tunnels. > > Fixes: d11790941dd3 ("enic: Add vxlan offload support for IPv6 pkts") > Signed-off-by: Govindarajulu Varadarajan Applied, thanks.