All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: subashab@codeaurora.org
Cc: joe@perches.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 4/4] net: qualcomm: rmnet: Implement fill_info
Date: Fri, 16 Mar 2018 12:30:16 -0400 (EDT)	[thread overview]
Message-ID: <20180316.123016.389614962376533370.davem@davemloft.net> (raw)
In-Reply-To: <1521054064-22775-5-git-send-email-subashab@codeaurora.org>

From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Date: Wed, 14 Mar 2018 13:01:04 -0600

> +	if (nla_put_u16(skb, IFLA_VLAN_ID, priv->mux_id))
> +		goto nla_put_failure;
> +
> +	port = rmnet_get_port_rtnl(real_dev);
> +
> +	f.flags = port->data_format;
> +	f.mask  = ~0;
> +
> +	if (nla_put(skb, IFLA_VLAN_FLAGS, sizeof(f), &f))
> +		goto nla_put_failure;

Please don't use VLAN netlink attributes to report rmnet device
specific values.

Instead, please add appropriate new netlink attributes which
clearly show that they are the rmnet mux_id and flags.  You'll
also need to provide UAPI definitions for these flag bits
to go along with the attribute name.

Thanks.

      reply	other threads:[~2018-03-16 16:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14 19:01 [PATCH net-next v3 0/4] net: qualcomm: rmnet: Updates 2018-03-12 Subash Abhinov Kasiviswanathan
2018-03-14 19:01 ` [PATCH net-next v3 1/4] net: qualcomm: rmnet: Fix casting issues Subash Abhinov Kasiviswanathan
2018-03-14 19:01 ` [PATCH net-next v3 2/4] net: qualcomm: rmnet: Update copyright year to 2018 Subash Abhinov Kasiviswanathan
2018-03-14 19:01 ` [PATCH net-next v3 3/4] net: qualcomm: rmnet: Remove unnecessary device assignment Subash Abhinov Kasiviswanathan
2018-03-14 19:01 ` [PATCH net-next v3 4/4] net: qualcomm: rmnet: Implement fill_info Subash Abhinov Kasiviswanathan
2018-03-16 16:30   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180316.123016.389614962376533370.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=netdev@vger.kernel.org \
    --cc=subashab@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.