From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from kirsty.vergenet.net ([202.4.237.240]:34431 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751888AbeCPLtF (ORCPT ); Fri, 16 Mar 2018 07:49:05 -0400 Date: Fri, 16 Mar 2018 12:49:01 +0100 From: Simon Horman To: Fabrizio Castro Cc: Geert Uytterhoeven , Russell King , Magnus Damm , "linux-arm-kernel@lists.infradead.org" , "linux-renesas-soc@vger.kernel.org" , Chris Paterson , Biju Das , Ramesh Shanmugasundaram Subject: Re: [PATCH v7] ARM: shmobile: Add watchdog support Message-ID: <20180316114901.xb76umj4lwo2ad2x@verge.net.au> References: <1521026033-8494-1-git-send-email-fabrizio.castro@bp.renesas.com> <20180314124330.75xbinatpekhm576@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Wed, Mar 14, 2018 at 01:26:52PM +0000, Fabrizio Castro wrote: > Hello Simon, > > > Subject: Re: [PATCH v7] ARM: shmobile: Add watchdog support > > > > On Wed, Mar 14, 2018 at 11:13:53AM +0000, Fabrizio Castro wrote: > > > On R-Car Gen2 and RZ/G1 platforms, we use the SBAR registers to make non > > > boot CPUs run a routine designed to bring up SMP and deal with hot plug. > > > The value contained in the SBAR registers is not initialized by a WDT > > > triggered reset, which means that after a WDT triggered reset we jump > > > to the SMP bring up routine, preventing the system from executing the > > > bootrom code. > > > > > > The purpose of this patch is to jump to the bootrom code in case of a > > > WDT triggered reset, and keep the SMP functionality untouched. > > > In order to tell if the code had been called due to the WDT overflowing > > > we are testing WOVF from register RWTCSRA. > > > > > > The new function shmobile_boot_vector_gen2 isn't replacing > > > shmobile_boot_vector for backward compatibility reasons. The kernel > > > will install the best option (either shmobile_boot_vector or > > > shmobile_boot_vector_gen2) to ICRAM1 after parsing the device tree, > > > according to the amount of memory available. > > > > > > Since shmobile_boot_vector has become bigger, "reg" property of nodes > > > compatible with "renesas,smp-sram" now need to be set to a value > > > greater or equal to "<0 0x60>". > > > > > > Signed-off-by: Fabrizio Castro > > > Signed-off-by: Ramesh Shanmugasundaram > > > Reviewed-by: Geert Uytterhoeven > > > --- > > > v6->v7: > > > * restored ifdef within arch/arm/mach-shmobile/headsmp.S > > > > Thanks. I believe that this is the same as the hand modified > > version of v5 that I applied yesterday. > > yes, I believe v5 modified and applied by you is the same as v7. > Thank you for taking the patch. Likewise, thanks for the patches and for confirming this one is correct. From mboxrd@z Thu Jan 1 00:00:00 1970 From: horms@verge.net.au (Simon Horman) Date: Fri, 16 Mar 2018 12:49:01 +0100 Subject: [PATCH v7] ARM: shmobile: Add watchdog support In-Reply-To: References: <1521026033-8494-1-git-send-email-fabrizio.castro@bp.renesas.com> <20180314124330.75xbinatpekhm576@verge.net.au> Message-ID: <20180316114901.xb76umj4lwo2ad2x@verge.net.au> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Mar 14, 2018 at 01:26:52PM +0000, Fabrizio Castro wrote: > Hello Simon, > > > Subject: Re: [PATCH v7] ARM: shmobile: Add watchdog support > > > > On Wed, Mar 14, 2018 at 11:13:53AM +0000, Fabrizio Castro wrote: > > > On R-Car Gen2 and RZ/G1 platforms, we use the SBAR registers to make non > > > boot CPUs run a routine designed to bring up SMP and deal with hot plug. > > > The value contained in the SBAR registers is not initialized by a WDT > > > triggered reset, which means that after a WDT triggered reset we jump > > > to the SMP bring up routine, preventing the system from executing the > > > bootrom code. > > > > > > The purpose of this patch is to jump to the bootrom code in case of a > > > WDT triggered reset, and keep the SMP functionality untouched. > > > In order to tell if the code had been called due to the WDT overflowing > > > we are testing WOVF from register RWTCSRA. > > > > > > The new function shmobile_boot_vector_gen2 isn't replacing > > > shmobile_boot_vector for backward compatibility reasons. The kernel > > > will install the best option (either shmobile_boot_vector or > > > shmobile_boot_vector_gen2) to ICRAM1 after parsing the device tree, > > > according to the amount of memory available. > > > > > > Since shmobile_boot_vector has become bigger, "reg" property of nodes > > > compatible with "renesas,smp-sram" now need to be set to a value > > > greater or equal to "<0 0x60>". > > > > > > Signed-off-by: Fabrizio Castro > > > Signed-off-by: Ramesh Shanmugasundaram > > > Reviewed-by: Geert Uytterhoeven > > > --- > > > v6->v7: > > > * restored ifdef within arch/arm/mach-shmobile/headsmp.S > > > > Thanks. I believe that this is the same as the hand modified > > version of v5 that I applied yesterday. > > yes, I believe v5 modified and applied by you is the same as v7. > Thank you for taking the patch. Likewise, thanks for the patches and for confirming this one is correct.