* [PATCH 2/2] seq_file: account everything
@ 2018-03-10 8:52 Alexey Dobriyan
2018-03-16 12:43 ` Michal Hocko
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2018-03-10 8:52 UTC (permalink / raw)
To: viro; +Cc: akpm, linux-kernel
All it takes to open a file and read 1 byte from it.
seq_file will be allocated along with any private allocations,
and more importantly seq file buffer which is 1 page by default.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
fs/seq_file.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- a/fs/seq_file.c
+++ b/fs/seq_file.c
@@ -29,7 +29,7 @@ static void seq_set_overflow(struct seq_file *m)
static void *seq_buf_alloc(unsigned long size)
{
- return kvmalloc(size, GFP_KERNEL);
+ return kvmalloc(size, GFP_KERNEL_ACCOUNT);
}
/**
@@ -566,7 +566,7 @@ static void single_stop(struct seq_file *p, void *v)
int single_open(struct file *file, int (*show)(struct seq_file *, void *),
void *data)
{
- struct seq_operations *op = kmalloc(sizeof(*op), GFP_KERNEL);
+ struct seq_operations *op = kmalloc(sizeof(*op), GFP_KERNEL_ACCOUNT);
int res = -ENOMEM;
if (op) {
@@ -628,7 +628,7 @@ void *__seq_open_private(struct file *f, const struct seq_operations *ops,
void *private;
struct seq_file *seq;
- private = kzalloc(psize, GFP_KERNEL);
+ private = kzalloc(psize, GFP_KERNEL_ACCOUNT);
if (private == NULL)
goto out;
@@ -1112,5 +1112,5 @@ EXPORT_SYMBOL(seq_hlist_next_percpu);
void __init seq_file_init(void)
{
- seq_file_cache = KMEM_CACHE(seq_file, SLAB_PANIC);
+ seq_file_cache = KMEM_CACHE(seq_file, SLAB_ACCOUNT|SLAB_PANIC);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] seq_file: account everything
2018-03-10 8:52 [PATCH 2/2] seq_file: account everything Alexey Dobriyan
@ 2018-03-16 12:43 ` Michal Hocko
0 siblings, 0 replies; 2+ messages in thread
From: Michal Hocko @ 2018-03-16 12:43 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: viro, akpm, linux-kernel
On Sat 10-03-18 11:52:52, Alexey Dobriyan wrote:
> All it takes to open a file and read 1 byte from it.
>
> seq_file will be allocated along with any private allocations,
> and more importantly seq file buffer which is 1 page by default.
OOM badness heuristic will not know about this memory when choosing an
oom victim so we might kill a wrong victim which is not all that great
but at least the consumption will be contained within a memcg which
sounds like the sufficient protection for now. This is the case
basically for all kmem charges...
The seq file life time should be bound to a process life time so this is
OK.
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
>
> fs/seq_file.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> --- a/fs/seq_file.c
> +++ b/fs/seq_file.c
> @@ -29,7 +29,7 @@ static void seq_set_overflow(struct seq_file *m)
>
> static void *seq_buf_alloc(unsigned long size)
> {
> - return kvmalloc(size, GFP_KERNEL);
> + return kvmalloc(size, GFP_KERNEL_ACCOUNT);
> }
>
> /**
> @@ -566,7 +566,7 @@ static void single_stop(struct seq_file *p, void *v)
> int single_open(struct file *file, int (*show)(struct seq_file *, void *),
> void *data)
> {
> - struct seq_operations *op = kmalloc(sizeof(*op), GFP_KERNEL);
> + struct seq_operations *op = kmalloc(sizeof(*op), GFP_KERNEL_ACCOUNT);
> int res = -ENOMEM;
>
> if (op) {
> @@ -628,7 +628,7 @@ void *__seq_open_private(struct file *f, const struct seq_operations *ops,
> void *private;
> struct seq_file *seq;
>
> - private = kzalloc(psize, GFP_KERNEL);
> + private = kzalloc(psize, GFP_KERNEL_ACCOUNT);
> if (private == NULL)
> goto out;
>
> @@ -1112,5 +1112,5 @@ EXPORT_SYMBOL(seq_hlist_next_percpu);
>
> void __init seq_file_init(void)
> {
> - seq_file_cache = KMEM_CACHE(seq_file, SLAB_PANIC);
> + seq_file_cache = KMEM_CACHE(seq_file, SLAB_ACCOUNT|SLAB_PANIC);
> }
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-16 12:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-10 8:52 [PATCH 2/2] seq_file: account everything Alexey Dobriyan
2018-03-16 12:43 ` Michal Hocko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.