From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753242AbeCPOq0 (ORCPT ); Fri, 16 Mar 2018 10:46:26 -0400 Received: from isilmar-4.linta.de ([136.243.71.142]:32852 "EHLO isilmar-4.linta.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752777AbeCPOqY (ORCPT ); Fri, 16 Mar 2018 10:46:24 -0400 Date: Fri, 16 Mar 2018 15:45:54 +0100 From: Dominik Brodowski To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, luto@kernel.org, mingo@kernel.org, akpm@linux-foundation.org, arnd@arndb.de, Ingo Molnar , Jiri Slaby , x86@kernel.org Subject: Re: [PATCH v2 13/36] x86/ioport: add ksys_ioperm() helper; remove in-kernel calls to sys_ioperm() Message-ID: <20180316144554.GC14069@light.dominikbrodowski.net> References: <20180315190529.20943-1-linux@dominikbrodowski.net> <20180315190529.20943-14-linux@dominikbrodowski.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 16, 2018 at 01:00:48PM +0100, Thomas Gleixner wrote: > On Thu, 15 Mar 2018, Dominik Brodowski wrote: > > > Using this helper allows us to avoid the in-kernel calls to the sys_ioperm() > > syscall. > > > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > Cc: Jiri Slaby > > Cc: x86@kernel.org > > Acked-by: Greg Kroah-Hartman > > Signed-off-by: Dominik Brodowski > > Please add a few lines explaining the ksys_ prefix as you did in your reply > to Christoph. Other than that: > > Reviewed-by: Thomas Gleixner Thanks! The commit message now reads Using this helper allows us to avoid the in-kernel calls to the sys_ioperm() syscall. The ksys_ prefix denotes that this function is meant as a drop-in replacement for the syscall. In particular, it uses the same calling convention as sys_ioperm(). Does that sound OK? Thanks, Dominik