From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752216AbeCPUry (ORCPT ); Fri, 16 Mar 2018 16:47:54 -0400 Received: from bm.shmanahar.org ([80.68.91.236]:42385 "EHLO bm.shmanahar.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750921AbeCPUru (ORCPT ); Fri, 16 Mar 2018 16:47:50 -0400 Date: Fri, 16 Mar 2018 20:41:41 +0000 From: Nick Dyer To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Benson Leung , Olof Johansson , linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/14] Input: atmel_mxt_ts - remove platform data support Message-ID: <20180316204141.GB24333@bm.shmanahar.org> References: <20180312190907.174301-1-dmitry.torokhov@gmail.com> <20180312190907.174301-15-dmitry.torokhov@gmail.com> <20180314205938.GD26353@lava.h.shmanahar.org> <20180316000614.GB60361@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180316000614.GB60361@dtor-ws> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 15, 2018 at 05:06:14PM -0700, Dmitry Torokhov wrote: > On Wed, Mar 14, 2018 at 08:59:38PM +0000, Nick Dyer wrote: > > On Mon, Mar 12, 2018 at 12:09:07PM -0700, Dmitry Torokhov wrote: > > > - /* > > > - * Ignore ACPI devices representing bootloader mode. > > > - * > > > - * This is a bit of a hack: Google Chromebook BIOS creates ACPI > > > - * devices for both application and bootloader modes, but we are > > > - * interested in application mode only (if device is in bootloader > > > - * mode we'll end up switching into application anyway). So far > > > - * application mode addresses were all above 0x40, so we'll use it > > > - * as a threshold. > > > - */ > > > - if (client->addr < 0x40) > > > - return -ENXIO; > > > > Could you use 0x4a, since that's the lowest application mode address, > > same in the other place. > > OK, this is existing code though, so I'll make a separate patch. Ah, I see now. In which case it's no big deal. Acked-by: Nick Dyer