From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754611AbeCRMxC (ORCPT ); Sun, 18 Mar 2018 08:53:02 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:41343 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754590AbeCRMws (ORCPT ); Sun, 18 Mar 2018 08:52:48 -0400 X-Google-Smtp-Source: AG47ELuqE9hbFiuPjab0K+yWyFzFMpLZHbxcR6cltr2Or3fMgLo6bC8vBbvlo2uwD0YOPzg7iA8J4A== Date: Sun, 18 Mar 2018 07:52:45 -0500 From: Rob Herring To: Archit Taneja Cc: Alexandru M Stan , David Airlie , Mark Rutland , Andrzej Hajda , Laurent Pinchart , Sean Paul , devicetree@vger.kernel.org, Enric Balletbo i Serra , Heiko Stuebner , briannorris@chromium.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, dianders@chromium.org, linux-rockchip@lists.infradead.org, marcheu@chromium.org, hoegsberg@chromium.org, Thierry Escande , Jeffy Chen Subject: Re: [PATCH 1/2] dt-bindings: analogix-dp: Add backlight-pwm-passthru Message-ID: <20180318125245.ndnplplmtsy3hmu7@rob-hp-laptop> References: <20180316025659.217423-1-amstan@chromium.org> <20180316025659.217423-2-amstan@chromium.org> <124034c6-a0af-0142-0d04-7d8bbc19bb82@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <124034c6-a0af-0142-0d04-7d8bbc19bb82@codeaurora.org> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 16, 2018 at 02:56:09PM +0530, Archit Taneja wrote: > > > On Friday 16 March 2018 08:26 AM, Alexandru M Stan wrote: > > Documentation for the optional backlight-pwm-passthru property. > > Tells the EDP panel to folow the input pwm frequency instead > > s/folow/follow > > It would be nice if we could add the details you mentioned in > patch #0 in either this or the next patch. > > > of generating its own. > > This is one of those bindings which is more a knob than a HW property, > but I can't think of any easy way to figure this out in SW. So, I guess > it's okay to have. > > One thing I was wondering about was whether this prop should belong to > the eDP controller or the eDP panel. I don't have any strong opinion > about it, though. Seems to me, it should be the panel. It's a setting in the panel, right? Is this generic to DP panels or something specific to a certain panel? The naming (vendor prefix or not) and doc location should match whatever the answer to that is. > > Reviewed-by: Archit Taneja > > Thanks, > Archit > > > > > > Signed-off-by: Alexandru M Stan > > --- > > > > Documentation/devicetree/bindings/display/bridge/analogix_dp.txt | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt > > index 0c7473dd0e51..3c15242f6ce3 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt > > @@ -23,6 +23,10 @@ Required properties for dp-controller: > > from general PHY binding: Should be "dp". > > Optional properties for dp-controller: > > + -backlight-pwm-passthru: > > + Directly pass the PWM frequency applied to the BL_PWM_DIM > > + pin to the backlight current source. Done via > > + EDP_BACKLIGHT_MODE_SET_REGISTER on DPCD. > > -force-hpd: > > Indicate driver need force hpd when hpd detect failed, this > > is used for some eDP screen which don't have hpd signal. > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 1/2] dt-bindings: analogix-dp: Add backlight-pwm-passthru Date: Sun, 18 Mar 2018 07:52:45 -0500 Message-ID: <20180318125245.ndnplplmtsy3hmu7@rob-hp-laptop> References: <20180316025659.217423-1-amstan@chromium.org> <20180316025659.217423-2-amstan@chromium.org> <124034c6-a0af-0142-0d04-7d8bbc19bb82@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <124034c6-a0af-0142-0d04-7d8bbc19bb82@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Archit Taneja Cc: Mark Rutland , devicetree@vger.kernel.org, Thierry Escande , Alexandru M Stan , linux-rockchip@lists.infradead.org, David Airlie , briannorris@chromium.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, dianders@chromium.org, Jeffy Chen , Laurent Pinchart , Enric Balletbo i Serra , marcheu@chromium.org, hoegsberg@chromium.org List-Id: devicetree@vger.kernel.org T24gRnJpLCBNYXIgMTYsIDIwMTggYXQgMDI6NTY6MDlQTSArMDUzMCwgQXJjaGl0IFRhbmVqYSB3 cm90ZToKPiAKPiAKPiBPbiBGcmlkYXkgMTYgTWFyY2ggMjAxOCAwODoyNiBBTSwgQWxleGFuZHJ1 IE0gU3RhbiB3cm90ZToKPiA+IERvY3VtZW50YXRpb24gZm9yIHRoZSBvcHRpb25hbCBiYWNrbGln aHQtcHdtLXBhc3N0aHJ1IHByb3BlcnR5Lgo+ID4gVGVsbHMgdGhlIEVEUCBwYW5lbCB0byBmb2xv dyB0aGUgaW5wdXQgcHdtIGZyZXF1ZW5jeSBpbnN0ZWFkCj4gCj4gcy9mb2xvdy9mb2xsb3cKPiAK PiBJdCB3b3VsZCBiZSBuaWNlIGlmIHdlIGNvdWxkIGFkZCB0aGUgZGV0YWlscyB5b3UgbWVudGlv bmVkIGluCj4gcGF0Y2ggIzAgaW4gZWl0aGVyIHRoaXMgb3IgdGhlIG5leHQgcGF0Y2guCj4gCj4g PiBvZiBnZW5lcmF0aW5nIGl0cyBvd24uCj4gCj4gVGhpcyBpcyBvbmUgb2YgdGhvc2UgYmluZGlu Z3Mgd2hpY2ggaXMgbW9yZSBhIGtub2IgdGhhbiBhIEhXIHByb3BlcnR5LAo+IGJ1dCBJIGNhbid0 IHRoaW5rIG9mIGFueSBlYXN5IHdheSB0byBmaWd1cmUgdGhpcyBvdXQgaW4gU1cuIFNvLCBJIGd1 ZXNzCj4gaXQncyBva2F5IHRvIGhhdmUuCj4gCj4gT25lIHRoaW5nIEkgd2FzIHdvbmRlcmluZyBh Ym91dCB3YXMgd2hldGhlciB0aGlzIHByb3Agc2hvdWxkIGJlbG9uZyB0bwo+IHRoZSBlRFAgY29u dHJvbGxlciBvciB0aGUgZURQIHBhbmVsLiBJIGRvbid0IGhhdmUgYW55IHN0cm9uZyBvcGluaW9u Cj4gYWJvdXQgaXQsIHRob3VnaC4KClNlZW1zIHRvIG1lLCBpdCBzaG91bGQgYmUgdGhlIHBhbmVs LiBJdCdzIGEgc2V0dGluZyBpbiB0aGUgcGFuZWwsIHJpZ2h0PwoKSXMgdGhpcyBnZW5lcmljIHRv IERQIHBhbmVscyBvciBzb21ldGhpbmcgc3BlY2lmaWMgdG8gYSBjZXJ0YWluIHBhbmVsPyAKVGhl IG5hbWluZyAodmVuZG9yIHByZWZpeCBvciBub3QpIGFuZCBkb2MgbG9jYXRpb24gc2hvdWxkIG1h dGNoIAp3aGF0ZXZlciB0aGUgYW5zd2VyIHRvIHRoYXQgaXMuCgo+IAo+IFJldmlld2VkLWJ5OiBB cmNoaXQgVGFuZWphIDxhcmNoaXR0QGNvZGVhdXJvcmEub3JnPgo+IAo+IFRoYW5rcywKPiBBcmNo aXQKPiAKPiAKPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogQWxleGFuZHJ1IE0gU3RhbiA8YW1zdGFu QGNocm9taXVtLm9yZz4KPiA+IC0tLQo+ID4gCj4gPiAgIERvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS9hbmFsb2dpeF9kcC50eHQgfCA0ICsrKysKPiA+ICAg MSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvRG9j dW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2FuYWxvZ2l4X2Rw LnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS9h bmFsb2dpeF9kcC50eHQKPiA+IGluZGV4IDBjNzQ3M2RkMGU1MS4uM2MxNTI0MmY2Y2UzIDEwMDY0 NAo+ID4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJp ZGdlL2FuYWxvZ2l4X2RwLnR4dAo+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2FuYWxvZ2l4X2RwLnR4dAo+ID4gQEAgLTIzLDYgKzIzLDEw IEBAIFJlcXVpcmVkIHByb3BlcnRpZXMgZm9yIGRwLWNvbnRyb2xsZXI6Cj4gPiAgIAkJZnJvbSBn ZW5lcmFsIFBIWSBiaW5kaW5nOiBTaG91bGQgYmUgImRwIi4KPiA+ICAgT3B0aW9uYWwgcHJvcGVy dGllcyBmb3IgZHAtY29udHJvbGxlcjoKPiA+ICsJLWJhY2tsaWdodC1wd20tcGFzc3RocnU6Cj4g PiArCQlEaXJlY3RseSBwYXNzIHRoZSBQV00gZnJlcXVlbmN5IGFwcGxpZWQgdG8gdGhlIEJMX1BX TV9ESU0KPiA+ICsJCXBpbiB0byB0aGUgYmFja2xpZ2h0IGN1cnJlbnQgc291cmNlLiBEb25lIHZp YQo+ID4gKwkJRURQX0JBQ0tMSUdIVF9NT0RFX1NFVF9SRUdJU1RFUiBvbiBEUENELgo+ID4gICAJ LWZvcmNlLWhwZDoKPiA+ICAgCQlJbmRpY2F0ZSBkcml2ZXIgbmVlZCBmb3JjZSBocGQgd2hlbiBo cGQgZGV0ZWN0IGZhaWxlZCwgdGhpcwo+ID4gICAJCWlzIHVzZWQgZm9yIHNvbWUgZURQIHNjcmVl biB3aGljaCBkb24ndCBoYXZlIGhwZCBzaWduYWwuCj4gPiAKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==