All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Roslyakov <alexey.roslyakov@gmail.com>
To: andrew@lunn.ch, kvalo@codeaurora.org, robh+dt@kernel.org,
	mark.rutland@arm.com, arend.vanspriel@broadcom.com,
	franky.lin@broadcom.com, hante.meuleman@broadcom.com,
	chi-hsien.lin@cypress.com, wright.feng@cypress.com,
	netdev@vger.kernel.org
Cc: linux-wireless@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	brcm80211-dev-list.pdl@broadcom.com,
	brcm80211-dev-list@cypress.com,
	Alexey Roslyakov <alexey.roslyakov@gmail.com>
Subject: [PATCH net-next v2 1/2] brcmfmac: add new dt entries for SG SDIO settings
Date: Mon, 19 Mar 2018 08:40:31 +0700	[thread overview]
Message-ID: <20180319014032.9394-2-alexey.roslyakov@gmail.com> (raw)
In-Reply-To: <20180319014032.9394-1-alexey.roslyakov@gmail.com>

There are 3 fields in SDIO settings (quirks) to workaround some of
the SG SDIO host particularities, i.e higher align requirements for
SG items.
All coding is done the long time ago, but there is no way to change the
driver behavior without patching the kernel.
Add missing devicetree entries.

Signed-off-by: Alexey Roslyakov <alexey.roslyakov@gmail.com>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
index aee6e5937c41..14135752b659 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
@@ -30,14 +30,20 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type,
 	struct device_node *np = dev->of_node;
 	int irq;
 	u32 irqf;
-	u32 val;
 
 	if (!np || bus_type != BRCMF_BUSTYPE_SDIO ||
 	    !of_device_is_compatible(np, "brcm,bcm4329-fmac"))
 		return;
 
-	if (of_property_read_u32(np, "brcm,drive-strength", &val) == 0)
-		sdio->drive_strength = val;
+	of_property_read_u32(np, "brcm,drive-strength", &sdio->drive_strength);
+
+	sdio->broken_sg_support =
+		of_property_read_bool(np, "brcm,broken-sg-support");
+
+	of_property_read_u16(np, "brcm,sd-head-align", &sdio->sd_head_align);
+
+	of_property_read_u16(np, "brcm,sd-sgentry-align",
+			     &sdio->sd_sgentry_align);
 
 	/* make sure there are interrupts defined in the node */
 	if (!of_find_property(np, "interrupts", NULL))
-- 
2.16.1

  reply	other threads:[~2018-03-19  1:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-19  1:40 [PATCH net-next v2 0/2] brcmfmac: add new dt entries for SG SDIO settings Alexey Roslyakov
2018-03-19  1:40 ` Alexey Roslyakov [this message]
2018-03-19 16:23   ` [PATCH net-next v2 1/2] " Kalle Valo
2018-03-19 16:27     ` Alexey Roslyakov
2018-03-19  1:40 ` [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac Alexey Roslyakov
2018-03-19  9:31   ` Arend van Spriel
2018-03-19 14:10     ` Alexey Roslyakov
2018-03-19 17:55       ` Florian Fainelli
2018-03-19 23:16         ` Arend van Spriel
2018-03-20  3:36           ` Alexey Roslyakov
2018-03-20  7:58           ` Alexey Roslyakov
2018-03-20  9:03             ` Arend van Spriel
2018-03-20  9:35               ` Alexey Roslyakov
2018-03-20  9:55           ` Kalle Valo
2018-03-22 10:29             ` Ulf Hansson
2018-04-05 13:10               ` Kalle Valo
2018-04-05 19:09                 ` Ulf Hansson
2018-04-05 19:11                 ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180319014032.9394-2-alexey.roslyakov@gmail.com \
    --to=alexey.roslyakov@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=arend.vanspriel@broadcom.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211-dev-list@cypress.com \
    --cc=chi-hsien.lin@cypress.com \
    --cc=devicetree@vger.kernel.org \
    --cc=franky.lin@broadcom.com \
    --cc=hante.meuleman@broadcom.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=wright.feng@cypress.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.