From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [PATCH 1/2] scsi: dpt_i2o: use after free in adpt_release()
Date: Mon, 19 Mar 2018 10:33:03 +0000 [thread overview]
Message-ID: <20180319103303.GA8543@mwanda> (raw)
The scsi_host_put() function frees "pHba" and then we dereference it on
the next line when we do "scsi_host_put(pHba->host);".
Fixes: 38e09e3bb056 ("scsi: dpt_i2o: stop using scsi_unregister")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index 3c667b23a801..ac2f40d9963b 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -306,8 +306,8 @@ static void adpt_release(adpt_hba *pHba)
{
scsi_remove_host(pHba->host);
// adpt_i2o_quiesce_hba(pHba);
- adpt_i2o_delete_hba(pHba);
scsi_host_put(pHba->host);
+ adpt_i2o_delete_hba(pHba);
}
next reply other threads:[~2018-03-19 10:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 10:33 Dan Carpenter [this message]
2018-03-20 3:08 ` [PATCH 1/2] scsi: dpt_i2o: use after free in adpt_release() Martin K. Petersen
2018-03-20 8:42 ` Christoph Hellwig
2018-03-20 9:58 ` Dan Carpenter
2018-03-21 22:37 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319103303.GA8543@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.