From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AG47ELscHeAjASK2iJLXI0uiuE0rFV3XWlMIPP6ko8KbHKs/Ftfj+OjnjmOumMJi8w7nl4XvpdVN ARC-Seal: i=1; a=rsa-sha256; t=1521483802; cv=none; d=google.com; s=arc-20160816; b=byUPogmQBNmF/vcTnsQapAIgrY2SUbDeVAF1RTdDk/8bARwCmnPATFyjxNP2hEVufx JjzhCxJ276FUjSw5Ef+PDW9oiVYdrotHNqDnx0K18CDLJWj7qLXC29+eFUj8GSqWfNtN Zm7S3h7dwRnizztxqOZJrUeQeQTbTVVkIjwOvX9JIFmQt2zRMJhSfre1rVDzpr13aijV aroFEc9zi/TI5U/QIgM4HnT/Dr93F3eKaRrOSfHzHIke0zDj3ST+yTdQ26ywqSUC1Wbl mQrY0EcoROWatvbhSOym7IHA6KvV26csnJ+xMvC6XP/I9VNawMO+Ww6ikA1OPGV2jAXt SSew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=z0O9phKlOl7QOPQvEH/7KZqXtPV12j1vDqJ9e1hdTKI=; b=BZ+Q126AfJ6D3ywcUn7O7Q9DyArS00AuAGjMCKe+qIz5pyG4JHSMDRvtrnsvh+kyMD EnT+I39i6p+p1poLSVcpFhuSVGiYtc75XuGltaNNczwgK4na30wQcjkoRAjxAw2PTSdm hjQNFWBllk2sgjX4DICuU13zcyBza0tH2FuwYfLWh9CjSUtH9hkwKqbwsrc1xO6lqdHM 3MEe1QbbHh8+ZcQsGS7CHH4lrJ0LKwtX72OBA067XI3K4iyvd/ETVbK7AyZ+hnzQBxuM Z+cFq8HXj+ydwnDWwWkwbxx291LZxizcrZ9hEWu0D893b3ZO99dToNHuxdC3wk9t6GPD aDNA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Michel=20D=C3=A4nzer?= , =?UTF-8?q?Christian=20K=C3=B6nig?= , Christopher James Halse Rogers , amd-gfx@lists.freedesktop.org, Alex Deucher , Sasha Levin Subject: [PATCH 4.9 122/241] drm/amdgpu: Fail fb creation from imported dma-bufs. (v2) Date: Mon, 19 Mar 2018 19:06:27 +0100 Message-Id: <20180319180756.257022623@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180319180751.172155436@linuxfoundation.org> References: <20180319180751.172155436@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1595390837447532927?= X-GMAIL-MSGID: =?utf-8?q?1595391399768905419?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Christopher James Halse Rogers [ Upstream commit 1769152ac64b0b07583f696b621624df2ca4c840 ] Any use of the framebuffer will migrate it to VRAM, which is not sensible for an imported dma-buf. v2: Use DRM_DEBUG_KMS to prevent userspace accidentally spamming dmesg. Reviewed-by: Michel Dänzer Reviewed-by: Christian König Signed-off-by: Christopher James Halse Rogers CC: amd-gfx@lists.freedesktop.org Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c @@ -533,6 +533,12 @@ amdgpu_user_framebuffer_create(struct dr return ERR_PTR(-ENOENT); } + /* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */ + if (obj->import_attach) { + DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n"); + return ERR_PTR(-EINVAL); + } + amdgpu_fb = kzalloc(sizeof(*amdgpu_fb), GFP_KERNEL); if (amdgpu_fb == NULL) { drm_gem_object_unreference_unlocked(obj); From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: [PATCH 4.9 122/241] drm/amdgpu: Fail fb creation from imported dma-bufs. (v2) Date: Mon, 19 Mar 2018 19:06:27 +0100 Message-ID: <20180319180756.257022623@linuxfoundation.org> References: <20180319180751.172155436@linuxfoundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180319180751.172155436-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Greg Kroah-Hartman , =?UTF-8?q?Michel=20D=C3=A4nzer?= , Christopher James Halse Rogers , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Sasha Levin , stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= NC45LXN0YWJsZSByZXZpZXcgcGF0Y2guICBJZiBhbnlvbmUgaGFzIGFueSBvYmplY3Rpb25zLCBw bGVhc2UgbGV0IG1lIGtub3cuCgotLS0tLS0tLS0tLS0tLS0tLS0KCkZyb206IENocmlzdG9waGVy IEphbWVzIEhhbHNlIFJvZ2VycyA8Y2hyaXN0b3BoZXIuaGFsc2Uucm9nZXJzQGNhbm9uaWNhbC5j b20+CgoKWyBVcHN0cmVhbSBjb21taXQgMTc2OTE1MmFjNjRiMGIwNzU4M2Y2OTZiNjIxNjI0ZGYy Y2E0Yzg0MCBdCgpBbnkgdXNlIG9mIHRoZSBmcmFtZWJ1ZmZlciB3aWxsIG1pZ3JhdGUgaXQgdG8g VlJBTSwgd2hpY2ggaXMgbm90IHNlbnNpYmxlIGZvcgphbiBpbXBvcnRlZCBkbWEtYnVmLgoKdjI6 IFVzZSBEUk1fREVCVUdfS01TIHRvIHByZXZlbnQgdXNlcnNwYWNlIGFjY2lkZW50YWxseSBzcGFt bWluZyBkbWVzZy4KClJldmlld2VkLWJ5OiBNaWNoZWwgRMOkbnplciA8bWljaGVsLmRhZW56ZXJA YW1kLmNvbT4KUmV2aWV3ZWQtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdA YW1kLmNvbT4KU2lnbmVkLW9mZi1ieTogQ2hyaXN0b3BoZXIgSmFtZXMgSGFsc2UgUm9nZXJzIDxj aHJpc3RvcGhlci5oYWxzZS5yb2dlcnNAY2Fub25pY2FsLmNvbT4KQ0M6IGFtZC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnClNpZ25lZC1vZmYtYnk6IEFsZXggRGV1Y2hlciA8YWxleGFuZGVyLmRl dWNoZXJAYW1kLmNvbT4KU2lnbmVkLW9mZi1ieTogU2FzaGEgTGV2aW4gPGFsZXhhbmRlci5sZXZp bkBtaWNyb3NvZnQuY29tPgpTaWduZWQtb2ZmLWJ5OiBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdr aEBsaW51eGZvdW5kYXRpb24ub3JnPgotLS0KIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Ft ZGdwdV9kaXNwbGF5LmMgfCAgICA2ICsrKysrKwogMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9u cygrKQoKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Rpc3BsYXkuYwor KysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGlzcGxheS5jCkBAIC01MzMs NiArNTMzLDEyIEBAIGFtZGdwdV91c2VyX2ZyYW1lYnVmZmVyX2NyZWF0ZShzdHJ1Y3QgZHIKIAkJ cmV0dXJuIEVSUl9QVFIoLUVOT0VOVCk7CiAJfQogCisJLyogSGFuZGxlIGlzIGltcG9ydGVkIGRt YS1idWYsIHNvIGNhbm5vdCBiZSBtaWdyYXRlZCB0byBWUkFNIGZvciBzY2Fub3V0ICovCisJaWYg KG9iai0+aW1wb3J0X2F0dGFjaCkgeworCQlEUk1fREVCVUdfS01TKCJDYW5ub3QgY3JlYXRlIGZy YW1lYnVmZmVyIGZyb20gaW1wb3J0ZWQgZG1hX2J1ZlxuIik7CisJCXJldHVybiBFUlJfUFRSKC1F SU5WQUwpOworCX0KKwogCWFtZGdwdV9mYiA9IGt6YWxsb2Moc2l6ZW9mKCphbWRncHVfZmIpLCBH RlBfS0VSTkVMKTsKIAlpZiAoYW1kZ3B1X2ZiID09IE5VTEwpIHsKIAkJZHJtX2dlbV9vYmplY3Rf dW5yZWZlcmVuY2VfdW5sb2NrZWQob2JqKTsKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2FtZC1nZngK