From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:55368 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751269AbeCTO5Y (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 20 Mar 2018 10:57:24 -0400
Date: Tue, 20 Mar 2018 10:57:22 -0400 (EDT)
Message-Id: <20180320.105722.15146213885137044.davem@davemloft.net>
To: lkp@intel.com
Cc: ipylypiv@silver-peak.com, kbuild-all@01.org, skhare@vmware.com,
        pv-drivers@vmware.com, netdev@vger.kernel.org
Subject: Re: [PATCH] vmxnet3: fix LRO feature check
From: David Miller <davem@davemloft.net>
In-Reply-To: <201803181411.VTfldbIf%fengguang.wu@intel.com>
References: <20180317075852.11785-1-ipylypiv@silver-peak.com>
        <201803181411.VTfldbIf%fengguang.wu@intel.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: kbuild test robot <lkp@intel.com>
Date: Sun, 18 Mar 2018 14:37:35 +0800

> All warnings (new ones prefixed by >>):
> 
>    drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_rq_rx_complete':
>>> drivers/net/vmxnet3/vmxnet3_drv.c:1474:8: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' [-Wparentheses]
>            !adapter->netdev->features & NETIF_F_LRO) {
>            ^~~~~~~~~~~~~~~~~~~~~~~~~~

Igor, I will fix this up for you.  But it is clear that this patch wasn't tested
very well.

Because !adapter->netdev->features evaluates wholly before the "& NETIF_F_LRO",
the flags aren't being tested properly at all.