From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:45658 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1750768AbeCTG6q (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 20 Mar 2018 02:58:46 -0400
Date: Tue, 20 Mar 2018 07:58:39 +0100
From: Stefano Brivio <sbrivio@redhat.com>
To: Raju Rangoju <rajur@chelsio.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, nirranjan@chelsio.com,
        indranil@chelsio.com, venkatesh@chelsio.com,
        swise@opengridcomputing.com, bharat@chelsio.com,
        Ganesh Goudar <ganeshgr@chelsio.com>
Subject: Re: [PATCH v2 net-next 2/5] cxgb4: Add support to initialise/read
 SRQ entries
Message-ID: <20180320075839.69dd90d4@epycfail>
In-Reply-To: <20180320061337.19296-3-rajur@chelsio.com>
References: <20180320061337.19296-1-rajur@chelsio.com>
        <20180320061337.19296-3-rajur@chelsio.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, 20 Mar 2018 11:43:34 +0530
Raju Rangoju <rajur@chelsio.com> wrote:

> +struct srq_data *t4_init_srq(int srq_size)
> +{
> +	struct srq_data *s;
> +
> +	s = kzalloc(sizeof(*s), GFP_KERNEL | __GFP_NOWARN);
> +	if (!s)
> +		s = kvzalloc(sizeof(*s), GFP_KERNEL);
> +	if (!s)
> +		return NULL;

I meant: you can replace this whole fragment by kzalloc(), which does
what you want, in the right way. LWN has a nice write-up at:
https://lwn.net/Articles/711653/

-- 
Stefano