From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from stargate.chelsio.com ([12.32.117.8]:34519 "EHLO
        stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752244AbeCTKLV (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 20 Mar 2018 06:11:21 -0400
Date: Tue, 20 Mar 2018 15:41:13 +0530
From: Raju Rangoju <rajur@chelsio.com>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, nirranjan@chelsio.com,
        indranil@chelsio.com, venkatesh@chelsio.com,
        swise@opengridcomputing.com, bharat@chelsio.com,
        Ganesh Goudar <ganeshgr@chelsio.com>
Subject: Re: [PATCH v2 net-next 2/5] cxgb4: Add support to initialise/read
 SRQ entries
Message-ID: <20180320101112.GA19886@chelsio.com>
References: <20180320061337.19296-1-rajur@chelsio.com>
 <20180320061337.19296-3-rajur@chelsio.com>
 <20180320075839.69dd90d4@epycfail>
 <20180320075922.60807bf6@epycfail>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180320075922.60807bf6@epycfail>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tuesday, March 03/20/18, 2018 at 07:59:22 +0100, Stefano Brivio wrote:
> On Tue, 20 Mar 2018 07:58:39 +0100
> Stefano Brivio <sbrivio@redhat.com> wrote:
> 
> > On Tue, 20 Mar 2018 11:43:34 +0530
> > Raju Rangoju <rajur@chelsio.com> wrote:
> > 
> > > +struct srq_data *t4_init_srq(int srq_size)
> > > +{
> > > +	struct srq_data *s;
> > > +
> > > +	s = kzalloc(sizeof(*s), GFP_KERNEL | __GFP_NOWARN);
> > > +	if (!s)
> > > +		s = kvzalloc(sizeof(*s), GFP_KERNEL);
> > > +	if (!s)
> > > +		return NULL;  
> > 
> > I meant: you can replace this whole fragment by kzalloc()
>                                                   ^^^ kvzalloc()
Stefano, thanks for the suggestion.
> 
> -- 
> Stefano