From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [PATCH] qemu: include generated files with <> and not "" Date: Tue, 20 Mar 2018 10:27:19 +0000 Message-ID: <20180320102719.GF4530@redhat.com> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320094406.GD4530@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , "Michael S. Tsirkin" , Jeff Cody , Zhang Chen , Mark Cave-Ayland , QEMU Developers , "Richard W.M. Jones" , Keith Busch , Max Filippov , Gerd Hoffmann , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" List-Id: kvm.vger.kernel.org T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMTA6MDE6MjRBTSArMDAwMCwgUGV0ZXIgTWF5ZGVsbCB3 cm90ZToKPiBPbiAyMCBNYXJjaCAyMDE4IGF0IDA5OjQ0LCBEYW5pZWwgUC4gQmVycmFuZ8OpIDxi ZXJyYW5nZUByZWRoYXQuY29tPiB3cm90ZToKPiA+IFdlIGNhbiBmb2xsb3cgd2hhdCBhdXRvY29u ZiBkb2VzLCBhbmQgYWRkIGEgY2hlY2sgdG8gY29uZmlndXJlIHRvIHNlZSBpZgo+ID4gdGhlcmUg YXJlIGdlbmVyYXRlZCBmaWxlcyBsZWZ0IGluIHRoZSBzb3VyY2UgZGlyLCB3aGVuIGNvbmZpZ3Vy aW5nIHdpdGgKPiA+IGJ1aWxkZGlyICE9IHNyY2RpciwgYW5kIGV4aXQgd2l0aCBlcnJvciwgdGVs bGluZyB1c2VyIHRvIGNsZWFuIHRoZWlyCj4gPiBzcmMgZGlyIGZpcnN0Lgo+IAo+IFdlIGFscmVh ZHkgZG8gdGhpcyBpbiBvdXIgbWFrZWZpbGUuLi5pdCBqdXN0IGRvZXNuJ3QgY2hlY2sgZXZlcnkK PiBzaW5nbGUgZ2VuZXJhdGVkIGZpbGUuCgpBaCB5ZXMsIGluZGVlZDoKCiQgbWFrZQpNYWtlZmls ZTo1OTogKioqIFRoaXMgaXMgYW4gb3V0IG9mIHRyZWUgYnVpbGQgYnV0IHlvdXIgc291cmNlIHRy ZWUKKC9ob21lL2JlcnJhbmdlL3NyYy92aXJ0L3FlbXUpIHNlZW1zIHRvIGhhdmUgYmVlbiB1c2Vk IGZvciBhbiBpbi10cmVlCmJ1aWxkLiBZb3UgY2FuIGZpeCB0aGlzIGJ5IHJ1bm5pbmcgIm1ha2Ug ZGlzdGNsZWFuICYmIHJtIC1yZiAqLWxpbnV4LXVzZXIKICotc29mdG1tdSIgaW4geW91ciBzb3Vy Y2UgdHJlZS4gIFN0b3AuCgoKSXQgaXMgY2hlY2tpbmcgZm9yIGV4aXN0YW5jZSBvZiBjb25maWct aG9zdC5tYWsuCgpXZSBoYXZlIGEgY29udmVuaWVudCBsaXN0IG9mIGdlbmVyYXRlZCBmaWxlcyBp biAkKEdFTkVSQVRFRF9GSUxFUyksIHNvCkkgd29uZGVyIGlmIHRoZXJlJ3MgYSBwcmFjdGljYWwg d2F5IHRvIGNoZWNrIGFsbCBvZiB0aG9zZSB0b28uCgpSZWdhcmRzLApEYW5pZWwKLS0gCnw6IGh0 dHBzOi8vYmVycmFuZ2UuY29tICAgICAgLW8tICAgIGh0dHBzOi8vd3d3LmZsaWNrci5jb20vcGhv dG9zL2RiZXJyYW5nZSA6fAp8OiBodHRwczovL2xpYnZpcnQub3JnICAgICAgICAgLW8tICAgICAg ICAgICAgaHR0cHM6Ly9mc3RvcDEzOC5iZXJyYW5nZS5jb20gOnwKfDogaHR0cHM6Ly9lbnRhbmds ZS1waG90by5vcmcgICAgLW8tICAgIGh0dHBzOi8vd3d3Lmluc3RhZ3JhbS5jb20vZGJlcnJhbmdl IDp8CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4t ZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczov L2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyEUg-0004uH-UY for qemu-devel@nongnu.org; Tue, 20 Mar 2018 06:27:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyEUf-0005ty-Of for qemu-devel@nongnu.org; Tue, 20 Mar 2018 06:27:50 -0400 Date: Tue, 20 Mar 2018 10:27:19 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180320102719.GF4530@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320094406.GD4530@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qemu: include generated files with <> and not "" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Laurent Vivier , "Michael S. Tsirkin" , QEMU Developers , Paolo Bonzini , Peter Crosthwaite , Richard Henderson , Gerd Hoffmann , Eduardo Habkost , Igor Mammedov , Kevin Wolf , Max Reitz , Jeff Cody , Fam Zheng , John Snow , Stefan Weil , Stefan Hajnoczi , Ronnie Sahlberg , Peter Lieven , Eric Blake , Markus Armbruster , Alberto Garcia , Josh Durgin , Hitoshi Mitake , Liu Yuan , "Richard W.M. Jones" , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , "Dr. David Alan Gilbert" , Greg Kurz , Ben Warren , Shannon Zhao , Michael Walle , Keith Busch , Stefano Stabellini , Anthony Perard , Fabien Chouteau , Amit Shah , Marcel Apfelbaum , Mark Cave-Ayland , BALATON Zoltan , Alexander Graf , Cornelia Huck , Christian Borntraeger , David Gibson , Corey Minyard , =?utf-8?B?SGVydsOp?= Poussineau , Peter Chubb , Subbaraya Sundeep , Dmitry Fleytman , Jason Wang , Yongbok Kim , Max Filippov , Jiri Pirko , Yuval Shaia , David Hildenbrand , Hannes Reinecke , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Andrzej Zaborowski , Artyom Tarasenko , Alistair Francis , "Edgar E. Iglesias" , Stefan Berger , Alex Williamson , zhanghailiang , Juan Quintela , Michael Roth , Andreas =?utf-8?Q?F=C3=A4rber?= , Pavel Dovgalyuk , Riku Voipio , Zhang Chen , Li Zhijian , Wen Congyang , Xie Changlong , Marcelo Tosatti , Aurelien Jarno , kvm-devel , Qemu-block , sheepdog@lists.wpkg.org, qemu-arm , "open list:X86" , qemu-ppc@nongnu.org, qemu-s390x , Thomas Huth On Tue, Mar 20, 2018 at 10:01:24AM +0000, Peter Maydell wrote: > On 20 March 2018 at 09:44, Daniel P. Berrang=C3=A9 wrote: > > We can follow what autoconf does, and add a check to configure to see= if > > there are generated files left in the source dir, when configuring wi= th > > builddir !=3D srcdir, and exit with error, telling user to clean thei= r > > src dir first. >=20 > We already do this in our makefile...it just doesn't check every > single generated file. Ah yes, indeed: $ make Makefile:59: *** This is an out of tree build but your source tree (/home/berrange/src/virt/qemu) seems to have been used for an in-tree build. You can fix this by running "make distclean && rm -rf *-linux-user *-softmmu" in your source tree. Stop. It is checking for existance of config-host.mak. We have a convenient list of generated files in $(GENERATED_FILES), so I wonder if there's a practical way to check all of those too. Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :| From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [PATCH] qemu: include generated files with <> and not "" Date: Tue, 20 Mar 2018 10:27:19 +0000 Message-ID: <20180320102719.GF4530@redhat.com> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320094406.GD4530@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1eyEUU-00013Y-Tc for xen-devel@lists.xenproject.org; Tue, 20 Mar 2018 10:27:38 +0000 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Peter Maydell Cc: Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , "Michael S. Tsirkin" , Jeff Cody , Zhang Chen , Mark Cave-Ayland , QEMU Developers , "Richard W.M. Jones" , Keith Busch , Max Filippov , Gerd Hoffmann , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMTA6MDE6MjRBTSArMDAwMCwgUGV0ZXIgTWF5ZGVsbCB3 cm90ZToKPiBPbiAyMCBNYXJjaCAyMDE4IGF0IDA5OjQ0LCBEYW5pZWwgUC4gQmVycmFuZ8OpIDxi ZXJyYW5nZUByZWRoYXQuY29tPiB3cm90ZToKPiA+IFdlIGNhbiBmb2xsb3cgd2hhdCBhdXRvY29u ZiBkb2VzLCBhbmQgYWRkIGEgY2hlY2sgdG8gY29uZmlndXJlIHRvIHNlZSBpZgo+ID4gdGhlcmUg YXJlIGdlbmVyYXRlZCBmaWxlcyBsZWZ0IGluIHRoZSBzb3VyY2UgZGlyLCB3aGVuIGNvbmZpZ3Vy aW5nIHdpdGgKPiA+IGJ1aWxkZGlyICE9IHNyY2RpciwgYW5kIGV4aXQgd2l0aCBlcnJvciwgdGVs bGluZyB1c2VyIHRvIGNsZWFuIHRoZWlyCj4gPiBzcmMgZGlyIGZpcnN0Lgo+IAo+IFdlIGFscmVh ZHkgZG8gdGhpcyBpbiBvdXIgbWFrZWZpbGUuLi5pdCBqdXN0IGRvZXNuJ3QgY2hlY2sgZXZlcnkK PiBzaW5nbGUgZ2VuZXJhdGVkIGZpbGUuCgpBaCB5ZXMsIGluZGVlZDoKCiQgbWFrZQpNYWtlZmls ZTo1OTogKioqIFRoaXMgaXMgYW4gb3V0IG9mIHRyZWUgYnVpbGQgYnV0IHlvdXIgc291cmNlIHRy ZWUKKC9ob21lL2JlcnJhbmdlL3NyYy92aXJ0L3FlbXUpIHNlZW1zIHRvIGhhdmUgYmVlbiB1c2Vk IGZvciBhbiBpbi10cmVlCmJ1aWxkLiBZb3UgY2FuIGZpeCB0aGlzIGJ5IHJ1bm5pbmcgIm1ha2Ug ZGlzdGNsZWFuICYmIHJtIC1yZiAqLWxpbnV4LXVzZXIKICotc29mdG1tdSIgaW4geW91ciBzb3Vy Y2UgdHJlZS4gIFN0b3AuCgoKSXQgaXMgY2hlY2tpbmcgZm9yIGV4aXN0YW5jZSBvZiBjb25maWct aG9zdC5tYWsuCgpXZSBoYXZlIGEgY29udmVuaWVudCBsaXN0IG9mIGdlbmVyYXRlZCBmaWxlcyBp biAkKEdFTkVSQVRFRF9GSUxFUyksIHNvCkkgd29uZGVyIGlmIHRoZXJlJ3MgYSBwcmFjdGljYWwg d2F5IHRvIGNoZWNrIGFsbCBvZiB0aG9zZSB0b28uCgpSZWdhcmRzLApEYW5pZWwKLS0gCnw6IGh0 dHBzOi8vYmVycmFuZ2UuY29tICAgICAgLW8tICAgIGh0dHBzOi8vd3d3LmZsaWNrci5jb20vcGhv dG9zL2RiZXJyYW5nZSA6fAp8OiBodHRwczovL2xpYnZpcnQub3JnICAgICAgICAgLW8tICAgICAg ICAgICAgaHR0cHM6Ly9mc3RvcDEzOC5iZXJyYW5nZS5jb20gOnwKfDogaHR0cHM6Ly9lbnRhbmds ZS1waG90by5vcmcgICAgLW8tICAgIGh0dHBzOi8vd3d3Lmluc3RhZ3JhbS5jb20vZGJlcnJhbmdl IDp8CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4t ZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczov L2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs