All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: linux-mm@kvack.org, rientjes@google.com
Subject: Re: [PATCH 2/2] mm,oom_reaper: Correct MAX_OOM_REAP_RETRIES'th attempt.
Date: Tue, 20 Mar 2018 14:24:04 +0100	[thread overview]
Message-ID: <20180320132404.GN23100@dhcp22.suse.cz> (raw)
In-Reply-To: <201803202137.CAC35494.OFtJLHFSFOMVOQ@I-love.SAKURA.ne.jp>

On Tue 20-03-18 21:37:42, Tetsuo Handa wrote:
> Michal Hocko wrote:
> > On Tue 20-03-18 20:57:56, Tetsuo Handa wrote:
> > > I got "oom_reaper: unable to reap pid:" messages when the victim thread
> > > was blocked inside free_pgtables() (which occurred after returning from
> > > unmap_vmas() and setting MMF_OOM_SKIP). We don't need to complain when
> > > __oom_reap_task_mm() returned true (by e.g. finding MMF_OOM_SKIP already
> > > set) when oom_reap_task() was trying MAX_OOM_REAP_RETRIES'th attempt.
> > > 
> > > [  663.593821] Killed process 7558 (a.out) total-vm:4176kB, anon-rss:84kB, file-rss:0kB, shmem-rss:0kB
> > > [  664.684801] oom_reaper: unable to reap pid:7558 (a.out)
> > 
> > I do not see "oom_reaper: reaped process..." so has the task been
> > reaped?
> 
> The log is http://I-love.SAKURA.ne.jp/tmp/serial-20180320.txt.xz .

xzgrep oom_reaper: serial-20180320.txt.xz
[   97.144805] oom_reaper: reaped process 2142 (cleanupd), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB
[  103.447171] oom_reaper: reaped process 659 (NetworkManager), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB
[  208.906879] oom_reaper: reaped process 1415 (postgres), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB
[  214.179760] oom_reaper: reaped process 588 (irqbalance), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB
[  215.013260] oom_reaper: reaped process 591 (systemd-logind), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB
[  221.483724] oom_reaper: reaped process 7388 (a.out), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB
[  223.140437] oom_reaper: reaped process 9252 (a.out), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB
[  224.735597] oom_reaper: reaped process 9257 (a.out), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB
[  226.608508] oom_reaper: unable to reap pid:9261 (a.out)
[  354.342331] oom_reaper: unable to reap pid:16611 (a.out)
[  380.525910] oom_reaper: unable to reap pid:6927 (a.out)
[  408.397539] oom_reaper: unable to reap pid:6927 (a.out)
[  435.702005] oom_reaper: unable to reap pid:7554 (a.out)
[  466.269660] oom_reaper: unable to reap pid:7560 (a.out)
[  495.621196] oom_reaper: unable to reap pid:7563 (a.out)
[  534.279602] oom_reaper: reaped process 22038 (a.out), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB
[  536.271631] oom_reaper: unable to reap pid:6928 (a.out)
[  600.285293] oom_reaper: unable to reap pid:7550 (a.out)
[  664.684801] oom_reaper: unable to reap pid:7558 (a.out)
[  743.188067] oom_reaper: reaped process 7562 (a.out), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB
[  744.980868] oom_reaper: unable to reap pid:6928 (a.out)

None of the reaped taks is reported as "unable to reap..." So what
actually gets fixed by this patch?
-- 
Michal Hocko
SUSE Labs

  parent reply	other threads:[~2018-03-20 13:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-20 11:57 [PATCH 1/2] mm,oom_reaper: Show trace of unable to reap victim thread Tetsuo Handa
2018-03-20 11:57 ` [PATCH 2/2] mm,oom_reaper: Correct MAX_OOM_REAP_RETRIES'th attempt Tetsuo Handa
2018-03-20 12:12   ` Michal Hocko
2018-03-20 12:37     ` Tetsuo Handa
2018-03-20 12:47       ` [PATCH 2/2] mm,oom_reaper: Check for MMF_OOM_SKIP before complain Tetsuo Handa
2018-03-20 20:49         ` David Rientjes
2018-03-22 10:46           ` [PATCH] " Tetsuo Handa
2018-03-22 11:59             ` Michal Hocko
2018-03-20 13:24       ` Michal Hocko [this message]
2018-03-20 13:37         ` [PATCH 2/2] mm,oom_reaper: Correct MAX_OOM_REAP_RETRIES'th attempt Tetsuo Handa
2018-03-20 13:44           ` Michal Hocko
2018-03-20 12:28 ` [PATCH 1/2] mm,oom_reaper: Show trace of unable to reap victim thread Michal Hocko
2018-03-20 12:52   ` Tetsuo Handa
2018-03-20 13:19     ` Michal Hocko
2018-03-20 13:30       ` Tetsuo Handa
2018-03-20 13:34         ` Michal Hocko
2018-03-20 13:50           ` Tetsuo Handa
2018-03-20 14:10             ` Michal Hocko
2018-03-20 14:20               ` Tetsuo Handa
2018-03-20 20:46                 ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180320132404.GN23100@dhcp22.suse.cz \
    --to=mhocko@suse.com \
    --cc=linux-mm@kvack.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.