From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [PATCH] qemu: include generated files with <> and not "" Date: Tue, 20 Mar 2018 13:41:17 +0000 Message-ID: <20180320134117.GS4530@redhat.com> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320094406.GD4530@redhat.com> <20180320141107-mutt-send-email-mst@kernel.org> <20180320121841.GN4530@redhat.com> <20180320142756-mutt-send-email-mst@kernel.org> <20180320123900.GO4530@redhat.com> <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , "Michael S. Tsirkin" , Jeff Cody , Zhang Chen , Mark Cave-Ayland , qemu-devel@nongnu.org, "Richard W.M. Jones" , Keith Busch , Max Filippov , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang , To: Gerd Hoffmann Return-path: Content-Disposition: inline In-Reply-To: <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" List-Id: kvm.vger.kernel.org T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMDI6MzI6MTZQTSArMDEwMCwgR2VyZCBIb2ZmbWFubiB3 cm90ZToKPiAgIEhpLAo+IAo+ID4gPiBTbyBmb3IgdGhlc2UsIHdlIHNob3VsZCB1c2UgIiIuICBO b25lIG9mIHRoZXNlIGFyZSBnZW5lcmF0ZWQgZmlsZXMgdGhvdWdoLgo+ID4gCj4gPiBUaGF0IGxl YWRzIHRvIGNyYXp5IGluY29uc2lzdGVudCBtZXNzYWdlIGZvciBkZXZlbG9wZXJzIHdoZXJlIDUw JSBvZiBRRU1VCj4gPiBoZWFkZXIgZmlsZXMgbXVzdCB1c2UgPD4gYW5kIHRoZSBvdGhlciA1MCUg b2YgaGVhZGVyIGZpbGVzIG11c3QgdXNlICIiLgo+IAo+IFRoZSBydWxlcyBhcmUgcHJldHR5IHNp bXBsZSB0aG91Z2g6Cj4gCj4gICAgKDEpIEhlYWRlcnMgd2hpY2ggYXJlIGdlbmVyYXRlZCB1c2Ug PD4uCj4gICAgKDIpIEhlYWRlcnMgd2hpY2ggYXJlIGluIGluY2x1ZGUvIHVzZSA8Pi4KPiAgICAo MykgSGVhZGVycyBzaXR0aW5nIGluIHRoZSBzYW1lIGRpcmVjdG9yeSBhcyB0aGUgc291cmNlIGZp bGVzIHVzZSAiIi4KCldlIGhhdmUgMTIwMCBoZWFkZXIgZmlsZXMgaW4gUUVNVSAtIGEgZGV2ZWxv cGVyIG1pZ2h0IGp1c3QgcmVhc29uYWJseSByZW1lbWJlcgp3aGljaCBoZWFkZXIgZmlsZSBpcyBh IFFFTVUgaGVhZGVyLCB2cyB3aGljaCBpcyBhIDNyZCBwYXJ0eSBzeXN0ZW0gaGVhZGVyLgpFeHBl Y3RpbmcgZGV2cyB0byByZW1lbWJlciB3aGljaCBvZiB0aG9zZSAzIGJ1Y2tldHMgZWFjaCBRRU1V IGhlYWRlciBmYWxscwp1bmRlciBpcyB1bnJlYXNvbmFibGUgSU1ITy4gCgpSZWdhcmRzLApEYW5p ZWwKLS0gCnw6IGh0dHBzOi8vYmVycmFuZ2UuY29tICAgICAgLW8tICAgIGh0dHBzOi8vd3d3LmZs aWNrci5jb20vcGhvdG9zL2RiZXJyYW5nZSA6fAp8OiBodHRwczovL2xpYnZpcnQub3JnICAgICAg ICAgLW8tICAgICAgICAgICAgaHR0cHM6Ly9mc3RvcDEzOC5iZXJyYW5nZS5jb20gOnwKfDogaHR0 cHM6Ly9lbnRhbmdsZS1waG90by5vcmcgICAgLW8tICAgIGh0dHBzOi8vd3d3Lmluc3RhZ3JhbS5j b20vZGJlcnJhbmdlIDp8CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0 Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRl dmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyHX0-0003uj-9E for qemu-devel@nongnu.org; Tue, 20 Mar 2018 09:42:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyHWw-0004kH-BK for qemu-devel@nongnu.org; Tue, 20 Mar 2018 09:42:26 -0400 Date: Tue, 20 Mar 2018 13:41:17 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180320134117.GS4530@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320094406.GD4530@redhat.com> <20180320141107-mutt-send-email-mst@kernel.org> <20180320121841.GN4530@redhat.com> <20180320142756-mutt-send-email-mst@kernel.org> <20180320123900.GO4530@redhat.com> <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> Subject: Re: [Qemu-devel] [PATCH] qemu: include generated files with <> and not "" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: "Michael S. Tsirkin" , Laurent Vivier , qemu-devel@nongnu.org, Paolo Bonzini , Peter Crosthwaite , Richard Henderson , Eduardo Habkost , Igor Mammedov , Kevin Wolf , Max Reitz , Jeff Cody , Fam Zheng , John Snow , Stefan Weil , Stefan Hajnoczi , Ronnie Sahlberg , Peter Lieven , Eric Blake , Markus Armbruster , Alberto Garcia , Josh Durgin , Hitoshi Mitake , Liu Yuan , "Richard W.M. Jones" , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , "Dr. David Alan Gilbert" , Greg Kurz , Ben Warren , Peter Maydell , Shannon Zhao , Michael Walle , Keith Busch , Stefano Stabellini , Anthony Perard , Fabien Chouteau , Amit Shah , Marcel Apfelbaum , Mark Cave-Ayland , BALATON Zoltan , Alexander Graf , Cornelia Huck , Christian Borntraeger , David Gibson , Corey Minyard , =?utf-8?B?SGVydsOp?= Poussineau , Peter Chubb , Subbaraya Sundeep , Dmitry Fleytman , Jason Wang , Yongbok Kim , Max Filippov , Jiri Pirko , Yuval Shaia , David Hildenbrand , Hannes Reinecke , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Andrzej Zaborowski , Artyom Tarasenko , Alistair Francis , "Edgar E. Iglesias" , Stefan Berger , Alex Williamson , zhanghailiang , Juan Quintela , Michael Roth , Andreas =?utf-8?Q?F=C3=A4rber?= , Pavel Dovgalyuk , Riku Voipio , Zhang Chen , Li Zhijian , Wen Congyang , Xie Changlong , Marcelo Tosatti , Aurelien Jarno , kvm@vger.kernel.org, qemu-block@nongnu.org, sheepdog@lists.wpkg.org, qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-ppc@nongnu.org, qemu-s390x@nongnu.org, Thomas Huth On Tue, Mar 20, 2018 at 02:32:16PM +0100, Gerd Hoffmann wrote: > Hi, > > > > So for these, we should use "". None of these are generated files though. > > > > That leads to crazy inconsistent message for developers where 50% of QEMU > > header files must use <> and the other 50% of header files must use "". > > The rules are pretty simple though: > > (1) Headers which are generated use <>. > (2) Headers which are in include/ use <>. > (3) Headers sitting in the same directory as the source files use "". We have 1200 header files in QEMU - a developer might just reasonably remember which header file is a QEMU header, vs which is a 3rd party system header. Expecting devs to remember which of those 3 buckets each QEMU header falls under is unreasonable IMHO. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [PATCH] qemu: include generated files with <> and not "" Date: Tue, 20 Mar 2018 13:41:17 +0000 Message-ID: <20180320134117.GS4530@redhat.com> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320094406.GD4530@redhat.com> <20180320141107-mutt-send-email-mst@kernel.org> <20180320121841.GN4530@redhat.com> <20180320142756-mutt-send-email-mst@kernel.org> <20180320123900.GO4530@redhat.com> <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1eyHWf-0001fZ-Aw for xen-devel@lists.xenproject.org; Tue, 20 Mar 2018 13:42:05 +0000 Content-Disposition: inline In-Reply-To: <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Gerd Hoffmann Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , "Michael S. Tsirkin" , Jeff Cody , Zhang Chen , Mark Cave-Ayland , qemu-devel@nongnu.org, "Richard W.M. Jones" , Keith Busch , Max Filippov , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMDI6MzI6MTZQTSArMDEwMCwgR2VyZCBIb2ZmbWFubiB3 cm90ZToKPiAgIEhpLAo+IAo+ID4gPiBTbyBmb3IgdGhlc2UsIHdlIHNob3VsZCB1c2UgIiIuICBO b25lIG9mIHRoZXNlIGFyZSBnZW5lcmF0ZWQgZmlsZXMgdGhvdWdoLgo+ID4gCj4gPiBUaGF0IGxl YWRzIHRvIGNyYXp5IGluY29uc2lzdGVudCBtZXNzYWdlIGZvciBkZXZlbG9wZXJzIHdoZXJlIDUw JSBvZiBRRU1VCj4gPiBoZWFkZXIgZmlsZXMgbXVzdCB1c2UgPD4gYW5kIHRoZSBvdGhlciA1MCUg b2YgaGVhZGVyIGZpbGVzIG11c3QgdXNlICIiLgo+IAo+IFRoZSBydWxlcyBhcmUgcHJldHR5IHNp bXBsZSB0aG91Z2g6Cj4gCj4gICAgKDEpIEhlYWRlcnMgd2hpY2ggYXJlIGdlbmVyYXRlZCB1c2Ug PD4uCj4gICAgKDIpIEhlYWRlcnMgd2hpY2ggYXJlIGluIGluY2x1ZGUvIHVzZSA8Pi4KPiAgICAo MykgSGVhZGVycyBzaXR0aW5nIGluIHRoZSBzYW1lIGRpcmVjdG9yeSBhcyB0aGUgc291cmNlIGZp bGVzIHVzZSAiIi4KCldlIGhhdmUgMTIwMCBoZWFkZXIgZmlsZXMgaW4gUUVNVSAtIGEgZGV2ZWxv cGVyIG1pZ2h0IGp1c3QgcmVhc29uYWJseSByZW1lbWJlcgp3aGljaCBoZWFkZXIgZmlsZSBpcyBh IFFFTVUgaGVhZGVyLCB2cyB3aGljaCBpcyBhIDNyZCBwYXJ0eSBzeXN0ZW0gaGVhZGVyLgpFeHBl Y3RpbmcgZGV2cyB0byByZW1lbWJlciB3aGljaCBvZiB0aG9zZSAzIGJ1Y2tldHMgZWFjaCBRRU1V IGhlYWRlciBmYWxscwp1bmRlciBpcyB1bnJlYXNvbmFibGUgSU1ITy4gCgpSZWdhcmRzLApEYW5p ZWwKLS0gCnw6IGh0dHBzOi8vYmVycmFuZ2UuY29tICAgICAgLW8tICAgIGh0dHBzOi8vd3d3LmZs aWNrci5jb20vcGhvdG9zL2RiZXJyYW5nZSA6fAp8OiBodHRwczovL2xpYnZpcnQub3JnICAgICAg ICAgLW8tICAgICAgICAgICAgaHR0cHM6Ly9mc3RvcDEzOC5iZXJyYW5nZS5jb20gOnwKfDogaHR0 cHM6Ly9lbnRhbmdsZS1waG90by5vcmcgICAgLW8tICAgIGh0dHBzOi8vd3d3Lmluc3RhZ3JhbS5j b20vZGJlcnJhbmdlIDp8CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0 Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRl dmVs