From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] qemu: include generated files with <> and not "" Date: Tue, 20 Mar 2018 15:53:51 +0200 Message-ID: <20180320155042-mutt-send-email-mst@kernel.org> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320094406.GD4530@redhat.com> <20180320141107-mutt-send-email-mst@kernel.org> <20180320121841.GN4530@redhat.com> <20180320142756-mutt-send-email-mst@kernel.org> <20180320123900.GO4530@redhat.com> <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> <6061af99-0c27-e02b-e185-fe1dfca1a96a@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , David Hildenbrand , Jeff Cody , Zhang Chen , Mark Cave-Ayland , qemu-devel@nongnu.org, "Richard W.M. Jones" , Keith Busch , Max Filippov , Gerd Hoffmann , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang To: Thomas Huth Return-path: Content-Disposition: inline In-Reply-To: <6061af99-0c27-e02b-e185-fe1dfca1a96a@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" List-Id: kvm.vger.kernel.org T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMDI6NDY6NDZQTSArMDEwMCwgVGhvbWFzIEh1dGggd3Jv dGU6Cj4gT24gMjAuMDMuMjAxOCAxNDozMiwgR2VyZCBIb2ZmbWFubiB3cm90ZToKPiA+ICAgSGks Cj4gPiAKPiA+Pj4gU28gZm9yIHRoZXNlLCB3ZSBzaG91bGQgdXNlICIiLiAgTm9uZSBvZiB0aGVz ZSBhcmUgZ2VuZXJhdGVkIGZpbGVzIHRob3VnaC4KPiA+Pgo+ID4+IFRoYXQgbGVhZHMgdG8gY3Jh enkgaW5jb25zaXN0ZW50IG1lc3NhZ2UgZm9yIGRldmVsb3BlcnMgd2hlcmUgNTAlIG9mIFFFTVUK PiA+PiBoZWFkZXIgZmlsZXMgbXVzdCB1c2UgPD4gYW5kIHRoZSBvdGhlciA1MCUgb2YgaGVhZGVy IGZpbGVzIG11c3QgdXNlICIiLgo+ID4gCj4gPiBUaGUgcnVsZXMgYXJlIHByZXR0eSBzaW1wbGUg dGhvdWdoOgo+ID4gCj4gPiAgICAoMSkgSGVhZGVycyB3aGljaCBhcmUgZ2VuZXJhdGVkIHVzZSA8 Pi4KPiA+ICAgICgyKSBIZWFkZXJzIHdoaWNoIGFyZSBpbiBpbmNsdWRlLyB1c2UgPD4uCj4gPiAg ICAoMykgSGVhZGVycyBzaXR0aW5nIGluIHRoZSBzYW1lIGRpcmVjdG9yeSBhcyB0aGUgc291cmNl IGZpbGVzIHVzZSAiIi4KPiAKPiBVZ2gsIG5vLiBQbGVhc2UgZG9uJ3QuIFRoZSBub3JtYWwgd2F5 IG9mIGluY2x1ZGluZyBoZWFkZXIgZmlsZXMgaW4gUUVNVQoKU3RyZXNzIG9uICJpbiBRRU1VIi4K Cj4gaXMgdG8gdXNlICIiIC0gYWxzbyBmb3IgaGVhZGVycyB0aGF0IGFyZSBub3QgaW4gdGhlIHNh bWUgZGlyZWN0b3J5LiBGb3IKPiBleGFtcGxlIGp1c3QgZG8gYQo+IAo+ICBncmVwIC1yICdeI2lu Y2x1ZGUuKmh3LycgaHcvCj4gCj4gZnJvbSB0aGUgdG9wIGRpcmVjdG9yeSBhbmQgeW91J2xsIHNl ZSB3aGF0IEkgbWVhbi4gQ2hhbmdpbmcgdGhhdCBydWxlIGlzCj4gY3JhenkuCj4gU28gcGxlYXNl LCBsZXQncyBqdXN0IGZpeCB0aGUgY29uZmlndXJlIHNjcmlwdCB0byBkZXRlY3Qgc29tZQo+IG1v cmUgc3RhbGUgZmlsZXMgaW4gdGhlIHNvdXJjZSB0cmVlLCBhbmQgd2UncmUgZG9uZS4KPiAKPiAg VGhvbWFzCgpUaGUgcnVsZSBwcm9iYWJseSBzZXJ2ZWQgYSB1c2VmdWwgcHVycG9zZSB3aGVuIGFs bApoZWFkZXJzIHdoZXJlIGluIHRoZSBzYW1lIGRpcmVjdG9yeSBhcyB0aGUgc291cmNlLgp3ZSBt b3ZlZCB0aGVtIG91dCBzbyB0aGF0IGlzIG5vIGxvbmdlciB0aGUgY2FzZS4KCi0tIApNU1QKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBt YWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMu eGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyHio-0004cG-Hi for qemu-devel@nongnu.org; Tue, 20 Mar 2018 09:54:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyHin-000495-Iu for qemu-devel@nongnu.org; Tue, 20 Mar 2018 09:54:38 -0400 Date: Tue, 20 Mar 2018 15:53:51 +0200 From: "Michael S. Tsirkin" Message-ID: <20180320155042-mutt-send-email-mst@kernel.org> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320094406.GD4530@redhat.com> <20180320141107-mutt-send-email-mst@kernel.org> <20180320121841.GN4530@redhat.com> <20180320142756-mutt-send-email-mst@kernel.org> <20180320123900.GO4530@redhat.com> <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> <6061af99-0c27-e02b-e185-fe1dfca1a96a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6061af99-0c27-e02b-e185-fe1dfca1a96a@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qemu: include generated files with <> and not "" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Gerd Hoffmann , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Laurent Vivier , qemu-devel@nongnu.org, Paolo Bonzini , Peter Crosthwaite , Richard Henderson , Eduardo Habkost , Igor Mammedov , Kevin Wolf , Max Reitz , Jeff Cody , Fam Zheng , John Snow , Stefan Weil , Stefan Hajnoczi , Ronnie Sahlberg , Peter Lieven , Eric Blake , Markus Armbruster , Alberto Garcia , Josh Durgin , Hitoshi Mitake , Liu Yuan , "Richard W.M. Jones" , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , "Dr. David Alan Gilbert" , Greg Kurz , Ben Warren , Peter Maydell , Shannon Zhao , Michael Walle , Keith Busch , Stefano Stabellini , Anthony Perard , Fabien Chouteau , Amit Shah , Marcel Apfelbaum , Mark Cave-Ayland , BALATON Zoltan , Alexander Graf , Cornelia Huck , Christian Borntraeger , David Gibson , Corey Minyard , =?iso-8859-1?Q?Herv=E9?= Poussineau , Peter Chubb , Subbaraya Sundeep , Dmitry Fleytman , Jason Wang , Yongbok Kim , Max Filippov , Jiri Pirko , Yuval Shaia , David Hildenbrand , Hannes Reinecke , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Andrzej Zaborowski , Artyom Tarasenko , Alistair Francis , "Edgar E. Iglesias" , Stefan Berger , Alex Williamson , zhanghailiang , Juan Quintela , Michael Roth , Andreas =?iso-8859-1?Q?F=E4rber?= , Pavel Dovgalyuk , Riku Voipio , Zhang Chen , Li Zhijian , Wen Congyang , Xie Changlong , Marcelo Tosatti , Aurelien Jarno , kvm@vger.kernel.org, qemu-block@nongnu.org, sheepdog@lists.wpkg.org, qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-ppc@nongnu.org, qemu-s390x@nongnu.org On Tue, Mar 20, 2018 at 02:46:46PM +0100, Thomas Huth wrote: > On 20.03.2018 14:32, Gerd Hoffmann wrote: > > Hi, > > > >>> So for these, we should use "". None of these are generated files though. > >> > >> That leads to crazy inconsistent message for developers where 50% of QEMU > >> header files must use <> and the other 50% of header files must use "". > > > > The rules are pretty simple though: > > > > (1) Headers which are generated use <>. > > (2) Headers which are in include/ use <>. > > (3) Headers sitting in the same directory as the source files use "". > > Ugh, no. Please don't. The normal way of including header files in QEMU Stress on "in QEMU". > is to use "" - also for headers that are not in the same directory. For > example just do a > > grep -r '^#include.*hw/' hw/ > > from the top directory and you'll see what I mean. Changing that rule is > crazy. > So please, let's just fix the configure script to detect some > more stale files in the source tree, and we're done. > > Thomas The rule probably served a useful purpose when all headers where in the same directory as the source. we moved them out so that is no longer the case. -- MST