From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [PATCH] qemu: include generated files with <> and not "" Date: Tue, 20 Mar 2018 16:40:48 +0000 Message-ID: <20180320164048.GB4530@redhat.com> References: <1521510562-529051-1-git-send-email-mst@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , "Michael S. Tsirkin" , Jeff Cody , Zhang Chen , Mark Cave-Ayland , qemu-devel@nongnu.org, BALATON Zoltan , Keith Busch , Max Filippov , Laurent Vivier , Gerd Hoffmann , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Yongbok Kim , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garci To: Eric Blake Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" List-Id: kvm.vger.kernel.org T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMTE6MTI6MDBBTSAtMDUwMCwgRXJpYyBCbGFrZSB3cm90 ZToKPiBPbiAwMy8xOS8yMDE4IDA4OjU0IFBNLCBNaWNoYWVsIFMuIFRzaXJraW4gd3JvdGU6Cj4g PiBRRU1VIGNvZGluZyBzdHlsZSBhdCB0aGUgbW9tZW50IGFza3MgZm9yIGFsbCBub24tc3lzdGVt Cj4gPiBpbmNsdWRlIGZpbGVzIHRvIGJlIHVzZWQgd2l0aCAjaW5jbHVkZSAiZm9vLmgiLgo+IAo+ IFtJJ20gcmVwbHlpbmcgd2l0aG91dCBoYXZpbmcgcmVhZCB0aGUgcmVzdCBvZiB0aGUgdGhyZWFk LCBzbyBiZWFyIHdpdGggbWUgaWYKPiBJIHJlcGVhdCBzb21lIG9mIHRoZSBvdGhlciBjb21tZW50 cyB0aGF0IGhhdmUgYWxyZWFkeSBiZWVuIG1hZGVdCj4gCj4gQW5kIE1hcmt1cyBldmVuIGp1c3Qg ZGlkIGEgY2xlYW51cCBhbG9uZyB0aG9zZSBsaW5lcy4KPiAKPiA+IEhvd2V2ZXIgdGhpcyBydWxl IGFjdHVhbGx5IGRvZXMgbm90IG1ha2Ugc2Vuc2UgYW5kCj4gPiBjcmVhdGVzIGlzc3VlcyBmb3Ig d2hlbiB0aGUgaW5jbHVkZWQgZmlsZSBpcyBnZW5lcmF0ZWQuCj4gPiAKPiA+IEluIEMsIGluY2x1 ZGUgImZpbGUiIG1lYW5zIGxvb2sgaW4gY3VycmVudCBkaXJlY3RvcnksCj4gPiB0aGVuIG9uIGlu Y2x1ZGUgc2VhcmNoIHBhdGguIEN1cnJlbnQgZGlyZWN0b3J5IGhlcmUKPiA+IG1lYW5zIHRoZSBz b3VyY2UgZmlsZSBkaXJlY3RvcnkuCj4gPiBCeSBjb21wYXJpc29uIGluY2x1ZGUgPGZpbGU+IG1l YW5zIGxvb2sgb24gaW5jbHVkZSBzZWFyY2ggcGF0aC4KPiAKPiBJdCdzIGFsc28gbmljZSB3aGVu ICJmaWxlIiBtZWFucyBmaWxlIGJlbG9uZ2luZyB0byBvdXIgcHJvamVjdCwgYW5kIDxmaWxlPgo+ IG1lYW5zIDNyZC1wYXJ0eSBmaWxlLiAgU28gd2UgaGF2ZSB0byBjaG9vc2Ugd2hpY2ggc2VtYW50 aWNzIGFyZSBlYXNpZXI7Cj4gcGVyaGFwcyBiZXR0ZXIgTWFrZWZpbGUgcnVsZXMgdGhhdCBwcmV2 ZW50IHVzIGZyb20gc2VlaW5nIHN0YWxlIGZpbGVzIGlzIGEKPiBiZXR0ZXIgc29sdXRpb24gdGhh biBmaWd1cmluZyBvdXQgd2hpY2ggZmlsZXMgYXJlIGdlbmVyYXRlZC4KClRoYXQncyB3aGF0IEkn dmUgYXR0ZW1wdGVkIGhlcmU6CgogIGh0dHBzOi8vbGlzdHMuZ251Lm9yZy9hcmNoaXZlL2h0bWwv cWVtdS1kZXZlbC8yMDE4LTAzL21zZzA1NDIxLmh0bWwKCgpSZWdhcmRzLApEYW5pZWwKLS0gCnw6 IGh0dHBzOi8vYmVycmFuZ2UuY29tICAgICAgLW8tICAgIGh0dHBzOi8vd3d3LmZsaWNrci5jb20v cGhvdG9zL2RiZXJyYW5nZSA6fAp8OiBodHRwczovL2xpYnZpcnQub3JnICAgICAgICAgLW8tICAg ICAgICAgICAgaHR0cHM6Ly9mc3RvcDEzOC5iZXJyYW5nZS5jb20gOnwKfDogaHR0cHM6Ly9lbnRh bmdsZS1waG90by5vcmcgICAgLW8tICAgIGh0dHBzOi8vd3d3Lmluc3RhZ3JhbS5jb20vZGJlcnJh bmdlIDp8CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpY ZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRw czovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyKKd-00076d-6w for qemu-devel@nongnu.org; Tue, 20 Mar 2018 12:41:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyKKc-0006nE-B4 for qemu-devel@nongnu.org; Tue, 20 Mar 2018 12:41:51 -0400 Date: Tue, 20 Mar 2018 16:40:48 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180320164048.GB4530@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <1521510562-529051-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] qemu: include generated files with <> and not "" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, Paolo Bonzini , Peter Crosthwaite , Richard Henderson , Gerd Hoffmann , Eduardo Habkost , Igor Mammedov , Kevin Wolf , Max Reitz , Jeff Cody , Fam Zheng , John Snow , Stefan Weil , Stefan Hajnoczi , Ronnie Sahlberg , Peter Lieven , Markus Armbruster , Alberto Garcia , Josh Durgin , Hitoshi Mitake , Liu Yuan , "Richard W.M. Jones" , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , "Dr. David Alan Gilbert" , Greg Kurz , Ben Warren , Peter Maydell , Shannon Zhao , Michael Walle , Keith Busch , Stefano Stabellini , Anthony Perard , Fabien Chouteau , Amit Shah , Marcel Apfelbaum , Mark Cave-Ayland , BALATON Zoltan , Alexander Graf , Cornelia Huck , Christian Borntraeger , David Gibson , Corey Minyard , =?utf-8?B?SGVydsOp?= Poussineau , Peter Chubb , Subbaraya Sundeep , Dmitry Fleytman , Jason Wang , Yongbok Kim , Max Filippov , Jiri Pirko , Yuval Shaia , David Hildenbrand , Hannes Reinecke , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Andrzej Zaborowski , Artyom Tarasenko , Alistair Francis , "Edgar E. Iglesias" , Stefan Berger , Alex Williamson , zhanghailiang , Juan Quintela , Michael Roth , Andreas =?utf-8?Q?F=C3=A4rber?= , Pavel Dovgalyuk , Riku Voipio , Laurent Vivier , Zhang Chen , Li Zhijian , Wen Congyang , Xie Changlong , Marcelo Tosatti , Aurelien Jarno , kvm@vger.kernel.org, qemu-block@nongnu.org, sheepdog@lists.wpkg.org, qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-ppc@nongnu.org, qemu-s390x@nongnu.org On Tue, Mar 20, 2018 at 11:12:00AM -0500, Eric Blake wrote: > On 03/19/2018 08:54 PM, Michael S. Tsirkin wrote: > > QEMU coding style at the moment asks for all non-system > > include files to be used with #include "foo.h". > > [I'm replying without having read the rest of the thread, so bear with me if > I repeat some of the other comments that have already been made] > > And Markus even just did a cleanup along those lines. > > > However this rule actually does not make sense and > > creates issues for when the included file is generated. > > > > In C, include "file" means look in current directory, > > then on include search path. Current directory here > > means the source file directory. > > By comparison include means look on include search path. > > It's also nice when "file" means file belonging to our project, and > means 3rd-party file. So we have to choose which semantics are easier; > perhaps better Makefile rules that prevent us from seeing stale files is a > better solution than figuring out which files are generated. That's what I've attempted here: https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg05421.html Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [PATCH] qemu: include generated files with <> and not "" Date: Tue, 20 Mar 2018 16:40:48 +0000 Message-ID: <20180320164048.GB4530@redhat.com> References: <1521510562-529051-1-git-send-email-mst@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1eyKKK-0002Fw-VU for xen-devel@lists.xenproject.org; Tue, 20 Mar 2018 16:41:33 +0000 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Eric Blake Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , "Michael S. Tsirkin" , Jeff Cody , Zhang Chen , Mark Cave-Ayland , qemu-devel@nongnu.org, BALATON Zoltan , Keith Busch , Max Filippov , Laurent Vivier , Gerd Hoffmann , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Yongbok Kim , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMTE6MTI6MDBBTSAtMDUwMCwgRXJpYyBCbGFrZSB3cm90 ZToKPiBPbiAwMy8xOS8yMDE4IDA4OjU0IFBNLCBNaWNoYWVsIFMuIFRzaXJraW4gd3JvdGU6Cj4g PiBRRU1VIGNvZGluZyBzdHlsZSBhdCB0aGUgbW9tZW50IGFza3MgZm9yIGFsbCBub24tc3lzdGVt Cj4gPiBpbmNsdWRlIGZpbGVzIHRvIGJlIHVzZWQgd2l0aCAjaW5jbHVkZSAiZm9vLmgiLgo+IAo+ IFtJJ20gcmVwbHlpbmcgd2l0aG91dCBoYXZpbmcgcmVhZCB0aGUgcmVzdCBvZiB0aGUgdGhyZWFk LCBzbyBiZWFyIHdpdGggbWUgaWYKPiBJIHJlcGVhdCBzb21lIG9mIHRoZSBvdGhlciBjb21tZW50 cyB0aGF0IGhhdmUgYWxyZWFkeSBiZWVuIG1hZGVdCj4gCj4gQW5kIE1hcmt1cyBldmVuIGp1c3Qg ZGlkIGEgY2xlYW51cCBhbG9uZyB0aG9zZSBsaW5lcy4KPiAKPiA+IEhvd2V2ZXIgdGhpcyBydWxl IGFjdHVhbGx5IGRvZXMgbm90IG1ha2Ugc2Vuc2UgYW5kCj4gPiBjcmVhdGVzIGlzc3VlcyBmb3Ig d2hlbiB0aGUgaW5jbHVkZWQgZmlsZSBpcyBnZW5lcmF0ZWQuCj4gPiAKPiA+IEluIEMsIGluY2x1 ZGUgImZpbGUiIG1lYW5zIGxvb2sgaW4gY3VycmVudCBkaXJlY3RvcnksCj4gPiB0aGVuIG9uIGlu Y2x1ZGUgc2VhcmNoIHBhdGguIEN1cnJlbnQgZGlyZWN0b3J5IGhlcmUKPiA+IG1lYW5zIHRoZSBz b3VyY2UgZmlsZSBkaXJlY3RvcnkuCj4gPiBCeSBjb21wYXJpc29uIGluY2x1ZGUgPGZpbGU+IG1l YW5zIGxvb2sgb24gaW5jbHVkZSBzZWFyY2ggcGF0aC4KPiAKPiBJdCdzIGFsc28gbmljZSB3aGVu ICJmaWxlIiBtZWFucyBmaWxlIGJlbG9uZ2luZyB0byBvdXIgcHJvamVjdCwgYW5kIDxmaWxlPgo+ IG1lYW5zIDNyZC1wYXJ0eSBmaWxlLiAgU28gd2UgaGF2ZSB0byBjaG9vc2Ugd2hpY2ggc2VtYW50 aWNzIGFyZSBlYXNpZXI7Cj4gcGVyaGFwcyBiZXR0ZXIgTWFrZWZpbGUgcnVsZXMgdGhhdCBwcmV2 ZW50IHVzIGZyb20gc2VlaW5nIHN0YWxlIGZpbGVzIGlzIGEKPiBiZXR0ZXIgc29sdXRpb24gdGhh biBmaWd1cmluZyBvdXQgd2hpY2ggZmlsZXMgYXJlIGdlbmVyYXRlZC4KClRoYXQncyB3aGF0IEkn dmUgYXR0ZW1wdGVkIGhlcmU6CgogIGh0dHBzOi8vbGlzdHMuZ251Lm9yZy9hcmNoaXZlL2h0bWwv cWVtdS1kZXZlbC8yMDE4LTAzL21zZzA1NDIxLmh0bWwKCgpSZWdhcmRzLApEYW5pZWwKLS0gCnw6 IGh0dHBzOi8vYmVycmFuZ2UuY29tICAgICAgLW8tICAgIGh0dHBzOi8vd3d3LmZsaWNrci5jb20v cGhvdG9zL2RiZXJyYW5nZSA6fAp8OiBodHRwczovL2xpYnZpcnQub3JnICAgICAgICAgLW8tICAg ICAgICAgICAgaHR0cHM6Ly9mc3RvcDEzOC5iZXJyYW5nZS5jb20gOnwKfDogaHR0cHM6Ly9lbnRh bmdsZS1waG90by5vcmcgICAgLW8tICAgIGh0dHBzOi8vd3d3Lmluc3RhZ3JhbS5jb20vZGJlcnJh bmdlIDp8CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpY ZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRw czovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs