From: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
kvm@vger.kernel.org
Cc: cohuck@redhat.com, borntraeger@de.ibm.com,
bjsdjshi@linux.vnet.ibm.com, pasic@linux.vnet.ibm.com,
pmorel@linux.vnet.ibm.com
Subject: [PATCH 0/4] vfio: ccw: error handling fixes and improvements
Date: Wed, 21 Mar 2018 03:08:18 +0100 [thread overview]
Message-ID: <20180321020822.86255-1-bjsdjshi@linux.vnet.ibm.com> (raw)
Hi Conny,
Halil reported a host crash when using vfio-ccw. The root cause of the problem
is that vfio_pin_pages fails with EINVAL for reasons unknown. He has
experienced such failures after online-ing a dasd in the guest (the dasd has 3
partitions, hat may or may not have any significance). The problem isn't
experienced on every attempt to online the dasd, and breaking at css_do_ssch
seems to make things work.
One thing is sure: the host kernel should not crash under the described
circumstances.
To fix the problem, the first patch of this series fixes the cleanup when
cp_prefetch fails in the higher level. The 2nd and the 3rd patches provide
correctness and denfensive actions for the interfaces in the lower level.
The 4th patch is trying to add tracepoints for vfio-ccw, so that we can debug
such issue easier in future.
For details see the commit message portions of the inividual patches.
Thanks.
Dong Jia Shi (2):
vfio: ccw: refactor and improve pfn_array_alloc_pin()
vfio: ccw: set ccw->cda to NULL defensively
Halil Pasic (2):
vfio: ccw: fix cleanup if cp_prefetch fails
vfio: ccw: add traceponits for interesting error paths
drivers/s390/cio/Makefile | 1 +
drivers/s390/cio/vfio_ccw_cp.c | 121 ++++++++++++++++++++------------------
drivers/s390/cio/vfio_ccw_fsm.c | 13 ++++
drivers/s390/cio/vfio_ccw_trace.h | 86 +++++++++++++++++++++++++++
4 files changed, 163 insertions(+), 58 deletions(-)
create mode 100644 drivers/s390/cio/vfio_ccw_trace.h
--
2.13.5
next reply other threads:[~2018-03-21 2:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 2:08 Dong Jia Shi [this message]
2018-03-21 2:08 ` [PATCH 1/4] vfio: ccw: fix cleanup if cp_prefetch fails Dong Jia Shi
2018-03-21 12:49 ` Halil Pasic
[not found] ` <20180322022248.GB12194@bjsdjshi@linux.vnet.ibm.com>
2018-03-22 9:37 ` Pierre Morel
2018-03-22 10:10 ` Halil Pasic
2018-03-26 12:28 ` Cornelia Huck
[not found] ` <20180327014200.GH12194@bjsdjshi@linux.vnet.ibm.com>
2018-04-20 10:54 ` Halil Pasic
2018-04-20 11:36 ` Cornelia Huck
2018-04-20 11:55 ` Halil Pasic
2018-03-21 2:08 ` [PATCH 2/4] vfio: ccw: refactor and improve pfn_array_alloc_pin() Dong Jia Shi
2018-03-26 13:28 ` Cornelia Huck
[not found] ` <20180327030026.GI12194@bjsdjshi@linux.vnet.ibm.com>
2018-03-27 10:01 ` Cornelia Huck
[not found] ` <20180328023638.GL12194@bjsdjshi@linux.vnet.ibm.com>
2018-03-28 7:58 ` Cornelia Huck
2018-03-21 2:08 ` [PATCH 3/4] vfio: ccw: set ccw->cda to NULL defensively Dong Jia Shi
2018-03-26 13:47 ` Cornelia Huck
[not found] ` <20180327030809.GJ12194@bjsdjshi@linux.vnet.ibm.com>
2018-03-27 10:03 ` Cornelia Huck
2018-03-21 2:08 ` [PATCH 4/4] vfio: ccw: add traceponits for interesting error paths Dong Jia Shi
2018-03-26 13:59 ` Cornelia Huck
[not found] ` <20180327075114.GK12194@bjsdjshi@linux.vnet.ibm.com>
2018-03-27 10:07 ` Cornelia Huck
2018-03-27 15:27 ` Halil Pasic
2018-03-29 12:32 ` Cornelia Huck
[not found] ` <20180410021639.GN5428@bjsdjshi@linux.vnet.ibm.com>
2018-04-10 8:55 ` Cornelia Huck
2018-04-10 10:48 ` Halil Pasic
2018-03-26 9:02 ` [PATCH 0/4] vfio: ccw: error handling fixes and improvements Cornelia Huck
2018-03-26 11:25 ` Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180321020822.86255-1-bjsdjshi@linux.vnet.ibm.com \
--to=bjsdjshi@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.vnet.ibm.com \
--cc=pmorel@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.