From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751930AbeCVDKM (ORCPT ); Wed, 21 Mar 2018 23:10:12 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:52386 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751716AbeCVDKL (ORCPT ); Wed, 21 Mar 2018 23:10:11 -0400 Date: Thu, 22 Mar 2018 05:10:09 +0200 From: "Michael S. Tsirkin" To: Jason Wang Cc: Jonathan Helman , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, virtio-dev@lists.oasis-open.org Subject: Re: [virtio-dev] Re: [PATCH v2] virtio_balloon: export hugetlb page allocation counts Message-ID: <20180322050842-mutt-send-email-mst@kernel.org> References: <1521497654-24807-1-git-send-email-jonathan.helman@oracle.com> <6ED6CAC9-FAD9-4A27-A9B1-C6EFC7627D68@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 22, 2018 at 09:52:18AM +0800, Jason Wang wrote: > > > On 2018年03月20日 12:26, Jonathan Helman wrote: > > > On Mar 19, 2018, at 7:31 PM, Jason Wang wrote: > > > > > > > > > > > > On 2018年03月20日 06:14, Jonathan Helman wrote: > > > > Export the number of successful and failed hugetlb page > > > > allocations via the virtio balloon driver. These 2 counts > > > > come directly from the vm_events HTLB_BUDDY_PGALLOC and > > > > HTLB_BUDDY_PGALLOC_FAIL. > > > > > > > > Signed-off-by: Jonathan Helman > > > Reviewed-by: Jason Wang > > Thanks. > > > > > > --- > > > > drivers/virtio/virtio_balloon.c | 6 ++++++ > > > > include/uapi/linux/virtio_balloon.h | 4 +++- > > > > 2 files changed, 9 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > > > > index dfe5684..6b237e3 100644 > > > > --- a/drivers/virtio/virtio_balloon.c > > > > +++ b/drivers/virtio/virtio_balloon.c > > > > @@ -272,6 +272,12 @@ static unsigned int update_balloon_stats(struct virtio_balloon *vb) > > > > pages_to_bytes(events[PSWPOUT])); > > > > update_stat(vb, idx++, VIRTIO_BALLOON_S_MAJFLT, events[PGMAJFAULT]); > > > > update_stat(vb, idx++, VIRTIO_BALLOON_S_MINFLT, events[PGFAULT]); > > > > +#ifdef CONFIG_HUGETLB_PAGE > > > > + update_stat(vb, idx++, VIRTIO_BALLOON_S_HTLB_PGALLOC, > > > > + events[HTLB_BUDDY_PGALLOC]); > > > > + update_stat(vb, idx++, VIRTIO_BALLOON_S_HTLB_PGFAIL, > > > > + events[HTLB_BUDDY_PGALLOC_FAIL]); > > > > +#endif > > > > #endif > > > > update_stat(vb, idx++, VIRTIO_BALLOON_S_MEMFREE, > > > > pages_to_bytes(i.freeram)); > > > > diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h > > > > index 4e8b830..40297a3 100644 > > > > --- a/include/uapi/linux/virtio_balloon.h > > > > +++ b/include/uapi/linux/virtio_balloon.h > > > > @@ -53,7 +53,9 @@ struct virtio_balloon_config { > > > > #define VIRTIO_BALLOON_S_MEMTOT 5 /* Total amount of memory */ > > > > #define VIRTIO_BALLOON_S_AVAIL 6 /* Available memory as in /proc */ > > > > #define VIRTIO_BALLOON_S_CACHES 7 /* Disk caches */ > > > > -#define VIRTIO_BALLOON_S_NR 8 > > > > +#define VIRTIO_BALLOON_S_HTLB_PGALLOC 8 /* Hugetlb page allocations */ > > > > +#define VIRTIO_BALLOON_S_HTLB_PGFAIL 9 /* Hugetlb page allocation failures */ > > > > +#define VIRTIO_BALLOON_S_NR 10 > > > > /* > > > > * Memory statistics structure. > > > Not for this patch, but it looks to me that exporting such nr through uapi is fragile. > > Sorry, can you explain what you mean here? > > > > Jon > > Spec said "Within an output buffer submitted to the statsq, the device MUST > ignore entries with tag values that it does not recognize". So exporting > VIRTIO_BALLOON_S_NR seems useless and device implementation can not depend > on such number in uapi. > > Thanks Suggestions? I don't like to break build for people ... > > > > > Thanks > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org > > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-3626-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [66.179.20.138]) by lists.oasis-open.org (Postfix) with ESMTP id A612C5818FD1 for ; Wed, 21 Mar 2018 20:10:12 -0700 (PDT) Date: Thu, 22 Mar 2018 05:10:09 +0200 From: "Michael S. Tsirkin" Message-ID: <20180322050842-mutt-send-email-mst@kernel.org> References: <1521497654-24807-1-git-send-email-jonathan.helman@oracle.com> <6ED6CAC9-FAD9-4A27-A9B1-C6EFC7627D68@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [virtio-dev] Re: [PATCH v2] virtio_balloon: export hugetlb page allocation counts To: Jason Wang Cc: Jonathan Helman , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, virtio-dev@lists.oasis-open.org List-ID: On Thu, Mar 22, 2018 at 09:52:18AM +0800, Jason Wang wrote: > > > On 2018年03月20日 12:26, Jonathan Helman wrote: > > > On Mar 19, 2018, at 7:31 PM, Jason Wang wrote: > > > > > > > > > > > > On 2018年03月20日 06:14, Jonathan Helman wrote: > > > > Export the number of successful and failed hugetlb page > > > > allocations via the virtio balloon driver. These 2 counts > > > > come directly from the vm_events HTLB_BUDDY_PGALLOC and > > > > HTLB_BUDDY_PGALLOC_FAIL. > > > > > > > > Signed-off-by: Jonathan Helman > > > Reviewed-by: Jason Wang > > Thanks. > > > > > > --- > > > > drivers/virtio/virtio_balloon.c | 6 ++++++ > > > > include/uapi/linux/virtio_balloon.h | 4 +++- > > > > 2 files changed, 9 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > > > > index dfe5684..6b237e3 100644 > > > > --- a/drivers/virtio/virtio_balloon.c > > > > +++ b/drivers/virtio/virtio_balloon.c > > > > @@ -272,6 +272,12 @@ static unsigned int update_balloon_stats(struct virtio_balloon *vb) > > > > pages_to_bytes(events[PSWPOUT])); > > > > update_stat(vb, idx++, VIRTIO_BALLOON_S_MAJFLT, events[PGMAJFAULT]); > > > > update_stat(vb, idx++, VIRTIO_BALLOON_S_MINFLT, events[PGFAULT]); > > > > +#ifdef CONFIG_HUGETLB_PAGE > > > > + update_stat(vb, idx++, VIRTIO_BALLOON_S_HTLB_PGALLOC, > > > > + events[HTLB_BUDDY_PGALLOC]); > > > > + update_stat(vb, idx++, VIRTIO_BALLOON_S_HTLB_PGFAIL, > > > > + events[HTLB_BUDDY_PGALLOC_FAIL]); > > > > +#endif > > > > #endif > > > > update_stat(vb, idx++, VIRTIO_BALLOON_S_MEMFREE, > > > > pages_to_bytes(i.freeram)); > > > > diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h > > > > index 4e8b830..40297a3 100644 > > > > --- a/include/uapi/linux/virtio_balloon.h > > > > +++ b/include/uapi/linux/virtio_balloon.h > > > > @@ -53,7 +53,9 @@ struct virtio_balloon_config { > > > > #define VIRTIO_BALLOON_S_MEMTOT 5 /* Total amount of memory */ > > > > #define VIRTIO_BALLOON_S_AVAIL 6 /* Available memory as in /proc */ > > > > #define VIRTIO_BALLOON_S_CACHES 7 /* Disk caches */ > > > > -#define VIRTIO_BALLOON_S_NR 8 > > > > +#define VIRTIO_BALLOON_S_HTLB_PGALLOC 8 /* Hugetlb page allocations */ > > > > +#define VIRTIO_BALLOON_S_HTLB_PGFAIL 9 /* Hugetlb page allocation failures */ > > > > +#define VIRTIO_BALLOON_S_NR 10 > > > > /* > > > > * Memory statistics structure. > > > Not for this patch, but it looks to me that exporting such nr through uapi is fragile. > > Sorry, can you explain what you mean here? > > > > Jon > > Spec said "Within an output buffer submitted to the statsq, the device MUST > ignore entries with tag values that it does not recognize". So exporting > VIRTIO_BALLOON_S_NR seems useless and device implementation can not depend > on such number in uapi. > > Thanks Suggestions? I don't like to break build for people ... > > > > > Thanks > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org > > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org