From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:52552 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753385AbeCVL6S (ORCPT ); Thu, 22 Mar 2018 07:58:18 -0400 Date: Thu, 22 Mar 2018 12:58:11 +0100 From: Jesper Dangaard Brouer To: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Cc: brouer@redhat.com, jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org, =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , magnus.karlsson@intel.com, netdev@vger.kernel.org, alexander.h.duyck@intel.com, alexander.duyck@gmail.com Subject: Re: [PATCH v2 2/2] i40e: add support for XDP_REDIRECT Message-ID: <20180322125811.0dcc1b28@redhat.com> In-Reply-To: <20180322090307.14409-2-bjorn.topel@gmail.com> References: <20180322090307.14409-1-bjorn.topel@gmail.com> <20180322090307.14409-2-bjorn.topel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 22 Mar 2018 10:03:07 +0100 Björn Töpel wrote: > +/** > + * i40e_xdp_xmit - Implements ndo_xdp_xmit > + * @dev: netdev > + * @xdp: XDP buffer > + * > + * Returns Zero if sent, else an error code > + **/ > +int i40e_xdp_xmit(struct net_device *dev, struct xdp_buff *xdp) > +{ The return code is used by the XDP redirect tracepoint... this is the only way we have to debug/troubleshoot runtime issues with XDP. Thus, these need to be consistent across drives and distinguishable. > + struct i40e_netdev_priv *np = netdev_priv(dev); > + unsigned int queue_index = smp_processor_id(); > + struct i40e_vsi *vsi = np->vsi; > + int err; > + > + if (test_bit(__I40E_VSI_DOWN, vsi->state)) > + return -EINVAL; Should be: -ENETDOWN > + > + if (!i40e_enabled_xdp_vsi(vsi) || queue_index >= vsi->num_queue_pairs) > + return -EINVAL; Should be: -ENXIO > + err = i40e_xmit_xdp_ring(xdp, vsi->xdp_rings[queue_index]); > + if (err != I40E_XDP_TX) > + return -ENOMEM; Should be: -ENOSPC The ENOSPC return code is important, as this can be used as a feedback to a XDP_REDIRECT load-balancer facility. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Date: Thu, 22 Mar 2018 12:58:11 +0100 Subject: [Intel-wired-lan] [PATCH v2 2/2] i40e: add support for XDP_REDIRECT In-Reply-To: <20180322090307.14409-2-bjorn.topel@gmail.com> References: <20180322090307.14409-1-bjorn.topel@gmail.com> <20180322090307.14409-2-bjorn.topel@gmail.com> Message-ID: <20180322125811.0dcc1b28@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Thu, 22 Mar 2018 10:03:07 +0100 Bj?rn T?pel wrote: > +/** > + * i40e_xdp_xmit - Implements ndo_xdp_xmit > + * @dev: netdev > + * @xdp: XDP buffer > + * > + * Returns Zero if sent, else an error code > + **/ > +int i40e_xdp_xmit(struct net_device *dev, struct xdp_buff *xdp) > +{ The return code is used by the XDP redirect tracepoint... this is the only way we have to debug/troubleshoot runtime issues with XDP. Thus, these need to be consistent across drives and distinguishable. > + struct i40e_netdev_priv *np = netdev_priv(dev); > + unsigned int queue_index = smp_processor_id(); > + struct i40e_vsi *vsi = np->vsi; > + int err; > + > + if (test_bit(__I40E_VSI_DOWN, vsi->state)) > + return -EINVAL; Should be: -ENETDOWN > + > + if (!i40e_enabled_xdp_vsi(vsi) || queue_index >= vsi->num_queue_pairs) > + return -EINVAL; Should be: -ENXIO > + err = i40e_xmit_xdp_ring(xdp, vsi->xdp_rings[queue_index]); > + if (err != I40E_XDP_TX) > + return -ENOMEM; Should be: -ENOSPC The ENOSPC return code is important, as this can be used as a feedback to a XDP_REDIRECT load-balancer facility. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer