All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] cve: new regression test-case for CVE-2018-5803
Date: Thu, 22 Mar 2018 18:34:58 +0100	[thread overview]
Message-ID: <20180322173458.mcpm3jikk57rkhrr@dell5510> (raw)
In-Reply-To: <a26d2a06-429a-b0dd-995a-c01dbb7a4718@oracle.com>

Hi Alexey,

> > LGTM.
> > Tested-by: Petr Vorel <pvorel@suse.cz>
> > Found one BROK on EINVAL on setsockopt(), most of older kernels in VM don't crash, bug generate
> > heavy load.

> Does it happen with a single address parameter? We could also lower parameter
> size in the second test, e.g. from 10000 to 4000.
I didn't notice before that it actually calls BUG() in skb_put(), test does not end.
Adding -a 4000 does not help.

> Also change SOCK_STREAM to SOCK_SEQPACKET

> diff --git a/testcases/cve/cve-2018-5803.c b/testcases/cve/cve-2018-5803.c
> index 3f03d8a..6bee914 100644
> --- a/testcases/cve/cve-2018-5803.c
> +++ b/testcases/cve/cve-2018-5803.c
> @@ -63,7 +63,7 @@ static void setup_client(void)
>         struct sockaddr_in6 addr_buf[addr_num];
>         int i;

> -       cfd = SAFE_SOCKET(AF_INET6, SOCK_STREAM, IPPROTO_SCTP);
> +       cfd = SAFE_SOCKET(AF_INET6, SOCK_SEQPACKET, IPPROTO_SCTP);
>         rmt.sin6_family = AF_INET6;
>         rmt.sin6_addr = in6addr_loopback;
>         rmt.sin6_port = htons(port);


> I could also add IPv4 version...
I have no idea if it's useful.

> Thanks,
> Alexey


Kind regards,
Petr

  parent reply	other threads:[~2018-03-22 17:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12 16:36 [LTP] [PATCH] cve: new regression test-case for CVE-2018-5803 Alexey Kodanev
2018-03-20 14:00 ` Petr Vorel
2018-03-21 11:28   ` Alexey Kodanev
2018-03-22 17:34     ` Petr Vorel
2018-03-22 17:34     ` Petr Vorel [this message]
2018-03-21 14:26 ` Richard Palethorpe
2018-03-21 15:12   ` Alexey Kodanev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180322173458.mcpm3jikk57rkhrr@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.