From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-qt0-f182.google.com ([209.85.216.182]:43649 "EHLO
        mail-qt0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751881AbeCWDga (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 22 Mar 2018 23:36:30 -0400
Received: by mail-qt0-f182.google.com with SMTP id s48so11264468qtb.10
        for <netdev@vger.kernel.org>; Thu, 22 Mar 2018 20:36:30 -0700 (PDT)
Date: Thu, 22 Mar 2018 20:36:24 -0700
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, idosch@mellanox.com,
        mlxsw@mellanox.com, andrew@lunn.ch,
        vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
        michael.chan@broadcom.com, ganeshgr@chelsio.com,
        saeedm@mellanox.com, simon.horman@netronome.com,
        pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com,
        dirk.vandermerwe@netronome.com, alexander.h.duyck@intel.com,
        ogerlitz@mellanox.com, dsahern@gmail.com, vijaya.guvva@cavium.com,
        satananda.burla@cavium.com, raghu.vatsavayi@cavium.com,
        felix.manlunas@cavium.com, gospo@broadcom.com,
        sathya.perla@broadcom.com, vasundhara-v.volam@broadcom.com,
        tariqt@mellanox.com, eranbe@mellanox.com,
        jeffrey.t.kirsher@intel.com
Subject: Re: [patch net-next RFC 02/12] devlink: extend attrs_set for
 setting port flavours
Message-ID: <20180322203624.36e8b693@cakuba.netronome.com>
In-Reply-To: <20180322105522.8186-3-jiri@resnulli.us>
References: <20180322105522.8186-1-jiri@resnulli.us>
        <20180322105522.8186-3-jiri@resnulli.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, 22 Mar 2018 11:55:12 +0100, Jiri Pirko wrote:
>  enum devlink_attr {
>  	/* don't change the order or add anything between, this is ABI! */
>  	DEVLINK_ATTR_UNSPEC,
> @@ -224,6 +242,7 @@ enum devlink_attr {
>  	DEVLINK_ATTR_DPIPE_TABLE_RESOURCE_ID,	/* u64 */
>  	DEVLINK_ATTR_DPIPE_TABLE_RESOURCE_UNITS,/* u64 */
>  
> +	DEVLINK_ATTR_PORT_FLAVOUR,		/* u16 */
>  	DEVLINK_ATTR_PORT_NUMBER,		/* u32 */
>  	DEVLINK_ATTR_PORT_SPLIT_SUBPORT_NUMBER,	/* u32 */

nit: why is it OK to add the attr in the middle of enum?