From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH 04/12] drm/i915/psr: Tie PSR2 support to Y coordinate requirement Date: Thu, 22 Mar 2018 16:09:08 -0700 Message-ID: <20180322230908.GK2557@intel.com> References: <20180322214848.28022-1-jose.souza@intel.com> <20180322214848.28022-4-jose.souza@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8F1296E21F for ; Thu, 22 Mar 2018 23:09:10 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180322214848.28022-4-jose.souza@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?iso-8859-1?Q?Jos=E9?= Roberto de Souza Cc: intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXIgMjIsIDIwMTggYXQgMDI6NDg6NDBQTSAtMDcwMCwgSm9zw6kgUm9iZXJ0byBk ZSBTb3V6YSB3cm90ZToKPiBNb3ZlIHRvIG9ubHkgb25lIHBsYWNlIHRoZSBzaW5rIHJlcXVpcmVt ZW50cyB0aGF0IHRoZSBhY3R1YWwgZHJpdmVyCj4gbmVlZHMgdG8gZW5hYmxlIFBTUjIuCj4gCj4g QWxzbyBpbnRlbF9wc3IyX2NvbmZpZ192YWxpZCgpIGlzIGNhbGxlZCBldmVyeSB0aW1lIHRoZSBj cnRjIGNvbmZpZwo+IGlzIGNvbXB1dGVkLCB3YXN0aW5nIHNvbWUgdGltZSBldmVyeSB0aW1lIGl0 IHdhcyBjaGVja2luZyBmb3IKPiBZIGNvb3JkaW5hdGUgcmVxdWlyZW1lbnQuCj4gCj4gVGhpcyBh bGxvdyB1cyB0byBudWtlIHlfY29yZF9zdXBwb3J0IGFuZCBzb21lIG9mIFZTQyBzZXR1cCBjb2Rl IHRoYXQKPiB3YXMgaGFuZGxpbmcgYSBzY2VuYXJpbyB0aGF0IHdvdWxkIG5ldmVyIGhhcHBlbihQ U1IyIHdpdGhvdXQgWQo+IGNvb3JkaW5hdGUpLgo+IAo+IENjOiBEaGluYWthcmFuIFBhbmRpeWFu IDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4KPiBDYzogUm9kcmlnbyBWaXZpIDxyb2Ry aWdvLnZpdmlAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEpvc8OpIFJvYmVydG8gZGUgU291 emEgPGpvc2Uuc291emFAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2Rydi5oICB8ICAxIC0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMgfCA0 NiArKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDIgZmlsZXMgY2hh bmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMjggZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2Rydi5oCj4gaW5kZXggN2ZlMDA1MDllNTFhLi5jY2UzMjY4NmZkNzUgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtNjAzLDcgKzYwMyw2IEBAIHN0cnVjdCBpOTE1X3BzciB7 Cj4gIAl1bnNpZ25lZCBidXN5X2Zyb250YnVmZmVyX2JpdHM7Cj4gIAlib29sIHBzcjJfc3VwcG9y dDsKPiAgCWJvb2wgbGlua19zdGFuZGJ5Owo+IC0JYm9vbCB5X2NvcmRfc3VwcG9ydDsKPiAgCWJv b2wgY29sb3JpbWV0cnlfc3VwcG9ydDsKPiAgCWJvb2wgYWxwbTsKPiAgCWJvb2wgaGFzX2h3X3Ry YWNraW5nOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gaW5kZXggZDQ2MzIwYTQ1MWQ5Li4y M2YzOGFiMTA2MzYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNy LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+IEBAIC05Myw3ICs5 Myw3IEBAIHN0YXRpYyB2b2lkIHBzcl9hdXhfaW9fcG93ZXJfcHV0KHN0cnVjdCBpbnRlbF9kcCAq aW50ZWxfZHApCj4gIAlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChkZXZfcHJpdiwgcHNyX2F1eF9k b21haW4oaW50ZWxfZHApKTsKPiAgfQo+ICAKPiAtc3RhdGljIGJvb2wgaW50ZWxfZHBfZ2V0X3lf Y29yZF9zdGF0dXMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiArc3RhdGljIGJvb2wgaW50 ZWxfZHBfZ2V0X3lfY29vcmRfcmVxdWlyZWQoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKCm5p cDogSSBkb24ndCBhZ3JlZSB0aGF0IHJlcXVpcmVkIGlzIGEgZ29vZCBuYW1lIGZvciB0aGlzIGZ1 bmN0aW9uIGNhbGwKc28gbWF5YmUgd2Ugc2hvdWxkIGp1c3QgbGVhdmUgc3RhdHVzIGFuZCBtaW5p bWl6ZSB0aGUgY2hhbmdlLgoKPiAgewo+ICAJdWludDhfdCBwc3JfY2FwcyA9IDA7Cj4gIAo+IEBA IC0xMzAsMjIgKzEzMCwyOSBAQCB2b2lkIGludGVsX3Bzcl9pbml0X2RwY2Qoc3RydWN0IGludGVs X2RwICppbnRlbF9kcCkKPiAgCWRybV9kcF9kcGNkX3JlYWQoJmludGVsX2RwLT5hdXgsIERQX1BT Ul9TVVBQT1JULCBpbnRlbF9kcC0+cHNyX2RwY2QsCj4gIAkJCSBzaXplb2YoaW50ZWxfZHAtPnBz cl9kcGNkKSk7Cj4gIAo+IC0JaWYgKGludGVsX2RwLT5wc3JfZHBjZFswXSAmIERQX1BTUl9JU19T VVBQT1JURUQpIHsKPiArCWlmIChpbnRlbF9kcC0+cHNyX2RwY2RbMF0pIHsKCmhtPyB3aHk/Cgo+ ICAJCWRldl9wcml2LT5wc3Iuc2lua19zdXBwb3J0ID0gdHJ1ZTsKPiAgCQlEUk1fREVCVUdfS01T KCJEZXRlY3RlZCBFRFAgUFNSIFBhbmVsLlxuIik7Cj4gIAl9Cj4gIAo+ICAJaWYgKElOVEVMX0dF TihkZXZfcHJpdikgPj0gOSAmJgo+IC0JICAgIChpbnRlbF9kcC0+cHNyX2RwY2RbMF0gJiBEUF9Q U1IyX0lTX1NVUFBPUlRFRCkpIHsKPiAtCj4gLQkJZGV2X3ByaXYtPnBzci5zaW5rX3N1cHBvcnQg PSB0cnVlOwo+IC0JCWRldl9wcml2LT5wc3IucHNyMl9zdXBwb3J0ID0gdHJ1ZTsKPiArCSAgICAo aW50ZWxfZHAtPnBzcl9kcGNkWzBdID09IERQX1BTUjJfV0lUSF9ZX0NPT1JEX0lTX1NVUFBPUlRF RCkpIHsKPiArCQkvKgo+ICsJCSAqIEFsbCBwYW5lbHMgdGhhdCBzdXBwb3J0cyBQU1IgdmVyc2lv biAwM2ggKFBTUjIgKwo+ICsJCSAqIFktY29vcmRpbmF0ZSkgY2FuIGhhbmRsZSBZLWNvb3JkaW5h dGVzIGluIFZTQyBidXQgd2UgYXJlCj4gKwkJICogb25seSBzdXJlIHRoYXQgaXQgaXMgZ29pbmcg dG8gYmUgdXNlZCB3aGVuIHJlcXVpcmVkIGJ5IHRoZQo+ICsJCSAqIHBhbmVsLiBUaGlzIHdheSBw YW5lbCBpcyBjYXBhYmxlIHRvIGRvIHNlbGVjdGl2ZSB1cGRhdGUKPiArCQkgKiB3aXRob3V0IGEg YXV4IGZyYW1lIHN5bmMuCj4gKwkJICoKPiArCQkgKiBUbyBzdXBwb3J0IFBTUiB2ZXJzaW9uIDAy aCBhbmQgUFNSIHZlcnNpb24gMDNoIHdpdGhvdXQKPiArCQkgKiBZLWNvb3JkaW5hdGUgcmVxdWly ZW1lbnQgcGFuZWxzIHdlIHdvdWxkIG5lZWQgdG8gZW5hYmxlCj4gKwkJICogR1RDIGZpcnN0Lgo+ ICsJCSAqLwo+ICsJCWRldl9wcml2LT5wc3IucHNyMl9zdXBwb3J0ID0gaW50ZWxfZHBfZ2V0X3lf Y29vcmRfcmVxdWlyZWQoaW50ZWxfZHApOwoKb2ggb2sgb2suLi4gbm93IEkgc2F3IHdoeSB5b3Ug Y2hhbmdlZCB0byAicmVxdWlyZWQiCgpCdXQgbXkgcXVlc3Rpb24gbm93IGlzLiBEbyB3ZSByZWFs bHkgbmVlZCB0byBjaGVjayB0aGlzIGJpdD8KCkkgYmVsaWV2ZSB3aXRoIHlvdXIgY2hhbmdlIHRv IGNoZWNrIHZlcnNpb24gMDNoIHdlIGRvbid0IG5lZWQgdG8gY2hlY2sKdGhpcyByZXF1aXJlbWVu dCBhbnltb3JlLgpUaGlzIGxvb2tzIGxpa2UgaW4gdGhlIHBhc3Qgd2UgdXNlZCB0aGF0IHRvIHdv cmthcm91bmQgYSB3YXkgdG8gaWRlbnRpZnkKaWYgdGhlIHBhbmVsIHdhcyByZWFsbHkgeS1jb29y ZC4uLiBidXQgbm93IHdpdGggMDNoIHZlcnNpb24gd2UgZG9uJ3QgbmVlZAp0byBjaGVjayBpZiBw YW5lbCBpcyByZXF1aXJpbmcgdGhlIHktY29vcmRpbmF0aW9uIGZyb20gdGhlIHNvdXJjZSwgYmVj YXVzZQp3ZSBrbm93IHdoYXQgc291cmNlIGlzIGNhcGFibGUgb2YuCgo+ICAJCURSTV9ERUJVR19L TVMoIlBTUjIgJXMgb24gc2luayIsCj4gIAkJCSAgICAgIGRldl9wcml2LT5wc3IucHNyMl9zdXBw b3J0ID8gInN1cHBvcnRlZCIgOiAibm90IHN1cHBvcnRlZCIpOwo+ICAKPiAgCQlpZiAoZGV2X3By aXYtPnBzci5wc3IyX3N1cHBvcnQpIHsKPiAtCQkJZGV2X3ByaXYtPnBzci55X2NvcmRfc3VwcG9y dCA9Cj4gLQkJCQlpbnRlbF9kcF9nZXRfeV9jb3JkX3N0YXR1cyhpbnRlbF9kcCk7Cj4gIAkJCWRl dl9wcml2LT5wc3IuY29sb3JpbWV0cnlfc3VwcG9ydCA9Cj4gIAkJCQlpbnRlbF9kcF9nZXRfY29s b3JpbWV0cnlfc3RhdHVzKGludGVsX2RwKTsKPiAgCQkJZGV2X3ByaXYtPnBzci5hbHBtID0KPiBA QCAtMTkxLDE2ICsxOTgsMTIgQEAgc3RhdGljIHZvaWQgaHN3X3Bzcl9zZXR1cF92c2Moc3RydWN0 IGludGVsX2RwICppbnRlbF9kcCwKPiAgCQltZW1zZXQoJnBzcl92c2MsIDAsIHNpemVvZihwc3Jf dnNjKSk7Cj4gIAkJcHNyX3ZzYy5zZHBfaGVhZGVyLkhCMCA9IDA7Cj4gIAkJcHNyX3ZzYy5zZHBf aGVhZGVyLkhCMSA9IDB4NzsKPiAtCQlpZiAoZGV2X3ByaXYtPnBzci5jb2xvcmltZXRyeV9zdXBw b3J0ICYmCj4gLQkJICAgIGRldl9wcml2LT5wc3IueV9jb3JkX3N1cHBvcnQpIHsKPiArCQlpZiAo ZGV2X3ByaXYtPnBzci5jb2xvcmltZXRyeV9zdXBwb3J0KSB7Cj4gIAkJCXBzcl92c2Muc2RwX2hl YWRlci5IQjIgPSAweDU7Cj4gIAkJCXBzcl92c2Muc2RwX2hlYWRlci5IQjMgPSAweDEzOwo+IC0J CX0gZWxzZSBpZiAoZGV2X3ByaXYtPnBzci55X2NvcmRfc3VwcG9ydCkgewo+ICsJCX0gZWxzZSB7 Cj4gIAkJCXBzcl92c2Muc2RwX2hlYWRlci5IQjIgPSAweDQ7Cj4gIAkJCXBzcl92c2Muc2RwX2hl YWRlci5IQjMgPSAweGU7Cj4gLQkJfSBlbHNlIHsKPiAtCQkJcHNyX3ZzYy5zZHBfaGVhZGVyLkhC MiA9IDB4MzsKPiAtCQkJcHNyX3ZzYy5zZHBfaGVhZGVyLkhCMyA9IDB4YzsKPiAgCQl9Cj4gIAl9 IGVsc2Ugewo+ICAJCS8qIFByZXBhcmUgVlNDIHBhY2tldCBhcyBwZXIgRURQIDEuMyBzcGVjLCBU YWJsZSAzLjEwICovCj4gQEAgLTQ1OCwxNSArNDYxLDYgQEAgc3RhdGljIGJvb2wgaW50ZWxfcHNy Ml9jb25maWdfdmFsaWQoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiAgCQlyZXR1cm4gZmFs c2U7Cj4gIAl9Cj4gIAo+IC0JLyoKPiAtCSAqIEZJWE1FOmVuYWJsZSBwc3IyIG9ubHkgZm9yIHkt Y29yZGluYXRlIHBzcjIgcGFuZWxzCj4gLQkgKiBBZnRlciBndGMgaW1wbGVtZW50YXRpb24gLCBy ZW1vdmUgdGhpcyByZXN0cmljdGlvbi4KPiAtCSAqLwo+IC0JaWYgKCFkZXZfcHJpdi0+cHNyLnlf Y29yZF9zdXBwb3J0KSB7Cj4gLQkJRFJNX0RFQlVHX0tNUygiUFNSMiBub3QgZW5hYmxlZCwgcGFu ZWwgZG9lcyBub3Qgc3VwcG9ydCBZIGNvb3JkaW5hdGVcbiIpOwo+IC0JCXJldHVybiBmYWxzZTsK PiAtCX0KPiAtCj4gIAlyZXR1cm4gdHJ1ZTsKPiAgfQo+ICAKPiBAQCAtNTY2LDcgKzU2MCw2IEBA IHN0YXRpYyB2b2lkIGhzd19wc3JfZW5hYmxlX3NvdXJjZShzdHJ1Y3QgaW50ZWxfZHAgKmludGVs X2RwLAo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGRpZ19wb3J0LT5iYXNlLmJhc2UuZGV2 Owo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYpOwo+ ICAJZW51bSB0cmFuc2NvZGVyIGNwdV90cmFuc2NvZGVyID0gY3J0Y19zdGF0ZS0+Y3B1X3RyYW5z Y29kZXI7Cj4gLQl1MzIgY2hpY2tlbjsKPiAgCj4gIAlwc3JfYXV4X2lvX3Bvd2VyX2dldChpbnRl bF9kcCk7Cj4gIAo+IEBAIC01NzcsOSArNTcwLDggQEAgc3RhdGljIHZvaWQgaHN3X3Bzcl9lbmFi bGVfc291cmNlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gIAkJaHN3X3Bzcl9zZXR1cF9h dXgoaW50ZWxfZHApOwo+ICAKPiAgCWlmIChkZXZfcHJpdi0+cHNyLnBzcjJfc3VwcG9ydCkgewo+ IC0JCWNoaWNrZW4gPSBQU1IyX1ZTQ19FTkFCTEVfUFJPR19IRUFERVI7Cj4gLQkJaWYgKGRldl9w cml2LT5wc3IueV9jb3JkX3N1cHBvcnQpCj4gLQkJCWNoaWNrZW4gfD0gUFNSMl9BRERfVkVSVElD QUxfTElORV9DT1VOVDsKPiArCQl1MzIgY2hpY2tlbiA9IFBTUjJfVlNDX0VOQUJMRV9QUk9HX0hF QURFUgo+ICsJCQkgICAgICB8IFBTUjJfQUREX1ZFUlRJQ0FMX0xJTkVfQ09VTlQ7Cj4gIAkJSTkx NV9XUklURShDSElDS0VOX1RSQU5TKGNwdV90cmFuc2NvZGVyKSwgY2hpY2tlbik7Cj4gIAo+ICAJ CUk5MTVfV1JJVEUoRURQX1BTUl9ERUJVRywKPiAtLSAKPiAyLjE2LjIKPiAKPiBfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5n IGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==