From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:40007 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751920AbeCWNTl (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 23 Mar 2018 09:19:41 -0400
Date: Fri, 23 Mar 2018 14:19:29 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, idosch@mellanox.com,
        jakub.kicinski@netronome.com, mlxsw@mellanox.com,
        vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
        michael.chan@broadcom.com, ganeshgr@chelsio.com,
        saeedm@mellanox.com, simon.horman@netronome.com,
        pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com,
        dirk.vandermerwe@netronome.com, alexander.h.duyck@intel.com,
        ogerlitz@mellanox.com, dsahern@gmail.com, vijaya.guvva@cavium.com,
        satananda.burla@cavium.com, raghu.vatsavayi@cavium.com,
        felix.manlunas@cavium.com, gospo@broadcom.com,
        sathya.perla@broadcom.com, vasundhara-v.volam@broadcom.com,
        tariqt@mellanox.com, eranbe@mellanox.com,
        jeffrey.t.kirsher@intel.com
Subject: Re: [patch net-next RFC 04/12] dsa: set devlink port attrs for dsa
 ports
Message-ID: <20180323131929.GE5145@lunn.ch>
References: <20180322105522.8186-1-jiri@resnulli.us>
 <20180322105522.8186-5-jiri@resnulli.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180322105522.8186-5-jiri@resnulli.us>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Mar 22, 2018 at 11:55:14AM +0100, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox.com>
> 
> Set the attrs and allow to expose port flavour to user via devlink.
> 
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> ---
>  net/dsa/dsa2.c | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c
> index adf50fbc4c13..49453690696d 100644
> --- a/net/dsa/dsa2.c
> +++ b/net/dsa/dsa2.c
> @@ -270,7 +270,27 @@ static int dsa_port_setup(struct dsa_port *dp)
>  	case DSA_PORT_TYPE_UNUSED:
>  		break;
>  	case DSA_PORT_TYPE_CPU:
> +		/* dp->index is used now as port_number. However
> +		 * CPU ports should have separate numbering
> +		 * independent from front panel port numbers.
> +		 */
> +		devlink_port_attrs_set(&dp->devlink_port,
> +				       DEVLINK_PORT_FLAVOUR_CPU,
> +				       dp->index, false, 0);
> +		err = dsa_port_link_register_of(dp);
> +		if (err) {
> +			dev_err(ds->dev, "failed to setup link for port %d.%d\n",
> +				ds->index, dp->index);
> +			return err;
> +		}

Hi Jiri

Please could you explain what you are trying to achieve with this call to 
dsa_port_link_register_of(dp);

Thanks
	Andrew