From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752921AbeCWM5w convert rfc822-to-8bit (ORCPT ); Fri, 23 Mar 2018 08:57:52 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:41283 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752865AbeCWM5p (ORCPT ); Fri, 23 Mar 2018 08:57:45 -0400 Date: Fri, 23 Mar 2018 12:57:29 +0000 From: Jonathan Cameron To: =?ISO-8859-1?Q?Hern=E1n?= Gonzalez CC: , , , , , , Subject: Re: [PATCH 10/11] staging: iio: ad7746: Rename sysfs attrs to comply with the ABI Message-ID: <20180323135729.00003e93@huawei.com> In-Reply-To: <1521642539-4845-11-git-send-email-hernan@vanguardiasur.com.ar> References: <1521642539-4845-1-git-send-email-hernan@vanguardiasur.com.ar> <1521642539-4845-11-git-send-email-hernan@vanguardiasur.com.ar> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.202.226.45] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Mar 2018 11:28:58 -0300 Hernán Gonzalez wrote: > Signed-off-by: Hernán Gonzalez Please look at what these do. It is not what those abi elements are documented as doing. Also if it were you would need to support them via read_raw and write_raw and put them in the relevant info mask elements. Jonathan > --- > drivers/staging/iio/cdc/ad7746.c | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c > index b6b99e2..c1f76fc 100644 > --- a/drivers/staging/iio/cdc/ad7746.c > +++ b/drivers/staging/iio/cdc/ad7746.c > @@ -336,16 +336,16 @@ static ssize_t ad7746_start_gain_calib(struct device *dev, > AD7746_CONF_MODE_GAIN_CAL); > } > > -static IIO_DEVICE_ATTR(in_capacitance0_calibbias_calibration, > - 0200, NULL, ad7746_start_offset_calib, CIN1); > -static IIO_DEVICE_ATTR(in_capacitance1_calibbias_calibration, > - 0200, NULL, ad7746_start_offset_calib, CIN2); > -static IIO_DEVICE_ATTR(in_capacitance0_calibscale_calibration, > - 0200, NULL, ad7746_start_gain_calib, CIN1); > -static IIO_DEVICE_ATTR(in_capacitance1_calibscale_calibration, > - 0200, NULL, ad7746_start_gain_calib, CIN2); > -static IIO_DEVICE_ATTR(in_voltage0_calibscale_calibration, > - 0200, NULL, ad7746_start_gain_calib, VIN); > +static IIO_DEVICE_ATTR(in_capacitance0_calibbias, 0200, NULL, > + ad7746_start_offset_calib, CIN1); > +static IIO_DEVICE_ATTR(in_capacitance1_calibbias, 0200, NULL, > + ad7746_start_offset_calib, CIN2); > +static IIO_DEVICE_ATTR(in_capacitance0_calibscale, 0200, NULL, > + ad7746_start_gain_calib, CIN1); > +static IIO_DEVICE_ATTR(in_capacitance1_calibscale, 0200, NULL, > + ad7746_start_gain_calib, CIN2); > +static IIO_DEVICE_ATTR(in_voltage0_calibscale, 0200, NULL, > + ad7746_start_gain_calib, VIN); > > static int ad7746_store_cap_filter_rate_setup(struct ad7746_chip_info *chip, > int val) > @@ -388,11 +388,11 @@ static IIO_CONST_ATTR(in_capacitance_sampling_frequency_available, > "91 84 50 26 16 13 11 9"); > > static struct attribute *ad7746_attributes[] = { > - &iio_dev_attr_in_capacitance0_calibbias_calibration.dev_attr.attr, > - &iio_dev_attr_in_capacitance0_calibscale_calibration.dev_attr.attr, > - &iio_dev_attr_in_capacitance1_calibscale_calibration.dev_attr.attr, > - &iio_dev_attr_in_capacitance1_calibbias_calibration.dev_attr.attr, > - &iio_dev_attr_in_voltage0_calibscale_calibration.dev_attr.attr, > + &iio_dev_attr_in_capacitance0_calibbias.dev_attr.attr, > + &iio_dev_attr_in_capacitance0_calibscale.dev_attr.attr, > + &iio_dev_attr_in_capacitance1_calibscale.dev_attr.attr, > + &iio_dev_attr_in_capacitance1_calibbias.dev_attr.attr, > + &iio_dev_attr_in_voltage0_calibscale.dev_attr.attr, > &iio_const_attr_in_voltage_sampling_frequency_available.dev_attr.attr, > &iio_const_attr_in_capacitance_sampling_frequency_available.dev_attr.attr, > NULL, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 23 Mar 2018 12:57:29 +0000 From: Jonathan Cameron To: =?ISO-8859-1?Q?Hern=E1n?= Gonzalez CC: , , , , , , Subject: Re: [PATCH 10/11] staging: iio: ad7746: Rename sysfs attrs to comply with the ABI Message-ID: <20180323135729.00003e93@huawei.com> In-Reply-To: <1521642539-4845-11-git-send-email-hernan@vanguardiasur.com.ar> References: <1521642539-4845-1-git-send-email-hernan@vanguardiasur.com.ar> <1521642539-4845-11-git-send-email-hernan@vanguardiasur.com.ar> MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" List-ID: On Wed, 21 Mar 2018 11:28:58 -0300 Hern=E1n Gonzalez wrote: > Signed-off-by: Hern=E1n Gonzalez Please look at what these do. It is not what those abi elements are documented as doing. Also if it were you would need to support them via read_raw and write_raw and put them in the relevant info mask elements. Jonathan > --- > drivers/staging/iio/cdc/ad7746.c | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) >=20 > diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/a= d7746.c > index b6b99e2..c1f76fc 100644 > --- a/drivers/staging/iio/cdc/ad7746.c > +++ b/drivers/staging/iio/cdc/ad7746.c > @@ -336,16 +336,16 @@ static ssize_t ad7746_start_gain_calib(struct devic= e *dev, > AD7746_CONF_MODE_GAIN_CAL); > } > =20 > -static IIO_DEVICE_ATTR(in_capacitance0_calibbias_calibration, > - 0200, NULL, ad7746_start_offset_calib, CIN1); > -static IIO_DEVICE_ATTR(in_capacitance1_calibbias_calibration, > - 0200, NULL, ad7746_start_offset_calib, CIN2); > -static IIO_DEVICE_ATTR(in_capacitance0_calibscale_calibration, > - 0200, NULL, ad7746_start_gain_calib, CIN1); > -static IIO_DEVICE_ATTR(in_capacitance1_calibscale_calibration, > - 0200, NULL, ad7746_start_gain_calib, CIN2); > -static IIO_DEVICE_ATTR(in_voltage0_calibscale_calibration, > - 0200, NULL, ad7746_start_gain_calib, VIN); > +static IIO_DEVICE_ATTR(in_capacitance0_calibbias, 0200, NULL, > + ad7746_start_offset_calib, CIN1); > +static IIO_DEVICE_ATTR(in_capacitance1_calibbias, 0200, NULL, > + ad7746_start_offset_calib, CIN2); > +static IIO_DEVICE_ATTR(in_capacitance0_calibscale, 0200, NULL, > + ad7746_start_gain_calib, CIN1); > +static IIO_DEVICE_ATTR(in_capacitance1_calibscale, 0200, NULL, > + ad7746_start_gain_calib, CIN2); > +static IIO_DEVICE_ATTR(in_voltage0_calibscale, 0200, NULL, > + ad7746_start_gain_calib, VIN); > =20 > static int ad7746_store_cap_filter_rate_setup(struct ad7746_chip_info *c= hip, > int val) > @@ -388,11 +388,11 @@ static IIO_CONST_ATTR(in_capacitance_sampling_frequ= ency_available, > "91 84 50 26 16 13 11 9"); > =20 > static struct attribute *ad7746_attributes[] =3D { > - &iio_dev_attr_in_capacitance0_calibbias_calibration.dev_attr.attr, > - &iio_dev_attr_in_capacitance0_calibscale_calibration.dev_attr.attr, > - &iio_dev_attr_in_capacitance1_calibscale_calibration.dev_attr.attr, > - &iio_dev_attr_in_capacitance1_calibbias_calibration.dev_attr.attr, > - &iio_dev_attr_in_voltage0_calibscale_calibration.dev_attr.attr, > + &iio_dev_attr_in_capacitance0_calibbias.dev_attr.attr, > + &iio_dev_attr_in_capacitance0_calibscale.dev_attr.attr, > + &iio_dev_attr_in_capacitance1_calibscale.dev_attr.attr, > + &iio_dev_attr_in_capacitance1_calibbias.dev_attr.attr, > + &iio_dev_attr_in_voltage0_calibscale.dev_attr.attr, > &iio_const_attr_in_voltage_sampling_frequency_available.dev_attr.attr, > &iio_const_attr_in_capacitance_sampling_frequency_available.dev_attr.at= tr, > NULL,