From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:39619 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751796AbeCWPFU (ORCPT ); Fri, 23 Mar 2018 11:05:20 -0400 Received: by mail-wm0-f68.google.com with SMTP id f125so4103059wme.4 for ; Fri, 23 Mar 2018 08:05:19 -0700 (PDT) Date: Fri, 23 Mar 2018 16:05:16 +0100 From: Jiri Pirko To: David Ahern Cc: netdev@vger.kernel.org, davem@davemloft.net, roopa@cumulusnetworks.com, shm@cumulusnetworks.com, jiri@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, David Ahern Subject: Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink Message-ID: <20180323150516.GE2125@nanopsycho> References: <20180322225757.10377-1-dsa@cumulusnetworks.com> <20180322225757.10377-8-dsa@cumulusnetworks.com> <20180323065010.GM2074@nanopsycho.orion> <03eade79-1727-3a31-8e31-a0a7f51b72cf@cumulusnetworks.com> <20180323150149.GD2125@nanopsycho> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Fri, Mar 23, 2018 at 04:03:40PM CET, dsa@cumulusnetworks.com wrote: >On 3/23/18 9:01 AM, Jiri Pirko wrote: >> Fri, Mar 23, 2018 at 03:31:02PM CET, dsa@cumulusnetworks.com wrote: >>> On 3/23/18 12:50 AM, Jiri Pirko wrote: >>>>> +void nsim_devlink_setup(struct netdevsim *ns) >>>>> +{ >>>>> + struct net *net = dev_net(ns->netdev); >>>>> + bool *reg_devlink = net_generic(net, nsim_devlink_id); >>>>> + struct devlink *devlink; >>>>> + int err = -ENOMEM; >>>>> + >>>>> + /* only one device per namespace controls devlink */ >>>>> + if (!*reg_devlink) { >>>>> + ns->devlink = NULL; >>>>> + return; >>>>> + } >>>>> + >>>>> + devlink = devlink_alloc(&nsim_devlink_ops, 0); >>>>> + if (!devlink) >>>>> + return; >>>>> + >>>>> + devlink_net_set(devlink, net); >>>>> + err = devlink_register(devlink, &ns->dev); >>>> >>>> This reg_devlink construct looks odd. Why don't you leave the devlink >>>> instance in init_ns? >>> >>> It is a per-network namespace resource controller. Since struct devlink >> >> Wait a second. What do you mean by "per-network namespace"? Devlink >> instance is always associated with one physical device. Like an ASIC. >> >> >>> has a net entry, the simplest design is to put it into the namespace of >>> the controller. Without it, controlling resource sizes in namespace >>> 'foobar' has to be done from init_net, which is just wrong. > >you need to look at how netdevsim creates a device per netdevice. That means one devlink instance for each netdevsim device, doesn't it?