From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:40365 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752462AbeCWWlF (ORCPT ); Fri, 23 Mar 2018 18:41:05 -0400 From: Saeed Mahameed To: "David S. Miller" Cc: netdev@vger.kernel.org, Gal Pressman , Saeed Mahameed Subject: [net-next 12/15] net/mlx5e: Remove redundant check in get ethtool stats Date: Fri, 23 Mar 2018 15:39:22 -0700 Message-Id: <20180323223925.21678-13-saeedm@mellanox.com> In-Reply-To: <20180323223925.21678-1-saeedm@mellanox.com> References: <20180323223925.21678-1-saeedm@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Gal Pressman ethtool core code makes sure data isn't NULL before calling get_ethtool_stats, testing it again in the driver is redundant. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c index 62061fd23143..d415e67b557b 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c @@ -203,9 +203,6 @@ void mlx5e_ethtool_get_ethtool_stats(struct mlx5e_priv *priv, { int i, idx = 0; - if (!data) - return; - mutex_lock(&priv->state_lock); mlx5e_update_stats(priv); mutex_unlock(&priv->state_lock); -- 2.14.3