Re: [PATCH v5 1/5] kexec: Return -ENOSYS when kexec does not know how to call KEXEC_FILE_LOAD

[Dave Young <dyoung@redhat.com>]

Hi Simon
On 03/26/18 at 09:25am, Simon Horman wrote:
> Hi Michal, thanks for the updated patches.
> 
> Dave, are you planning to review this series?
> 

I have same concern as I commented in last versioni, but seems
we can not convince each other with Michal.

For example for -EINVAL/-ENOEXEC, since it can be some misc
error checking in kernel code, it is not equal to an unsupported
syscall.  I'm not keen to think broken kernel file (include the case for
unsupported kernel format, but not limit to that) is equal as an
unsupported syscall

Also seems the new options are not showing in `kexec -h` although
added in the man page.

So I think I will leave to you and do not object it if you are fine. 

> On Tue, Mar 20, 2018 at 04:56:16PM +0100, Michal Suchanek wrote:
> > When the kernel does not know a syscall number it returns -ENOSYS but
> > when kexec does not know a syscall number it returns -1. Return -ENOSYS
> > from kexec as well.
> > 
> > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > ---
> >  kexec/kexec.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/kexec/kexec.c b/kexec/kexec.c
> > index cfd837c1b6bb..ab8cff7fe083 100644
> > --- a/kexec/kexec.c
> > +++ b/kexec/kexec.c
> > @@ -1166,7 +1166,7 @@ static int do_kexec_file_load(int fileind, int argc, char **argv,
> >  
> >  	if (!is_kexec_file_load_implemented()) {
> >  		fprintf(stderr, "syscall kexec_file_load not available.\n");
> > -		return -1;
> > +		return -ENOSYS;
> >  	}
> >  
> >  	if (argc - fileind <= 0) {
> > -- 
> > 2.13.6
> > 
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec

Thanks
Dave

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec