From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH v2 2/3] arm64: dts: renesas: salvator-common: Configure PMIC for DDR Backup Power Date: Mon, 26 Mar 2018 11:06:25 +0200 Message-ID: <20180326090625.espsuzblp7gy767t@verge.net.au> References: <1521029386-29975-1-git-send-email-geert+renesas@glider.be> <1521029386-29975-3-git-send-email-geert+renesas@glider.be> <9c6289e4-23dd-c79b-bd1f-058d843739d2@cogentembedded.com> <1ae32fee-578e-1091-561a-200a8036b670@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1ae32fee-578e-1091-561a-200a8036b670@cogentembedded.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sergei Shtylyov Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Geert Uytterhoeven , Magnus Damm , Linux-Renesas , Geert Uytterhoeven , Linux ARM , Marek Vasut List-Id: devicetree@vger.kernel.org On Fri, Mar 16, 2018 at 03:08:13PM +0300, Sergei Shtylyov wrote: > On 03/16/2018 03:00 PM, Geert Uytterhoeven wrote: > > >>> On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails > >>> need to be kept powered when backup mode is enabled. Reflect this in > >>> the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node. > >>> > >>> The accessory power switch (SW23) is a toggle switch, hense specify > >>> "rohm,rstbmode-level". > >>> > >>> Signed-off-by: Geert Uytterhoeven > >>> --- > >>> v2: > >>> - Add rohm,rstbmode-level. > >>> --- > >>> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > >>> index 2a7f36abd2dd85c6..80794c38c2669d75 100644 > >>> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi > >>> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > >>> @@ -376,6 +376,8 @@ > >>> #interrupt-cells = <2>; > >>> gpio-controller; > >>> #gpio-cells = <2>; > >>> + rohm,ddr-backup-power = <15>; > >> > >> Why not 0xf if those are all bit flags? > > > > Because it's a small number? > > Does it matter? > > I think hex is preferable for the bit flags. Decimal makes one think it's something > else -- some magnitude, etc... Geert, it seems that Rob Herring is of the same opinion. Would you care to respin this series? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from kirsty.vergenet.net ([202.4.237.240]:45279 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751035AbeCZJG3 (ORCPT ); Mon, 26 Mar 2018 05:06:29 -0400 Date: Mon, 26 Mar 2018 11:06:25 +0200 From: Simon Horman To: Sergei Shtylyov Cc: Geert Uytterhoeven , Geert Uytterhoeven , Magnus Damm , Marek Vasut , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM Subject: Re: [PATCH v2 2/3] arm64: dts: renesas: salvator-common: Configure PMIC for DDR Backup Power Message-ID: <20180326090625.espsuzblp7gy767t@verge.net.au> References: <1521029386-29975-1-git-send-email-geert+renesas@glider.be> <1521029386-29975-3-git-send-email-geert+renesas@glider.be> <9c6289e4-23dd-c79b-bd1f-058d843739d2@cogentembedded.com> <1ae32fee-578e-1091-561a-200a8036b670@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1ae32fee-578e-1091-561a-200a8036b670@cogentembedded.com> Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Fri, Mar 16, 2018 at 03:08:13PM +0300, Sergei Shtylyov wrote: > On 03/16/2018 03:00 PM, Geert Uytterhoeven wrote: > > >>> On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails > >>> need to be kept powered when backup mode is enabled. Reflect this in > >>> the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node. > >>> > >>> The accessory power switch (SW23) is a toggle switch, hense specify > >>> "rohm,rstbmode-level". > >>> > >>> Signed-off-by: Geert Uytterhoeven > >>> --- > >>> v2: > >>> - Add rohm,rstbmode-level. > >>> --- > >>> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > >>> index 2a7f36abd2dd85c6..80794c38c2669d75 100644 > >>> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi > >>> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > >>> @@ -376,6 +376,8 @@ > >>> #interrupt-cells = <2>; > >>> gpio-controller; > >>> #gpio-cells = <2>; > >>> + rohm,ddr-backup-power = <15>; > >> > >> Why not 0xf if those are all bit flags? > > > > Because it's a small number? > > Does it matter? > > I think hex is preferable for the bit flags. Decimal makes one think it's something > else -- some magnitude, etc... Geert, it seems that Rob Herring is of the same opinion. Would you care to respin this series? From mboxrd@z Thu Jan 1 00:00:00 1970 From: horms@verge.net.au (Simon Horman) Date: Mon, 26 Mar 2018 11:06:25 +0200 Subject: [PATCH v2 2/3] arm64: dts: renesas: salvator-common: Configure PMIC for DDR Backup Power In-Reply-To: <1ae32fee-578e-1091-561a-200a8036b670@cogentembedded.com> References: <1521029386-29975-1-git-send-email-geert+renesas@glider.be> <1521029386-29975-3-git-send-email-geert+renesas@glider.be> <9c6289e4-23dd-c79b-bd1f-058d843739d2@cogentembedded.com> <1ae32fee-578e-1091-561a-200a8036b670@cogentembedded.com> Message-ID: <20180326090625.espsuzblp7gy767t@verge.net.au> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Mar 16, 2018 at 03:08:13PM +0300, Sergei Shtylyov wrote: > On 03/16/2018 03:00 PM, Geert Uytterhoeven wrote: > > >>> On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails > >>> need to be kept powered when backup mode is enabled. Reflect this in > >>> the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node. > >>> > >>> The accessory power switch (SW23) is a toggle switch, hense specify > >>> "rohm,rstbmode-level". > >>> > >>> Signed-off-by: Geert Uytterhoeven > >>> --- > >>> v2: > >>> - Add rohm,rstbmode-level. > >>> --- > >>> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > >>> index 2a7f36abd2dd85c6..80794c38c2669d75 100644 > >>> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi > >>> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > >>> @@ -376,6 +376,8 @@ > >>> #interrupt-cells = <2>; > >>> gpio-controller; > >>> #gpio-cells = <2>; > >>> + rohm,ddr-backup-power = <15>; > >> > >> Why not 0xf if those are all bit flags? > > > > Because it's a small number? > > Does it matter? > > I think hex is preferable for the bit flags. Decimal makes one think it's something > else -- some magnitude, etc... Geert, it seems that Rob Herring is of the same opinion. Would you care to respin this series?