From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751220AbeCZTbr (ORCPT ); Mon, 26 Mar 2018 15:31:47 -0400 Received: from mail.skyhub.de ([5.9.137.197]:36766 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750983AbeCZTbq (ORCPT ); Mon, 26 Mar 2018 15:31:46 -0400 Date: Mon, 26 Mar 2018 21:30:52 +0200 From: Borislav Petkov To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org Subject: Re: [PATCH 1/2] Revert "x86/mce/AMD: Collect error info even if valid bits are not set" Message-ID: <20180326193052.GJ25548@pd.tnic> References: <20180326191526.64314-1-Yazen.Ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180326191526.64314-1-Yazen.Ghannam@amd.com> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 26, 2018 at 02:15:25PM -0500, Yazen Ghannam wrote: > From: Yazen Ghannam > > This reverts commit 4b1e84276a6172980c5bf39aa091ba13e90d6dad. > > Software uses the valid bits to decide if the values can be used for > further processing or other actions. So setting the valid bits will have > software act on values that it shouldn't be acting on. > > The recommendation to save all the register values does not mean that > the values are always valid. So what does that "Error handlers should save the values in MCA_ADDR, MCA_MISC0, and MCA_SYND even if MCA_STATUS[AddrV], MCA_STATUS[MiscV], and MCA_STATUS[SyndV] are zero." *actually* mean then? It is still in the PPR. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/2] Revert "x86/mce/AMD: Collect error info even if valid bits are not set" From: Borislav Petkov Message-Id: <20180326193052.GJ25548@pd.tnic> Date: Mon, 26 Mar 2018 21:30:52 +0200 To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org List-ID: T24gTW9uLCBNYXIgMjYsIDIwMTggYXQgMDI6MTU6MjVQTSAtMDUwMCwgWWF6ZW4gR2hhbm5hbSB3 cm90ZToKPiBGcm9tOiBZYXplbiBHaGFubmFtIDx5YXplbi5naGFubmFtQGFtZC5jb20+Cj4gCj4g VGhpcyByZXZlcnRzIGNvbW1pdCA0YjFlODQyNzZhNjE3Mjk4MGM1YmYzOWFhMDkxYmExM2U5MGQ2 ZGFkLgo+IAo+IFNvZnR3YXJlIHVzZXMgdGhlIHZhbGlkIGJpdHMgdG8gZGVjaWRlIGlmIHRoZSB2 YWx1ZXMgY2FuIGJlIHVzZWQgZm9yCj4gZnVydGhlciBwcm9jZXNzaW5nIG9yIG90aGVyIGFjdGlv bnMuIFNvIHNldHRpbmcgdGhlIHZhbGlkIGJpdHMgd2lsbCBoYXZlCj4gc29mdHdhcmUgYWN0IG9u IHZhbHVlcyB0aGF0IGl0IHNob3VsZG4ndCBiZSBhY3Rpbmcgb24uCj4gCj4gVGhlIHJlY29tbWVu ZGF0aW9uIHRvIHNhdmUgYWxsIHRoZSByZWdpc3RlciB2YWx1ZXMgZG9lcyBub3QgbWVhbiB0aGF0 Cj4gdGhlIHZhbHVlcyBhcmUgYWx3YXlzIHZhbGlkLgoKU28gd2hhdCBkb2VzIHRoYXQKCiJFcnJv ciBoYW5kbGVycyBzaG91bGQgc2F2ZSB0aGUgdmFsdWVzIGluIE1DQV9BRERSLCBNQ0FfTUlTQzAs CmFuZCBNQ0FfU1lORCBldmVuIGlmIE1DQV9TVEFUVVNbQWRkclZdLCBNQ0FfU1RBVFVTW01pc2NW XSwgYW5kCk1DQV9TVEFUVVNbU3luZFZdIGFyZSB6ZXJvLiIKCiphY3R1YWxseSogbWVhbiB0aGVu PwoKSXQgaXMgc3RpbGwgaW4gdGhlIFBQUi4K