From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <kexec-bounces+dwmw2=infradead.org@lists.infradead.org>
Received: from mx2.suse.de ([195.135.220.15])
 by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux))
 id 1f0Wgm-0000Ef-01
 for kexec@lists.infradead.org; Mon, 26 Mar 2018 18:17:49 +0000
Date: Mon, 26 Mar 2018 20:17:34 +0200
From: Michal =?UTF-8?B?U3VjaMOhbmVr?= <msuchanek@suse.de>
Subject: Re: [PATCH v5 1/5] kexec: Return -ENOSYS when kexec does not know
 how to call KEXEC_FILE_LOAD
Message-ID: <20180326201734.34ba54b3@kitsune.suse.cz>
In-Reply-To: <20180326075324.GA22899@dhcp-128-65.nay.redhat.com>
References: <20180302091706.GA15374@dhcp-128-65.nay.redhat.com>
 <e810acd57d9fc2d7ba3b0e95d470c20de9948462.1521561315.git.msuchanek@suse.de>
 <20180326072558.iidgbvxi2fh7cjgu@verge.net.au>
 <20180326075324.GA22899@dhcp-128-65.nay.redhat.com>
MIME-Version: 1.0
List-Id: <kexec.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/kexec>,
 <mailto:kexec-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/kexec/>
List-Post: <mailto:kexec@lists.infradead.org>
List-Help: <mailto:kexec-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/kexec>,
 <mailto:kexec-request@lists.infradead.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "kexec" <kexec-bounces@lists.infradead.org>
Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org
To: Dave Young <dyoung@redhat.com>
Cc: kexec@lists.infradead.org, Simon Horman <horms@verge.net.au>, Petr Tesarik <ptesarik@suse.cz>, Tony Jones <tonyj@suse.com>

On Mon, 26 Mar 2018 15:53:24 +0800
Dave Young <dyoung@redhat.com> wrote:

> Hi Simon
> On 03/26/18 at 09:25am, Simon Horman wrote:
> > Hi Michal, thanks for the updated patches.
> > 
> > Dave, are you planning to review this series?
> >   
> 
> I have same concern as I commented in last versioni, but seems
> we can not convince each other with Michal.
> 
> For example for -EINVAL/-ENOEXEC, since it can be some misc
> error checking in kernel code, it is not equal to an unsupported
> syscall.  I'm not keen to think broken kernel file (include the case
> for unsupported kernel format, but not limit to that) is equal as an
> unsupported syscall

I do not say it is equal to unsupported syscall. However, the kernel
cannot really tell if the image is complete garbage or if it is in
format it does not understand. The only way to check that is trying to
load in the old way. I don't see any way around that if we want an
--auto option which is of any use.

> 
> Also seems the new options are not showing in `kexec -h` although
> added in the man page.

Yes, that's another place where the description should be added.

Thanks

Michal

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec