From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752892AbeCZWZe (ORCPT ); Mon, 26 Mar 2018 18:25:34 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:33295 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752847AbeCZWZQ (ORCPT ); Mon, 26 Mar 2018 18:25:16 -0400 X-Google-Smtp-Source: AG47ELsKEe5zzrQjDAURC5iEmCnPG78hNobK2dHb2egwp7H4j+xIgtlctFYe+IHPgzv3WcDTtFVRCw== Date: Mon, 26 Mar 2018 17:25:14 -0500 From: Rob Herring To: Florian Fainelli Cc: Alexandre Belloni , "David S . Miller" , Allan Nielsen , razvan.stefanescu@nxp.com, po.liu@nxp.com, Thomas Petazzoni , Andrew Lunn , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Subject: Re: [PATCH net-next 4/8] dt-bindings: net: add DT bindings for Microsemi Ocelot Switch Message-ID: <20180326222514.4eciw66aihhcjgtw@rob-hp-laptop> References: <20180323201117.8416-1-alexandre.belloni@bootlin.com> <20180323201117.8416-5-alexandre.belloni@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 23, 2018 at 02:11:35PM -0700, Florian Fainelli wrote: > On 03/23/2018 01:11 PM, Alexandre Belloni wrote: > > DT bindings for the Ethernet switch found on Microsemi Ocelot platforms. > > > > Cc: Rob Herring > > Signed-off-by: Alexandre Belloni > > --- > > .../devicetree/bindings/net/mscc-ocelot.txt | 62 ++++++++++++++++++++++ > > 1 file changed, 62 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/mscc-ocelot.txt > > > > diff --git a/Documentation/devicetree/bindings/net/mscc-ocelot.txt b/Documentation/devicetree/bindings/net/mscc-ocelot.txt > > new file mode 100644 > > index 000000000000..ee092a85b5a0 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/mscc-ocelot.txt > > @@ -0,0 +1,62 @@ > > +Microsemi Ocelot network Switch > > +=============================== > > + > > +The Microsemi Ocelot network switch can be found on Microsemi SoCs (VSC7513, > > +VSC7514) > > + > > +Required properties: > > +- compatible: Should be "mscc,ocelot-switch" > > +- reg: Must contain an (offset, length) pair of the register set for each > > + entry in reg-names. > > +- reg-names: Must include the following entries: > > + - "sys" > > + - "rew" > > + - "qs" > > + - "hsio" > > + - "qsys" > > + - "ana" > > + - "portX" with X from 0 to the number of last port index available on that > > + switch > > +- interrupts: Should contain the switch interrupts for frame extraction and > > + frame injection > > +- interrupt-names: should contain the interrupt names: "xtr", "inj" > > You are not documenting the "ports" subnode(s).Please move the > individual ports definition under a ports subnode, mainly for two reasons: > > - it makes it easy at the .dtsi level to have all ports disabled by default > > - this makes you strictly conforming to the DSA binding for Ethernet > switches and this is good for consistency (both parsing code and just > representation). ports and port collide with the OF graph binding. It would be good if this moved to ethernet-port(s) or similar. Rob