From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH v2 2/3] arm64: dts: renesas: salvator-common: Configure PMIC for DDR Backup Power Date: Tue, 27 Mar 2018 10:17:16 +0200 Message-ID: <20180327081715.rab6rr4xobmgwofl@verge.net.au> References: <1521029386-29975-1-git-send-email-geert+renesas@glider.be> <1521029386-29975-3-git-send-email-geert+renesas@glider.be> <9c6289e4-23dd-c79b-bd1f-058d843739d2@cogentembedded.com> <1ae32fee-578e-1091-561a-200a8036b670@cogentembedded.com> <20180326090625.espsuzblp7gy767t@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Geert Uytterhoeven Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Sergei Shtylyov , Geert Uytterhoeven , Magnus Damm , Linux-Renesas , Linux ARM , Marek Vasut List-Id: devicetree@vger.kernel.org On Mon, Mar 26, 2018 at 11:13:54AM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Mon, Mar 26, 2018 at 11:06 AM, Simon Horman wrote: > > On Fri, Mar 16, 2018 at 03:08:13PM +0300, Sergei Shtylyov wrote: > >> On 03/16/2018 03:00 PM, Geert Uytterhoeven wrote: > >> > >> >>> On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails > >> >>> need to be kept powered when backup mode is enabled. Reflect this in > >> >>> the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node. > >> >>> > >> >>> The accessory power switch (SW23) is a toggle switch, hense specify > >> >>> "rohm,rstbmode-level". > >> >>> > >> >>> Signed-off-by: Geert Uytterhoeven > >> >>> --- > >> >>> v2: > >> >>> - Add rohm,rstbmode-level. > >> >>> --- > >> >>> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++ > >> >>> 1 file changed, 2 insertions(+) > >> >>> > >> >>> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > >> >>> index 2a7f36abd2dd85c6..80794c38c2669d75 100644 > >> >>> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi > >> >>> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > >> >>> @@ -376,6 +376,8 @@ > >> >>> #interrupt-cells = <2>; > >> >>> gpio-controller; > >> >>> #gpio-cells = <2>; > >> >>> + rohm,ddr-backup-power = <15>; > >> >> > >> >> Why not 0xf if those are all bit flags? > >> > > >> > Because it's a small number? > >> > Does it matter? > >> > >> I think hex is preferable for the bit flags. Decimal makes one think it's something > >> else -- some magnitude, etc... > > > > Geert, it seems that Rob Herring is of the same opinion. > > Would you care to respin this series? > > Sure, after the respun driver series has been accepted. Perfect, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 27 Mar 2018 10:17:16 +0200 From: Simon Horman To: Geert Uytterhoeven Cc: Sergei Shtylyov , Geert Uytterhoeven , Magnus Damm , Marek Vasut , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM Subject: Re: [PATCH v2 2/3] arm64: dts: renesas: salvator-common: Configure PMIC for DDR Backup Power Message-ID: <20180327081715.rab6rr4xobmgwofl@verge.net.au> References: <1521029386-29975-1-git-send-email-geert+renesas@glider.be> <1521029386-29975-3-git-send-email-geert+renesas@glider.be> <9c6289e4-23dd-c79b-bd1f-058d843739d2@cogentembedded.com> <1ae32fee-578e-1091-561a-200a8036b670@cogentembedded.com> <20180326090625.espsuzblp7gy767t@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: devicetree-owner@vger.kernel.org List-ID: On Mon, Mar 26, 2018 at 11:13:54AM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Mon, Mar 26, 2018 at 11:06 AM, Simon Horman wrote: > > On Fri, Mar 16, 2018 at 03:08:13PM +0300, Sergei Shtylyov wrote: > >> On 03/16/2018 03:00 PM, Geert Uytterhoeven wrote: > >> > >> >>> On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails > >> >>> need to be kept powered when backup mode is enabled. Reflect this in > >> >>> the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node. > >> >>> > >> >>> The accessory power switch (SW23) is a toggle switch, hense specify > >> >>> "rohm,rstbmode-level". > >> >>> > >> >>> Signed-off-by: Geert Uytterhoeven > >> >>> --- > >> >>> v2: > >> >>> - Add rohm,rstbmode-level. > >> >>> --- > >> >>> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++ > >> >>> 1 file changed, 2 insertions(+) > >> >>> > >> >>> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > >> >>> index 2a7f36abd2dd85c6..80794c38c2669d75 100644 > >> >>> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi > >> >>> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > >> >>> @@ -376,6 +376,8 @@ > >> >>> #interrupt-cells = <2>; > >> >>> gpio-controller; > >> >>> #gpio-cells = <2>; > >> >>> + rohm,ddr-backup-power = <15>; > >> >> > >> >> Why not 0xf if those are all bit flags? > >> > > >> > Because it's a small number? > >> > Does it matter? > >> > >> I think hex is preferable for the bit flags. Decimal makes one think it's something > >> else -- some magnitude, etc... > > > > Geert, it seems that Rob Herring is of the same opinion. > > Would you care to respin this series? > > Sure, after the respun driver series has been accepted. Perfect, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 From: horms@verge.net.au (Simon Horman) Date: Tue, 27 Mar 2018 10:17:16 +0200 Subject: [PATCH v2 2/3] arm64: dts: renesas: salvator-common: Configure PMIC for DDR Backup Power In-Reply-To: References: <1521029386-29975-1-git-send-email-geert+renesas@glider.be> <1521029386-29975-3-git-send-email-geert+renesas@glider.be> <9c6289e4-23dd-c79b-bd1f-058d843739d2@cogentembedded.com> <1ae32fee-578e-1091-561a-200a8036b670@cogentembedded.com> <20180326090625.espsuzblp7gy767t@verge.net.au> Message-ID: <20180327081715.rab6rr4xobmgwofl@verge.net.au> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Mar 26, 2018 at 11:13:54AM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Mon, Mar 26, 2018 at 11:06 AM, Simon Horman wrote: > > On Fri, Mar 16, 2018 at 03:08:13PM +0300, Sergei Shtylyov wrote: > >> On 03/16/2018 03:00 PM, Geert Uytterhoeven wrote: > >> > >> >>> On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails > >> >>> need to be kept powered when backup mode is enabled. Reflect this in > >> >>> the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node. > >> >>> > >> >>> The accessory power switch (SW23) is a toggle switch, hense specify > >> >>> "rohm,rstbmode-level". > >> >>> > >> >>> Signed-off-by: Geert Uytterhoeven > >> >>> --- > >> >>> v2: > >> >>> - Add rohm,rstbmode-level. > >> >>> --- > >> >>> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++ > >> >>> 1 file changed, 2 insertions(+) > >> >>> > >> >>> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > >> >>> index 2a7f36abd2dd85c6..80794c38c2669d75 100644 > >> >>> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi > >> >>> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > >> >>> @@ -376,6 +376,8 @@ > >> >>> #interrupt-cells = <2>; > >> >>> gpio-controller; > >> >>> #gpio-cells = <2>; > >> >>> + rohm,ddr-backup-power = <15>; > >> >> > >> >> Why not 0xf if those are all bit flags? > >> > > >> > Because it's a small number? > >> > Does it matter? > >> > >> I think hex is preferable for the bit flags. Decimal makes one think it's something > >> else -- some magnitude, etc... > > > > Geert, it seems that Rob Herring is of the same opinion. > > Would you care to respin this series? > > Sure, after the respun driver series has been accepted. Perfect, thanks!