From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754341AbeC0RSa (ORCPT ); Tue, 27 Mar 2018 13:18:30 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:44101 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753455AbeC0RS1 (ORCPT ); Tue, 27 Mar 2018 13:18:27 -0400 Date: Tue, 27 Mar 2018 19:18:17 +0200 From: Andrew Lunn To: Murali Karicheri Cc: robh+dt@kernel.org, mark.rutland@arm.com, ssantosh@kernel.org, malat@debian.org, w-kwok2@ti.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, davem@davemloft.net, netdev@vger.kernel.org Subject: Re: [net-next PATCH v2 03/10] net: netcp: ethss: make call to gbe_sgmii_config() conditional Message-ID: <20180327171817.GO5862@lunn.ch> References: <1522168309-12338-1-git-send-email-m-karicheri2@ti.com> <1522168309-12338-4-git-send-email-m-karicheri2@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1522168309-12338-4-git-send-email-m-karicheri2@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 27, 2018 at 12:31:42PM -0400, Murali Karicheri wrote: > As a preparatory patch to add support for 2u cpsw hardware found on > K2G SoC, make call to gbe_sgmii_config() conditional. This is required > since 2u uses RGMII interface instead of SGMII and to allow for driver > re-use. > > Signed-off-by: Murali Karicheri > --- > drivers/net/ethernet/ti/netcp_ethss.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/ti/netcp_ethss.c b/drivers/net/ethernet/ti/netcp_ethss.c > index 56dbc0b..1dea891 100644 > --- a/drivers/net/ethernet/ti/netcp_ethss.c > +++ b/drivers/net/ethernet/ti/netcp_ethss.c > @@ -2271,7 +2271,8 @@ static int gbe_slave_open(struct gbe_intf *gbe_intf) > > void (*hndlr)(struct net_device *) = gbe_adjust_link; > > - gbe_sgmii_config(priv, slave); > + if ((priv->ss_version == GBE_SS_VERSION_14) || IS_SS_ID_NU(priv)) > + gbe_sgmii_config(priv, slave); Or maybe: if (slave->phy_node == PHY_INTERFACE_MODE_SGMII) gbe_sgmii_config(priv, slave); Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [net-next PATCH v2 03/10] net: netcp: ethss: make call to gbe_sgmii_config() conditional Date: Tue, 27 Mar 2018 19:18:17 +0200 Message-ID: <20180327171817.GO5862@lunn.ch> References: <1522168309-12338-1-git-send-email-m-karicheri2@ti.com> <1522168309-12338-4-git-send-email-m-karicheri2@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, malat@debian.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, w-kwok2@ti.com, robh+dt@kernel.org, ssantosh@kernel.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org To: Murali Karicheri Return-path: Content-Disposition: inline In-Reply-To: <1522168309-12338-4-git-send-email-m-karicheri2@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org On Tue, Mar 27, 2018 at 12:31:42PM -0400, Murali Karicheri wrote: > As a preparatory patch to add support for 2u cpsw hardware found on > K2G SoC, make call to gbe_sgmii_config() conditional. This is required > since 2u uses RGMII interface instead of SGMII and to allow for driver > re-use. > > Signed-off-by: Murali Karicheri > --- > drivers/net/ethernet/ti/netcp_ethss.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/ti/netcp_ethss.c b/drivers/net/ethernet/ti/netcp_ethss.c > index 56dbc0b..1dea891 100644 > --- a/drivers/net/ethernet/ti/netcp_ethss.c > +++ b/drivers/net/ethernet/ti/netcp_ethss.c > @@ -2271,7 +2271,8 @@ static int gbe_slave_open(struct gbe_intf *gbe_intf) > > void (*hndlr)(struct net_device *) = gbe_adjust_link; > > - gbe_sgmii_config(priv, slave); > + if ((priv->ss_version == GBE_SS_VERSION_14) || IS_SS_ID_NU(priv)) > + gbe_sgmii_config(priv, slave); Or maybe: if (slave->phy_node == PHY_INTERFACE_MODE_SGMII) gbe_sgmii_config(priv, slave); Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Tue, 27 Mar 2018 19:18:17 +0200 Subject: [net-next PATCH v2 03/10] net: netcp: ethss: make call to gbe_sgmii_config() conditional In-Reply-To: <1522168309-12338-4-git-send-email-m-karicheri2@ti.com> References: <1522168309-12338-1-git-send-email-m-karicheri2@ti.com> <1522168309-12338-4-git-send-email-m-karicheri2@ti.com> Message-ID: <20180327171817.GO5862@lunn.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Mar 27, 2018 at 12:31:42PM -0400, Murali Karicheri wrote: > As a preparatory patch to add support for 2u cpsw hardware found on > K2G SoC, make call to gbe_sgmii_config() conditional. This is required > since 2u uses RGMII interface instead of SGMII and to allow for driver > re-use. > > Signed-off-by: Murali Karicheri > --- > drivers/net/ethernet/ti/netcp_ethss.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/ti/netcp_ethss.c b/drivers/net/ethernet/ti/netcp_ethss.c > index 56dbc0b..1dea891 100644 > --- a/drivers/net/ethernet/ti/netcp_ethss.c > +++ b/drivers/net/ethernet/ti/netcp_ethss.c > @@ -2271,7 +2271,8 @@ static int gbe_slave_open(struct gbe_intf *gbe_intf) > > void (*hndlr)(struct net_device *) = gbe_adjust_link; > > - gbe_sgmii_config(priv, slave); > + if ((priv->ss_version == GBE_SS_VERSION_14) || IS_SS_ID_NU(priv)) > + gbe_sgmii_config(priv, slave); Or maybe: if (slave->phy_node == PHY_INTERFACE_MODE_SGMII) gbe_sgmii_config(priv, slave); Andrew