From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751347AbeC0TZH (ORCPT ); Tue, 27 Mar 2018 15:25:07 -0400 Received: from mout.gmx.net ([212.227.17.20]:38817 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751025AbeC0TZF (ORCPT ); Tue, 27 Mar 2018 15:25:05 -0400 Date: Tue, 27 Mar 2018 21:24:10 +0200 From: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= To: Michael Ellerman Cc: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Paul Mackerras , Joel Stanley , Guenter Roeck Subject: Re: [PATCH 3/5] powerpc/mm/32: Use page_is_ram to check for RAM Message-ID: <20180327192410.nvu6s4ekctuuybnn@latitude> References: <20180222121516.23415-1-j.neuschaefer@gmx.net> <20180222121516.23415-4-j.neuschaefer@gmx.net> <874llcha6p.fsf@concordia.ellerman.id.au> <87y3iofh2z.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="odiormwvl2eyppks" Content-Disposition: inline In-Reply-To: <87y3iofh2z.fsf@concordia.ellerman.id.au> User-Agent: NeoMutt/20170113 (1.7.2) X-Provags-ID: V03:K0:1CbICMpYykYD8lC01PI6ksqKb5AShvlFKwT3VdwgrNveq9DVuNt SU29knKEbBrr0hEV7/NdiJURdtMfBASmG4DpC6ava1u+eHzxygjJ2K1T5+cGVr+9HETCWQk IIyQ8hpWPrZB1G1H7oelLGoNQrkbcq09jzomBd45zTD8P/MOyfcJ//xxsd1wx0BdLkJOo04 YS4hmDWhGYp+22hzoPNLQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:3BhdNVHqUKQ=:xQIJbMFxwlyFdzAL9kvL7I hpAddcH2R1v9fMq7PCldswEMDSKEZtP0+c8uhpyYTeSp2tfXkQG3ipDDwF0GyBITcMu7HoUcw Qq9bH6UrTa8sRlRpna95uqt30S8nLejU3vZxO5+FgebTeLw1aq0HkQThvsrS3IoOJIrPc6Kki 0hqBQ2LouCTmATa7P+jButnJt2rW6I/seFD/omFfa6kcky5pFJtbr526pp8kqlMoJQw1wb6Yw bQphhBQW6C+VkcrsT/GeRFJpAmRkAXEc/PWiohNotbrnXiUcFAbwaVkGMMoPE/OH4lNP5vvLs lO56Zil2F5uYJg0XGk1n4FoAKqp1/EJ8ZlOaX1qjPPJ/s2wpzFAOLEqh2zKHO0r1c4G75hYi6 uX28TfqPvTT8FT6di3vJKfB9gH6vfH5QVUASxkdKhPIDIlOHjVDRj02X9tPFCRp7kcAt2QK73 zHDqN9s3kUkVu4kGAc2kY02i9u9va+P0hyE5tLSIXS05IERj+8CDoYN7co/BRu6YRr9PDd8ww JKfJm2XyJ6RXUCQxoD7ci002Rf58BVi/UFt5aMhwUt77O3K8oKhEETJVV2mg1BPoj3wptm0aM dokFoT0zBYKNv5eqVb2CZyMth6HPidgjOlFGWINt1Y4KBTDu68jGF+bPfpzfJ2KKlPnMn3UoM fASiA2imaNyLhufTxMgNAgwI/f5hwMXh+SvUUlTD0OkSEdIB1mr/4AbV3FKU4XLRq3IqiasWc SuXxbvPMVPkp9wjk9fPNCd1HIz3be9qtCEvq2ioSmKLs9o7BkAzf8uo/HJ4HFJK7frdFaaZSo 1wYrWqHr4xuy3xz6Y7Ed4pk+9waXQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --odiormwvl2eyppks Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Mar 19, 2018 at 10:19:32PM +1100, Michael Ellerman wrote: > Michael Ellerman writes: > > Jonathan Neusch=C3=A4fer writes: [...] > >> - if (slab_is_available() && (p < virt_to_phys(high_memory)) && > >> + if (page_is_ram(__phys_to_pfn(p)) && > >> !(__allow_ioremap_reserved && memblock_is_region_reserved(p, siz= e))) { > >> printk("__ioremap(): phys addr 0x%llx is RAM lr %ps\n", > >> (unsigned long long)p, __builtin_return_address(0)); > > > > > > This is killing my p5020ds (Freescale e5500) unfortunately: >=20 > Duh, I should actually read the patch :) >=20 > This is a 32-bit system with 4G of RAM, so not all of RAM is mapped, > some of it is highem which is why removing the test against high_memory > above breaks it. >=20 > So I need the high_memory test on this system. This is an oversight on my part. I thought I wouldn't need this test because the memblock-based test is more accurate, but I didn't think through how high memory actually works. > I'm not clear why it was a problem for you on the Wii, do you even build > the Wii kernel with HIGHMEM enabled? No. The Wii works fine with the p < virt_to_phys(high_memory) test, and doesn't use CONFIG_HIGHMEM. I'll send a version two of this patchset. Thanks for testing, Jonathan Neusch=C3=A4fer --odiormwvl2eyppks Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJauppRAAoJEAgwRJqO81/b5NYP/jkaQNZCNCajFmaHnqWkrQvb AxOfaAW6X8ovEeTBfDzuw95k9IggHnK8I5q0+BBiAaW+Sr3DSfvVAU7s7yskIyw9 +VoblsmJblgCRbE7O5Z+gn7eDJwEtZsssBbq1jo2SVfoo+h/mKyt+sHfdNFGHf80 nZy4O66uL43VHqc7F5ZLXfPe2hhjepnfCMu3vZhaIM7jeAKxL1yUyvD8j/iKVFm7 7MnyksFbUemVpM+R/Vs52Cn8Pg1bipNX2cqqc7ewEdl0cELz+TU+k66Rd7JXVTCt 9o9xTSIC67BSks6JvwTuHX3Z76cWFY85vKZ7WKlt+Z1idIdZZH2kVEZ+C0efegit DXX0hcxWJKx2XUp4O0NeFk9IDF6bJ0LwQ7J7waf1TGeASFobgABx+hUK7mvtfifg OmrN2/59KVswGWxA7vkIx/HK8aWlA2YPposb99LIlHS7N4aQjCTHaSm9nyO+vQvN ROJQ3vthGSWeE+v83CXgtLLpu5sLN10IZNCavlVLNhiMRg4GkkfsMu34J7l+bEn3 dvYAuY9fppNe7B/+0zNeaoZpJAko3zly851wqHx//l+glUbBOPTyCOJmc3LC9Git INjN1o0BHOK9AB717V/bP+5R9la7AaYxM012vs9VfB+Aa2UUsgyHweHb/4TDK0c2 ewozCrRV9FEJ4WXWzIcB =e+pw -----END PGP SIGNATURE----- --odiormwvl2eyppks--