From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet Subject: Re: [PATCH v3 10/20] eal/dev: implement device iteration initialization Date: Tue, 27 Mar 2018 22:20:40 +0200 Message-ID: <20180327202040.rd3yixr67c3jbx4p@bidouze.vm.6wind.com> References: <20180327114750.GA30585@hmswarspite.think-freely.org> <20180327124000.6n63hpng53tm3bil@bidouze.vm.6wind.com> <20180327182633.GC30585@hmswarspite.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org, "Wiles, Keith" To: Neil Horman Return-path: Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com [209.85.128.170]) by dpdk.org (Postfix) with ESMTP id 67B8B2BDF for ; Tue, 27 Mar 2018 22:20:56 +0200 (CEST) Received: by mail-wr0-f170.google.com with SMTP id y55so164981wry.3 for ; Tue, 27 Mar 2018 13:20:56 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180327182633.GC30585@hmswarspite.think-freely.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Mar 27, 2018 at 02:26:33PM -0400, Neil Horman wrote: > On Tue, Mar 27, 2018 at 02:40:00PM +0200, Gaëtan Rivet wrote: > > On Tue, Mar 27, 2018 at 07:47:50AM -0400, Neil Horman wrote: > > > On Tue, Mar 27, 2018 at 01:18:34AM +0200, Gaetan Rivet wrote: > > > > Parse a device description. > > > > Split this description in their relevant part for each layers. > > > > No dynamic allocation is performed. > > > > > > > > Cc: Neil Horman > > > > Cc: "Wiles, Keith" > > > > Signed-off-by: Gaetan Rivet > > > > --- > > > > > > > > This version uses librte_kvargs. > > > > > > > > > > Otherwise, this looks pretty good to me > > > > Please look into the librte_kvargs compatibility patch as well (quite > > short). I'm very unhappy about the logging hack. > > There is always the solution of setting a function pointer on rte_log > > with the proper loglevels and so on. > > Ideally rte_log could be made independent (starting skimming EAL from > > all the fat), but this is much less trivial. > > > just posted about that. I agree with Keith, I don't think you should need that > patch. RTE_LOG just calls rte_vlog which contains this code: > > if (f == NULL) { > f = default_log_stream; > if (f == NULL) { > /* > * Grab the current value of stderr here, rather than > * just initializing default_log_stream to stderr. This > * ensures that we will always use the current value > * of stderr, even if the application closes and > * reopens it. > */ > f = stderr; > } > } > } > > Which I read as saying that the logging library should back off to stderr if its > not initialized yet. If you've encountered a problem that made you need that > logging patch, it seems like you should be able to drop it, and we need to fix > the logging library. Can you elaborate on what you ran into here? > > Neil Neat. The issue is that rte_log.h is not symlink-ed until librte_eal is processed. rte_log cannot be included. I know Keith and Bruce discussed a few months back the possibility of having an initial linking pass. Personally I am still against this kind of solution, hiding design issues under the rug. -- Gaëtan Rivet 6WIND