All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
	patches@opensource.cirrus.com,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH][RFC] ASoC: wm8350: remove snd_soc_codec
Date: Wed, 28 Mar 2018 10:48:35 +0100	[thread overview]
Message-ID: <20180328094835.hzthjeoq6vpdgjgm@localhost.localdomain> (raw)
In-Reply-To: <87tvt13psj.wl%kuninori.morimoto.gx@renesas.com>

On Wed, Mar 28, 2018 at 02:22:07AM +0000, Kuninori Morimoto wrote:
> 
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> codec is replace to component.
> It seems no-one is using it, Let's remove it.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> Hi Mark, Liam
> 
> I think no-one is using snd_soc_codec, but please double-check it.
> I added [RFC] on this patch
> 

Looks to me like there are still users in
drivers/mfd/cwm8350-core.c:

wm8350_client_dev_register(wm8350, "wm8350-codec",
			   &(wm8350->codec.pdev));

And arch/arm/mach-imx/mach-mx31ads.c:

wm8350->codec.platform_data = &imx32ads_wm8350_setup;

Also it should be simple enough to build test drivers for patches
like this, you don't need to have the hardware to build the driver.

Thanks,
Charles

  reply	other threads:[~2018-03-28  9:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28  2:22 [PATCH][RFC] ASoC: wm8350: remove snd_soc_codec Kuninori Morimoto
2018-03-28  9:48 ` Charles Keepax [this message]
2018-03-28 23:56   ` Kuninori Morimoto
2018-03-29 10:56     ` Charles Keepax
2018-04-12 16:16 ` Applied "ASoC: wm8350: remove snd_soc_codec" to the asoc tree Mark Brown
2018-04-13 10:56 ` Mark Brown
2018-04-13 11:24 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180328094835.hzthjeoq6vpdgjgm@localhost.localdomain \
    --to=ckeepax@opensource.cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=patches@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.