From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752654AbeC1L5G (ORCPT ); Wed, 28 Mar 2018 07:57:06 -0400 Received: from verein.lst.de ([213.95.11.211]:45378 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbeC1L5E (ORCPT ); Wed, 28 Mar 2018 07:57:04 -0400 Date: Wed, 28 Mar 2018 13:57:03 +0200 From: Christoph Hellwig To: Sebastian Ott Cc: Christoph Hellwig , Jesper Nilsson , Geert Uytterhoeven , linux-kernel@vger.kernel.org Subject: Re: dma_zalloc_coherent broken with 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7 Message-ID: <20180328115703.GA31426@lst.de> References: <20180327143341.GA4968@lst.de> <20180327164505.GA10522@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 27, 2018 at 07:04:51PM +0200, Sebastian Ott wrote: > What was wrong with the old behavior (let the caller decide - the same > as with memory allocations)? The old behavior on most (all?) mainstream architectures is that we always zero the return value. On x86/i386 this goes back to at least Linux 2.4. So common drivers simply expect this to happen.