All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Guneshwor Singh <guneshwor.o.singh@intel.com>,
	Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
	Libin Yang <libin.yang@intel.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda_intel: mark PM functions as __maybe_unused
Date: Wed, 28 Mar 2018 16:31:50 +0200	[thread overview]
Message-ID: <20180328143150.GA17992@wunner.de> (raw)
In-Reply-To: <20180328142020.3275989-1-arnd@arndb.de>

On Wed, Mar 28, 2018 at 04:19:29PM +0200, Arnd Bergmann wrote:
> Two callsites of azx_suspend/azx_resume were removed, leaving these
> functions only called from the optional SET_SYSTEM_SLEEP_PM_OPS()
> and causing a warning without CONFIG_PM_SLEEP:
> 
> sound/pci/hda/hda_intel.c:1029:12: error: 'azx_resume' defined but not used [-Werror=unused-function]
>  static int azx_resume(struct device *dev)
>             ^~~~~~~~~~
> sound/pci/hda/hda_intel.c:994:12: error: 'azx_suspend' defined but not used [-Werror=unused-function]
>  static int azx_suspend(struct device *dev)
>             ^~~~~~~~~~~
> 
> Keeping track of the correct #ifdef checks is hard, so this removes
> all the #ifdefs for power management in this file and instead uses
> __maybe_unused annotations that let the compiler do the job right
> by itself.

Ugh, this isn't as hard as it may seem, just replace

	#if defined(CONFIG_PM_SLEEP) || defined(SUPPORT_VGA_SWITCHEROO)

with

	#if defined(CONFIG_PM_SLEEP)

That way it's just a simple one line change which is less intrusive.

Care to respin like this?

Thanks for the report,

Lukas

  reply	other threads:[~2018-03-28 14:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28 14:19 [PATCH] ALSA: hda_intel: mark PM functions as __maybe_unused Arnd Bergmann
2018-03-28 14:19 ` Arnd Bergmann
2018-03-28 14:31 ` Lukas Wunner [this message]
2018-03-28 16:03   ` Takashi Iwai
2018-03-28 16:03     ` Takashi Iwai
2018-03-28 22:14   ` Arnd Bergmann
2018-03-29 11:59     ` Lukas Wunner
2018-03-29 11:59       ` Lukas Wunner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180328143150.GA17992@wunner.de \
    --to=lukas@wunner.de \
    --cc=Vijendar.Mukunda@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=guneshwor.o.singh@intel.com \
    --cc=hdegoede@redhat.com \
    --cc=libin.yang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.