All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc: register filesystem last
Date: Wed, 28 Mar 2018 15:47:49 +0100	[thread overview]
Message-ID: <20180328144748.GU30522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20180328072657.GA2063@avx2>

On Wed, Mar 28, 2018 at 10:26:57AM +0300, Alexey Dobriyan wrote:
> On Wed, Mar 28, 2018 at 05:48:23AM +0100, Al Viro wrote:
> > On Sat, Mar 10, 2018 at 03:06:34AM +0300, Alexey Dobriyan wrote:
> > > On Fri, Mar 09, 2018 at 02:49:38PM -0800, Andrew Morton wrote:
> > > > On Sat, 10 Mar 2018 01:27:09 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> > > > 
> > > > > As soon as register_filesystem() exits, filesystem can be mounted.
> > > > > It is better to present fully operational /proc.
> > > > > 
> > > > > Of course it doesn't matter because /proc is not modular
> > > > > but do it anyway.
> > > > > 
> > > > > Drop error check, it should be handled by panicking.
> > > > 
> > > > So... shouldn't we add a call to panic()?
> > > 
> > > via FS_PANIC flag, yes. I have a patch somewhere.
> > > There are 104 filesystems ATM, some internal, some not.
> > > Some modular, some not.
> > 
> > You do realize that the only case when register_filesystem() fails is
> > "another driver has already registered filesystem type with the same
> > name"?  Is there *ever* a case when
> > 	* you could expect that to happen and
> > 	* panic would be a sane response?
> 
> It is for standartizing all those error checks in init sequence by
> removing them. Modules won't have FS_PANIC.

Huh?  Again, _when_ is that thing appropriate?  To register_filesystem()
failure in non-modular case you need several builtin fs drivers to
try and register fs types with the same name.  In this particular
case, you need another in-kernel filesystem called "proc" registered
first.

It's not about extreme oom early in the boot or anything like that -
plain and simple badly modified and misconfigured kernel.

  reply	other threads:[~2018-03-28 14:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-09 22:27 Alexey Dobriyan
2018-03-09 22:49 ` Andrew Morton
2018-03-10  0:06   ` Alexey Dobriyan
2018-03-28  4:48     ` Al Viro
2018-03-28  7:26       ` Alexey Dobriyan
2018-03-28 14:47         ` Al Viro [this message]
2018-03-28 22:38           ` Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180328144748.GU30522@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] proc: register filesystem last' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.