All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
Cc: forest@alittletooquiet.net, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v4] staging: vt6655: Remove else after return
Date: Wed, 28 Mar 2018 19:39:20 +0200	[thread overview]
Message-ID: <20180328173920.GA15160@kroah.com> (raw)
In-Reply-To: <1522257283-2147-1-git-send-email-nishka.dasgupta_ug18@ashoka.edu.in>

On Wed, Mar 28, 2018 at 05:14:43PM +0000, Nishka Dasgupta wrote:
> Remove else after return. Issue found with checkpatch.
> 
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
> ---
>  drivers/staging/vt6655/rxtx.c | 37 ++++++++++++++++++-------------------
>  1 file changed, 18 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> index 9c4a532..ee327c2 100644
> --- a/drivers/staging/vt6655/rxtx.c
> +++ b/drivers/staging/vt6655/rxtx.c
> @@ -552,6 +552,7 @@ s_uFillDataHead(
>  			return buf->duration_a;
>  		} /* if (byFBOption == AUTO_FB_NONE) */
>  	} else if (byPktType == PK_TYPE_11A) {
> +		struct vnt_tx_datahead_ab *buf = pTxDataHead;
>  		if (byFBOption != AUTO_FB_NONE) {

Do not add checkpatch.pl warnings in patches you create to get rid of
other checkpatch.pl warnings :(

thanks,

greg k-h


      reply	other threads:[~2018-03-28 17:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28 17:14 [PATCH v4] staging: vt6655: Remove else after return Nishka Dasgupta
2018-03-28 17:39 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180328173920.GA15160@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=forest@alittletooquiet.net \
    --cc=nishka.dasgupta_ug18@ashoka.edu.in \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.