All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] readv.2, io_submit.2: Document RWF_APPEND added in Linux 4.16
@ 2018-03-28 19:49 Jürg Billeter
  2018-04-05 17:49 ` Michael Kerrisk (man-pages)
  0 siblings, 1 reply; 4+ messages in thread
From: Jürg Billeter @ 2018-03-28 19:49 UTC (permalink / raw)
  To: mtk.manpages; +Cc: linux-man, linux-kernel, Jürg Billeter

Signed-off-by: Jürg Billeter <j@bitron.ch>
---
 man2/io_submit.2 | 10 ++++++++++
 man2/readv.2     | 10 ++++++++++
 2 files changed, 20 insertions(+)

diff --git a/man2/io_submit.2 b/man2/io_submit.2
index 397fd0b75..79fcdfee4 100644
--- a/man2/io_submit.2
+++ b/man2/io_submit.2
@@ -111,6 +111,16 @@ field of the
 .I io_event
 structure (see
 .BR io_getevents (2)).
+.TP
+.BR RWF_APPEND " (since Linux 4.16)"
+.\" commit e1fc742e14e01d84d9693c4aca4ab23da65811fb
+Append data to the end of the file.
+See the description of the flag of the same name in
+.BR pwritev2 (2)
+as well as the description of
+.B O_APPEND
+in
+.BR open (2).
 .RE
 .TP
 .I aio_lio_opcode
diff --git a/man2/readv.2 b/man2/readv.2
index b3b7b9658..668fba576 100644
--- a/man2/readv.2
+++ b/man2/readv.2
@@ -248,6 +248,16 @@ to
 .BR EAGAIN .
 Currently, this flag is meaningful only for
 .BR preadv2 ().
+.TP
+.BR RWF_APPEND " (since Linux 4.16)"
+.\" commit e1fc742e14e01d84d9693c4aca4ab23da65811fb
+Provide a per-write equivalent of the
+.B O_APPEND
+.BR open (2)
+flag.
+This flag is meaningful only for
+.BR pwritev2 (),
+and its effect applies only to the data range written by the system call.
 .SH RETURN VALUE
 On success,
 .BR readv (),
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] readv.2, io_submit.2: Document RWF_APPEND added in Linux 4.16
  2018-03-28 19:49 [PATCH] readv.2, io_submit.2: Document RWF_APPEND added in Linux 4.16 Jürg Billeter
@ 2018-04-05 17:49 ` Michael Kerrisk (man-pages)
  2018-04-06 13:51   ` [PATCH v2] " Jürg Billeter
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Kerrisk (man-pages) @ 2018-04-05 17:49 UTC (permalink / raw)
  To: Jürg Billeter; +Cc: mtk.manpages, linux-man, linux-kernel

Hello Jürg

Thanks for the patch, but there are some details that are
unexplained in the text and in the kernel commit message.

Does the use of these flags change the file offset? The text
should make this point explicit.

Presumably, when using this flag for pwritev2(), the
'offset' argument of the call is ignored. Presumably, the
same is true for the 'aio_offset' field of the 'iocb'
structure when using io_submit(). This point should be
also be made explicit in the patch.

Would you be willing to revise the patch to include the
answers to these questions?

Cheers,

Michael


On 03/28/2018 09:49 PM, Jürg Billeter wrote:
> Signed-off-by: Jürg Billeter <j@bitron.ch>
> ---
>  man2/io_submit.2 | 10 ++++++++++
>  man2/readv.2     | 10 ++++++++++
>  2 files changed, 20 insertions(+)
> 
> diff --git a/man2/io_submit.2 b/man2/io_submit.2
> index 397fd0b75..79fcdfee4 100644
> --- a/man2/io_submit.2
> +++ b/man2/io_submit.2
> @@ -111,6 +111,16 @@ field of the
>  .I io_event
>  structure (see
>  .BR io_getevents (2)).
> +.TP
> +.BR RWF_APPEND " (since Linux 4.16)"
> +.\" commit e1fc742e14e01d84d9693c4aca4ab23da65811fb
> +Append data to the end of the file.
> +See the description of the flag of the same name in
> +.BR pwritev2 (2)
> +as well as the description of
> +.B O_APPEND
> +in
> +.BR open (2).
>  .RE
>  .TP
>  .I aio_lio_opcode
> diff --git a/man2/readv.2 b/man2/readv.2
> index b3b7b9658..668fba576 100644
> --- a/man2/readv.2
> +++ b/man2/readv.2
> @@ -248,6 +248,16 @@ to
>  .BR EAGAIN .
>  Currently, this flag is meaningful only for
>  .BR preadv2 ().
> +.TP
> +.BR RWF_APPEND " (since Linux 4.16)"
> +.\" commit e1fc742e14e01d84d9693c4aca4ab23da65811fb
> +Provide a per-write equivalent of the
> +.B O_APPEND
> +.BR open (2)
> +flag.
> +This flag is meaningful only for
> +.BR pwritev2 (),
> +and its effect applies only to the data range written by the system call.
>  .SH RETURN VALUE
>  On success,
>  .BR readv (),
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH v2] readv.2, io_submit.2: Document RWF_APPEND added in Linux 4.16
  2018-04-05 17:49 ` Michael Kerrisk (man-pages)
@ 2018-04-06 13:51   ` Jürg Billeter
  2018-04-12  9:11     ` Michael Kerrisk (man-pages)
  0 siblings, 1 reply; 4+ messages in thread
From: Jürg Billeter @ 2018-04-06 13:51 UTC (permalink / raw)
  To: mtk.manpages; +Cc: linux-man, linux-kernel, Jürg Billeter

Signed-off-by: Jürg Billeter <j@bitron.ch>
---
Changes since version 1:
- Explain offset handling

 man2/io_submit.2 | 13 +++++++++++++
 man2/readv.2     | 17 +++++++++++++++++
 2 files changed, 30 insertions(+)

diff --git a/man2/io_submit.2 b/man2/io_submit.2
index 397fd0b75..25961138a 100644
--- a/man2/io_submit.2
+++ b/man2/io_submit.2
@@ -111,6 +111,19 @@ field of the
 .I io_event
 structure (see
 .BR io_getevents (2)).
+.TP
+.BR RWF_APPEND " (since Linux 4.16)"
+.\" commit e1fc742e14e01d84d9693c4aca4ab23da65811fb
+Append data to the end of the file.
+See the description of the flag of the same name in
+.BR pwritev2 (2)
+as well as the description of
+.B O_APPEND
+in
+.BR open (2).
+The
+.I aio_offset
+field is ignored. The file offset is not changed.
 .RE
 .TP
 .I aio_lio_opcode
diff --git a/man2/readv.2 b/man2/readv.2
index b3b7b9658..9ef250e11 100644
--- a/man2/readv.2
+++ b/man2/readv.2
@@ -248,6 +248,23 @@ to
 .BR EAGAIN .
 Currently, this flag is meaningful only for
 .BR preadv2 ().
+.TP
+.BR RWF_APPEND " (since Linux 4.16)"
+.\" commit e1fc742e14e01d84d9693c4aca4ab23da65811fb
+Provide a per-write equivalent of the
+.B O_APPEND
+.BR open (2)
+flag.
+This flag is meaningful only for
+.BR pwritev2 (),
+and its effect applies only to the data range written by the system call.
+The
+.I offset
+argument does not affect the write operation, the data is always appended
+to the end of the file. However, if the
+.I offset
+argument is \-1, the current file offset is updated.
+This matches the behavior when the file is opened in append mode.
 .SH RETURN VALUE
 On success,
 .BR readv (),
-- 
2.16.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] readv.2, io_submit.2: Document RWF_APPEND added in Linux 4.16
  2018-04-06 13:51   ` [PATCH v2] " Jürg Billeter
@ 2018-04-12  9:11     ` Michael Kerrisk (man-pages)
  0 siblings, 0 replies; 4+ messages in thread
From: Michael Kerrisk (man-pages) @ 2018-04-12  9:11 UTC (permalink / raw)
  To: Jürg Billeter; +Cc: mtk.manpages, linux-man, linux-kernel

On 04/06/2018 03:51 PM, Jürg Billeter wrote:
> Signed-off-by: Jürg Billeter <j@bitron.ch>

Thanks, Jürg. Patch applied.

Cheers,

Michael


> ---
> Changes since version 1:
> - Explain offset handling
> 
>  man2/io_submit.2 | 13 +++++++++++++
>  man2/readv.2     | 17 +++++++++++++++++
>  2 files changed, 30 insertions(+)
> 
> diff --git a/man2/io_submit.2 b/man2/io_submit.2
> index 397fd0b75..25961138a 100644
> --- a/man2/io_submit.2
> +++ b/man2/io_submit.2
> @@ -111,6 +111,19 @@ field of the
>  .I io_event
>  structure (see
>  .BR io_getevents (2)).
> +.TP
> +.BR RWF_APPEND " (since Linux 4.16)"
> +.\" commit e1fc742e14e01d84d9693c4aca4ab23da65811fb
> +Append data to the end of the file.
> +See the description of the flag of the same name in
> +.BR pwritev2 (2)
> +as well as the description of
> +.B O_APPEND
> +in
> +.BR open (2).
> +The
> +.I aio_offset
> +field is ignored. The file offset is not changed.
>  .RE
>  .TP
>  .I aio_lio_opcode
> diff --git a/man2/readv.2 b/man2/readv.2
> index b3b7b9658..9ef250e11 100644
> --- a/man2/readv.2
> +++ b/man2/readv.2
> @@ -248,6 +248,23 @@ to
>  .BR EAGAIN .
>  Currently, this flag is meaningful only for
>  .BR preadv2 ().
> +.TP
> +.BR RWF_APPEND " (since Linux 4.16)"
> +.\" commit e1fc742e14e01d84d9693c4aca4ab23da65811fb
> +Provide a per-write equivalent of the
> +.B O_APPEND
> +.BR open (2)
> +flag.
> +This flag is meaningful only for
> +.BR pwritev2 (),
> +and its effect applies only to the data range written by the system call.
> +The
> +.I offset
> +argument does not affect the write operation, the data is always appended
> +to the end of the file. However, if the
> +.I offset
> +argument is \-1, the current file offset is updated.
> +This matches the behavior when the file is opened in append mode.
>  .SH RETURN VALUE
>  On success,
>  .BR readv (),
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-12  9:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-28 19:49 [PATCH] readv.2, io_submit.2: Document RWF_APPEND added in Linux 4.16 Jürg Billeter
2018-04-05 17:49 ` Michael Kerrisk (man-pages)
2018-04-06 13:51   ` [PATCH v2] " Jürg Billeter
2018-04-12  9:11     ` Michael Kerrisk (man-pages)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.