[LTP] [PATCH] setregid: use common user and group names.

[Sandeep Patil <sspatil@google.com>]

On Wed, Mar 28, 2018 at 08:07:00AM +0200, Petr Vorel wrote:
> Hi Sandeep,
> 
> ...
> > > > Also, I wouldn't worry about the test breaking on slightly older Android. The
> > > > vast majority of LTS tests are run through VTS, where these tests were disabled[1]
> > > > due to the failure anyway. This change will allow us to start running them on
> > > > all android devices now onwards ..
> 
> > > I thought that there could be preprocesor condition for Android defining different users
> > > for it, but if you don't need it I'll merge it.
> 
> > Yes, we can probable ifdef it in one place using "#ifdef __ANDROID__" or
> > other equivalent, but I don't think its needed here. We want to avoid doing
> > that as much as possible. It is fair to say these test will be run with VTS
> > "now onwards" anyway ..
> Thanks for explanation. I agree, makes sense to avoid it where possible.
> 
> > > and just note your related commit in commit
> > > message:
> > > 8e8648463 ("libcutils: Add "daemon" and "bin" users for testing only")
> 
> > I'll resend the patch with this added, thanks for the review.
> I'm sorry I've added it myself yesterday and pushed:
> 1b7cf9474 setregid: use common user and group names.
> 
> I'll be more patient next time.

Happy to see it merged, doesn't matter. Thanks for the feedback.

- ssp