All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	davem@davemloft.net, jaedon.shin@gmail.com, pgynther@google.com,
	opendmb@gmail.com, Michael Chan <michael.chan@broadcom.com>,
	gospo@broadcom.com, talgi@mellanox.com, saeedm@mellanox.com
Subject: [PATCH net-next v2 0/3] net: Broadcom drivers coalescing fixes
Date: Wed, 28 Mar 2018 15:15:35 -0700	[thread overview]
Message-ID: <20180328221538.29290-1-f.fainelli@gmail.com> (raw)

Hi all,

Following Tal's review of the adaptive RX/TX coalescing feature added to the
SYSTEMPORT and GENET driver a number of things showed up:

- adaptive TX coalescing is not actually a good idea with the current way
  the estimator will program the ring, this results in a higher CPU load, NAPI
  on TX already does a reasonably good job at maintaining the interrupt count low

- both SYSTEMPORT and GENET would suffer from the same issues while configuring
  coalescing parameters where the values would just not be applied correctly
  based on user settings, so we fix that too

Tal, thanks again for your feedback, I would appreciate if you could review that
the new behavior appears to be implemented correctly.

Thanks!

Changes in v2:

- added Tal's reviewed-by to the first patch
- split DIM initialization from coalescing parameters initialization
- avoid duplicating the same code in bcmgenet_set_coalesce() when configuring RX rings
- fixed the condition where default DIM parameters would be applied when
  adaptive RX coalescing would be enabled, do this only if it was disabled before

Florian Fainelli (3):
  net: systemport: Remove adaptive TX coalescing
  net: systemport: Fix coalescing settings handling
  net: bcmgenet: Fix coalescing settings handling

 drivers/net/ethernet/broadcom/bcmsysport.c     | 123 +++++++++++--------------
 drivers/net/ethernet/broadcom/bcmsysport.h     |   5 +-
 drivers/net/ethernet/broadcom/genet/bcmgenet.c |  92 +++++++++++-------
 drivers/net/ethernet/broadcom/genet/bcmgenet.h |   4 +-
 4 files changed, 115 insertions(+), 109 deletions(-)

-- 
2.14.1

             reply	other threads:[~2018-03-28 22:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28 22:15 Florian Fainelli [this message]
2018-03-28 22:15 ` [PATCH net-next v2 1/3] net: systemport: Remove adaptive TX coalescing Florian Fainelli
2018-03-28 22:15 ` [PATCH net-next v2 2/3] net: systemport: Fix coalescing settings handling Florian Fainelli
2018-03-29  7:42   ` Tal Gilboa
2018-03-28 22:15 ` [PATCH net-next v2 3/3] net: bcmgenet: " Florian Fainelli
2018-03-29  7:42   ` Tal Gilboa
2018-03-30 14:04 ` [PATCH net-next v2 0/3] net: Broadcom drivers coalescing fixes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180328221538.29290-1-f.fainelli@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=davem@davemloft.net \
    --cc=gospo@broadcom.com \
    --cc=jaedon.shin@gmail.com \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=opendmb@gmail.com \
    --cc=pgynther@google.com \
    --cc=saeedm@mellanox.com \
    --cc=talgi@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.